awk, bin/sh 0: 1: not found - bash

Question

I am almost brand-new to coding and I would appreciate feedback. I am trying to make a shell script that will evaluate information in a text file and moved said text file if certain conditions are met. My code is below:
#!/bin/bash
stock=HD
awk ' /Rank/ {
if ( $4 == "1-Strong" ) system("mv " "'$stock'.txt" " " ~/Desktop/Stocks/1/"'$stock'.txt") ;
else if ( $4 == "2-Buy" ) system("mv " "'$stock'.txt" " " ~/Desktop/Stocks/2/"'$stock'.txt") ;
else if ( $4 == "3-Hold" ) system("mv " "'$stock'.txt" " " ~/Desktop/Stocks/3/"'$stock'.txt") ;
else if ( $4 == "4-Sell" ) system("mv " "'$stock'.txt" " " ~/Desktop/Stocks/4/"'$stock'.txt") ;
else if ( $4 == "5-Strong" ) system("mv " "'$stock'.txt" " " ~/Desktop/Stocks/5/"'$stock'.txt")
} ' $stock.txt
When I try to run the script, I get this error:
andrew#andrew-VirtualBox:~/Desktop/Stocks$ ./stockscript7.sh
/bin/sh: 1: 0: not found
I made sure I was in bash shell. I did use chmod to give the script permissions. Otherwise from this error message I'm lost on what to try next. Any help would be much appreciated.

Answer 1

The following is a translation to native bash, with none of the bugs associated with abusing awk as you were (consider what would have happened with an input file named EVIL'$(rm -rf .)'.txt -- as created with the command touch $'EVIL\'$(rm -rf .)\'.txt'):
#!/bin/bash
stock=HD
while IFS= read -r line; do
[[ $line = *Rank* ]] || continue
read -r _ _ _ rank _ <<<"$line"
case $rank in
1-Strong) mv -- "$stock.txt" ~/Desktop/Stocks/1/ ;;
2-Buy) mv -- "$stock.txt" ~/Desktop/Stocks/2/ ;;
3-Hold) mv -- "$stock.txt" ~/Desktop/Stocks/3/ ;;
4-Sell) mv -- "$stock.txt" ~/Desktop/Stocks/4/ ;;
5-Strong) mv -- "$stock.txt" ~/Desktop/Stocks/5/ ;;
esac
done <"$stock.txt"
However, this doesn't make much sense as it's written: You're running one mv per line in the file matching Rank -- but you can't successfully move a single file more than once. Perhaps you just want to read the first line containing Rank, and rename the file according to the number preceding a dash in the fourth column?
#!/bin/bash
stock=HD
if read -r _ _ _ rating _ < <(grep -e Rank "$stock.txt") && [[ $rating ]]; then
mv -- "$stock.txt" ~/Desktop/Stocks/"${rating%%-*}"/
fi
Explanation:
<(...) is replaced with a filename which, when read, returns the output of the command enclosed. Thus, foo < <(...) runs foo in the parent shell with its stdin fed from the command in the .... See BashFAQ #24 to understand why this is necessary rather than running grep -e Rank "$stock.txt" | read _ _ _ rating _.
read _ _ _ rating _ reads the fourth word of its input stream into the variable rating. (First, second, third, and fifth-and-on are read into variables named _, which is convention for something you don't care about / want to throw away).
"${rating%%-*}" throws away all contents in the variable rating following the first -, thus converting 1-Strong to 1, 2-Buy to 2, etc.
However, all the above doesn't explain the exact error you're receiving. To get that, let's break down your awk commands:
system("mv " "'$stock'.txt" " " ~/Desktop/Stocks/1/"'$stock'.txt") ;
...so, what are the strings concatenated together and passed to system() (and thus /bin/sh)?
system(
"mv "
"'$stock'.txt"
" "
~/Desktop/Stocks/1/"'$stock'.txt"
) ;
See the problem here? That fourth piece (which you intend to have concatenated together with the rest) isn't a string in awk! Thus, when it contains / operations, those are treated as numeric division -- casting the content before it to a numeric value, and dividing by the content after it (likewise cast to integer). On some awk releases, including mine, this results in a divide-by-zero error; yours apparently differs.
(Also, $stock is a literal string, not substituted with HD here, but that's a separate issue)

Answer 2

You are currently creating this execution tree:
shell { awk { system( shell ) } }
Don't do that, it's extremely messy and error prone. Do this instead (or something equally simple):
shell { awk }
e.g. this MAY be all you need (depending on the contents of HD.txt):
mv "${stock}.txt" ~/Desktop/Stocks/"$(awk '/Rank/{ sub(/-.*/,"",$4); print $4 }' "${stock}.txt")"

Answer 3

You are making things too complicated by 1) sticking just with awk and 2) repeating the file name in the destination path of those mv comands.
I will assume the "Rank" line has columns separated by spaces and that the 4th one is the one containing your id, as you yourself are assuming. If either this or the following assumption do not hold, the solution here may give you problems. See Charle's answer.
If you are sure the 4th field always contains a string with the pattern digits-text then you can try with
#!/bin/bash
stock=HD
id=`cat "$stock.txt"|grep Rank| cut -d ' ' -f 4| sed 's#-.*##g'`
echo "$stock.txt" ~/Desktop/Stocks/"$id"
#mv "$stock.txt" ~/Desktop/Stocks/"$id"
I have commented out the actual mv command. The echo line will allow you to double check that the file would indeed go to the right destination. Make a few tests and if things look ok, uncomment the mv line by removing the sign #.
EDIT: Do make sure that all the directories ~/Desktop/Stocks/$id exist before issuing the mv commands. Otherwise you'll lose those files!, as they would overwrite each other and only the content of the last file moved to any given ~/Desktop/Stocks/$id directory would survive -but named $id!!
The following code will make sure that they are moved into a directory and are not overwritten onto each other.
#!/bin/bash
stock=HD
DDIR=~/Desktop/Stocks
id=`cat "$stock.txt"|grep Rank| cut -d ' ' -f 4| sed 's#-.*##g'`
echo "$stock.txt" ~/Desktop/Stocks/"$id"
{ [ -d "$DDIR/$id" ] || mkdir "$DDIR/$id" ;} && mv "$stock.txt" ~/Desktop/Stocks/"$id"
This checks first for folder $DDIR/$id to exist and makes it if it doesn't. Only then proceeds with the actual move.