getops if than else - bash

Question

I have working getops function
m) MONTH=$OPTARG
for file in *eqllogmgr* ;
do ftx $file |
layoutcc ;
cat $file | grep '\-'$MONTH |
perl -ne 'print if /-2018/' |
perl -pe 's/......-2018/\e[1;32m$&\e[0m/g' |
sed '$d' ;
echo ;
ft1 ;
done ;;
I am trying to alter the grep to evaluate the $MONTH and use the grep i need depending on what the user inputs for the MONTH.
I tried this
t) MONTH=$OPTARG
if [[ $MONTH =~ ^[0-9]+$ ]]; then
for file in *eqllogmgr* ;
do ftx $file |
layoutcc ;
cat $file | grep $MONTH |
perl -ne 'print if /-2018/' |
perl -pe 's/......-2018/\e[1;32m$&\e[0m/g' |
sed '$d' ;
echo ;
ft1 ;
fi ;
done ;;
else
for file in *eqllogmgr* ;
do ftx $file |
layoutcc ;
cat $file | grep '\-'$MONTH |
perl -ne 'print if /-2018/' |
perl -pe 's/......-2018/\e[1;32m$&\e[0m/g' |
sed '$d' ;
echo ;
ft1 ;
fi ;
done ;;
But i get errors for the fi
i have tried moving that fi around and i cant seem to figure out what i am missing.
Basicly i want to look for a number in the variable and if it has one
run the grep on the base variable $MONTH
If it has no number i want to grep the variable with a dash in front of it
'-'$MONTH
I tired this as well and i get the same
syntax error near unexpected token `else'
so i am pretty sure its just the way i am using the if else statement
u) MONTH=$OPTARG
for file in *eqllogmgr* ;
do ftx $file |
layoutcc ;
cat $file |
if [[ $MONTH =~ ^[0-9]+$ ]]; then
grep $MONTH |
else
grep '\-'$MONTH |
fi
perl -ne 'print if /-2018/' |
perl -pe 's/......-2018/\e[1;32m$&\e[0m/g' |
sed '$d' ;
echo ;
ft1 ;
done ;;
Adding my final working version for reference ===========================
m) MONTH=$OPTARG
if [[ "$MONTH" = [0-9]* ]]; then
grep_expr=$MONTH
else
grep_expr='\-'$MONTH
fi
for file in *eqllogmgr* ; do
ftx "$file" | layoutcc
grep "$grep_expr" "$file" | perl -ne 'print if /-2018/' | perl -pe 's/......-2018/\e[1;32m$&\e[0m/g' | sed '$d'
echo
ft1
done
;;

Answer 1

What (I think) you're trying to do:
case-value)
if ... ; then
for ...; do
done
else
for ...; do
done
fi
;;
What you have shown in your question:
case-value)
if ...; then
for ...; do
fi
done
;;
else
for ...; do
fi
done
;;
The first fi and the first ;; are both extraneous. The second fi is misplaced inside the second for loop.
In the edit you made to your question, you seem to have changed tack and are now trying to accomplish your goal with a single for loop containing an if/else, as opposed to an if/else with a for loop in each clause. That's definitely more efficient, but you can't use an if/else the way you're trying to. At least, not without a lot of unnecessary messiness (actually you can, but you have to get rid of a couple extra |s -- see below). Since your grep expression only varies by a couple characters, you can just store the expression in a variable, and use your if/else to set the expression:
u) MONTH=$OPTARG
if [[ "$MONTH" =~ ^[0-9]+$ ]]; then
grep_expr='\-'$MONTH
else
grep_expr=$MONTH
fi
for file in *eqllogmgr* ; do
ftx "$file" | layoutcc
grep "$grep_expr" "$file" |
perl -ne 'print if /-2018/' |
perl -pe 's/......-2018/\e[1;32m$&\e[0m/g' |
sed '$d'
echo
ft1
done
;;
Note: I also added some quoting, removed the unnecessary colons, and got rid of the unnecessary cat command (just pass the filename directly to grep - no need for an extra pipe).
* Turns out what you were trying would actually work, although I personally don't think it's very concise. Example:
$ show=men
$ echo -e "Alice\nBob\nCarol\nDavid" | if [[ "$show" = "men" ]]; then egrep 'Bob|David'; else egrep 'Alice|Carol'; fi
Bob
David
$ show=women
$ echo -e "Alice\nBob\nCarol\nDavid" | if [[ "$show" = "men" ]]; then egrep 'Bob|David'; else egrep 'Alice|Carol'; fi
Alice
Carol