I'm having some trouble on my code if yourcurrency is larger than convert the convert will choose the 2 instead of 1
can't figure it out what's wrong with my code i've tried on different compiler I think the issue is the code itself can you help me guys?
#include <iostream>
#include <string>
using namespace std;
int picked[5] = {0,0,0,0,0};
int main(){
string currentvalue[5][5] = {{"1","0.01818484","0.015423716","2.4462308","0.019060361"},{"55.012111","1","0.84815483","134.47933","1.0482778"},{"64.90818","1.1789799","1","158.58285","1.2359668"},{"0.40901121","0.0074303636","0.0063022858","1","0.0077907482"},{"52.511804","0.95391572","0.80907737","128.35738","1"}};
string currency[5] = {"Philippine Peso","euro","pounds","yen","usd"};
int yourcurrency;
int convert;
int timesToRun = 5;
int number = 1;
system("COLOR 0a");
cout << "Choose your currency \n" << endl;
for (int counter = 0 ; counter < timesToRun; counter++)
{
cout << number;
cout << "." + currency[counter] << endl;
number++;
}
cout << "\nOption: ";
cin >> yourcurrency;
system("CLS");
yourcurrency = yourcurrency - 1;
picked[yourcurrency] = 1;
cout << "Select your currency you want to convert into \n" << endl;
number = 1;
for (int counter = 0; counter < timesToRun; counter++)
{
if (picked[counter] != 1){
cout << number;
cout << "." + currency[counter] << endl;
number++;
}
}
cout << "\nOption: ";
cin >> convert;
system("CLS");
cout << currency[yourcurrency]+ " - " + currency[convert];
cout << " [" + currentvalue[yourcurrency][convert] + "] " << endl;
cout << "Amount: ";
int cash;
cin >> cash;
double value = stof(currentvalue[yourcurrency][convert]);
double total = cash * value;
cout << currency[convert]<< ": " << total;
}
Related
I usually return an object of std::vector or std::map as an incoming reference paremeter(as funcVec2 and funcMap2 below). But it is a bit inconvenient when writing codes. So I think if I can use return value under c++11(as funcVec1 and funcMap1 below) because it will call move constructor but not copy constructor, so it maybe still spend only one construct time and no deconstruct as the form of incoming reference paremeter.
But I write the codes below to verify it and it turns out that funcVec1 and funcMap1 takes more times then funcVec2 and funcMap2. So I am confused now why funcVec1 and funcMap1 takes so long?
#include <iostream>
#include <vector>
#include <map>
#include <chrono>
using namespace std;
vector<int> funcVec1() {
vector<int >vec;
for (int i = 0; i < 10; ++i) {
vec.push_back(i);
}
return vec;
}
void funcVec2(vector<int>&vec) {
for (int i = 0; i < 10; ++i) {
vec.push_back(i);
}
return;
}
map<int, int> funcMap1() {
map<int, int>tmpMap;
for (int i = 0; i < 10; ++i) {
tmpMap[i] = i;
}
return tmpMap;
}
void funcMap2(map<int, int>&tmpMap) {
for (int i = 0; i < 10; ++i) {
tmpMap[i] = i;
}
}
int main()
{
using namespace std::chrono;
system_clock::time_point t1 = system_clock::now();
for (int i = 0; i < 100000; ++i) {
vector<int> vec1 = funcVec1();
}
auto t2 = std::chrono::system_clock::now();
cout << "return vec takes " << (t2 - t1).count() << " tick count" << endl;
cout << duration_cast<milliseconds>(t2 - t1).count() << " milliseconds" << endl;
cout << " --------------------------------" << endl;
vector<int> vec2;
for (int i = 0; i < 100000; ++i) {
funcVec2(vec2);
}
auto t3 = system_clock::now();
cout << "reference vec takes " << (t3 - t2).count() << " tick count" << endl;
cout << duration_cast<milliseconds>(t3 - t2).count() << " milliseconds" << endl;
cout << " --------------------------------" << endl;
for (int i = 0; i < 100000; ++i) {
map<int, int> tmpMap1 = funcMap1();
}
auto t4 = system_clock::now();
cout << "return map takes " << (t4 - t3).count() << " tick count" << endl;
cout << duration_cast<milliseconds>(t4 - t3).count() << " milliseconds" << endl;
cout << " --------------------------------" << endl;
map<int, int>tmpMap2;
for (int i = 0; i < 100000; ++i) {
funcMap2(tmpMap2);
}
auto t5 = system_clock::now();
cout << "reference map takes " << (t5 - t4).count() << " tick count" << endl;
cout << duration_cast<milliseconds>(t5 - t4).count() << " milliseconds" << endl;
cout << " --------------------------------" << endl;
return 0;
}
you are not only meassuring the time for your operations, you also include the printouts. this is suboptimal.
you should measure performance in release mode. be aware that you are not doing anything usefull with your objects and the optimizer may throw away most of your code you wanted to measure.
the comparisons are not "fair". for example in your map1 case you are constructing an empty map, fill it (memory allocations happen here) and then you throw it away. in the map2 case you are reusing the identical map object over and over again. you are not allocating memory over and over again.
My program can't read all of the data from my MarvelIn.txt file.
It reads about 29 spaces in, and MarvelIn.txt contains only 9 entries, then I get a runtime error.
I think I have all the syntax right, however this is the only error I have. It will not output to the output file "MarvelOut.txt".
Here is the code:
#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>
#include <stdio.h>
using namespace std;
struct sstruct
{
string first, last;
string department;
int salary;
};
void init2(sstruct s[50])
{
int maxarray = 50;
sstruct init = { "Darth", "Vader", "None", 0 };
for (int i = 0; i < maxarray; i++) {
s[i] = init;
cout << "init: " <<s[i].first<<endl;
}
}
void read(sstruct s[50], int &nums)
{
int maxarray = 50;
ifstream inf("MarvelIn.txt");
int i = 0;
while (!inf.eof())
{
inf >> s[i].first >> s[i].last >> s[i].department >> s[i].salary;
cout << "read: "<<s[i].first<<s[i].last << s[i].department <<
s[i].salary << endl;
i++;
}
nums = i;
}
void avg(sstruct s[50], int &nums, double &average2)
{
int maxarray = 50;
int i;
for (i = 0; i < nums; i++)
average2 += s[i].salary;
average2 /= nums;
}
void print(sstruct s[50], int nums, double &average2)
{
int maxarray = 50;
ofstream outf("MarvelOut.txt");
int i = 0;
string temp;
outf << "the number of professors is: " << nums << endl;
cout << "the number of professors is: " << nums << endl;
outf << endl << "The average salary of the professors is: " << average2 << endl;
outf << "Advisor " << "Major " << " Department " << "Salary " << endl;
for (i = 0; i < nums; i++)
{
temp= s[i].last + "," + s[i].first;
cout << "last, first " << temp << endl;
outf << left << setw(20) << temp << right << setw(5)<< s[i].department << setw(5) << s[i].salary << setw(8) << endl;
}
outf << endl << endl;
}
void swap(sstruct &a, sstruct &b)
{
sstruct temp;
temp=a;
a=b;
b=temp;
}
void bubbleSort(sstruct s[50], int &nums)
{
int maxarray = 50;
int i, j;
bool swapped;
for (i = 0; i < nums - 1; i++)
{
swapped = false;
for (j = 0; j < nums - i - 1; j++)
{
if (s[j].department > s[j + 1].department)
{
swap(s[j], s[j+1]);
swapped = true;
}
}
// IF no two elements were swapped by inner loop, then break
if (swapped == false)
break;
}
}
int main() {
int nums=0;
double average3=0.0;
const int maxarray = 50;
sstruct s[maxarray];
init2(s);
print(s, nums, average3);
read(s, nums);
cout << "numsfirst: " << nums << endl;
avg(s, nums, average3);
cout << "nums" << nums << endl;
bubbleSort(s,nums);
print(s, nums, average3);
system("pause");
return 0;
}
#include <iostream>
int main()
{
using namespace std;
int P, C, M, marks;
cout << "Grading System\n\n";
cout << "Enter Marks in Phy\n";
cin >> P;
cout << "Enter Marks in Chem\n";
cin >> C;
cout << "Enter Marks in Maths\n";
cin >> M;
cout << "Grades\n\nPhysics Chemistry Maths\n";
if (marks < 50)
cout << "Fail";
else if (marks <= 60)
cout << "C";
else if (marks <= 70)
cout << "B";
else if (marks <= 80)
cout << "B+";
else if (marks <= 90)
cout << "A";
else if (marks <= 95)
cout << "A+";
else
cout << "Error";
return 0;
}
Is there any way to run above if statement for multiple values of marks like
marks = P
then test for marks = C, marks = M and give output respectively,
You could make your program more modular by implementing the test marks logic in a separate function and name it something like checkGrade and pass as an argument the values you took as input.
For example:
#include <iostream>
using namespace std; //I moved this command outside the main function so it applies globally
void checkGrade(int);
int main()
{
int P, C, M;
cout << "Grading System\n\n";
cout << "Enter Marks in Phy\n";
cin >> P;
cout << "Enter Marks in Chem\n";
cin >> C;
cout << "Enter Marks in Maths\n";
cin >> M;
cout << "Grades\n\nPhysics Chemistry Maths\n";
checkGrade(P);
checkGrade(C);
checkGrade(M);
return 0;
}
void checkGrade(int marks){
if (marks < 50)
cout << "Fail";
else if (marks <= 60)
cout << "C";
else if (marks <= 70)
cout << "B";
else if (marks <= 80)
cout << "B+";
else if (marks <= 90)
cout << "A";
else if (marks <= 95)
cout << "A+";
else{cout << "Error";}
}
Or you could use an array like MadaZZ suggested to eliminate the need to call checkGrade() separately for every user input.
Make an array of marks and a function to check respective grades.
#include <iostream>
using namespace std;
void checkGrade(int marks) //function to check grade
{
if (marks < 50)
cout << "Fail";
else if (marks <= 60)
cout << "C";
else if (marks <= 70)
cout << "B";
else if (marks <= 80){
cout << "B+";
}
else if (marks <= 90){
cout << "A";
}
else if (marks <= 95){
cout << "A+";
}
else{
cout << "Error";
}
}
int main()
{
cout << "Enter no. of students\n\n";
int students;
cin >> students;// Take input of no. of students
int P[students], C[students], M[students]; //Declare array of marks, with each index depicting each student. Size of the array would be the number of students you entered
for( int i = 0; i < students; i++ )
{
cout << "Grading System\n\n";
cout << "Enter Marks in Phy\n";
cin >> P[i];
cout << "Enter Marks in Chem\n";
cin >> C[i];
cout << "Enter Marks in Maths\n";
cin >> M[i];
cout << "Grades\n\nPhysics Chemistry Maths\n";
int count = 3;
while(count) //To check grades in different subjects, the loop runs 'count' number of times ie. for each subject.
{
if(count == 3){
cout<<"\n Grade in Physics ";
checkGrade(P[i]); //Function called to check grade
}
else if(count == 2){
cout<<"\n Grade in Chemistry ";
checkGrade(C[i]); //Function called to check grade
}
else if(count == 1){
cout<<"\n Grade in Maths ";
checkGrade(M[i]); //Function called to check grade
}
count--;
}
}
return 0;
}
The above program stores data for all the students in respective marks array. The checkGrade function takes marks as input and displays the grade one by one. I would suggest you google to learn the concepts and solve some problems.
while (1)
{
cout << "Enter number and unit: ";
cin >> number;
cin >> unit;
if (unit == "in")
{
result = 2.54f * number;
cout << number << " Inches are " << result << " centimeters!" << endl;
}
else if (unit == "ft")
{
result = 0.3f * number;
cout << number << " Feet are " << result << " meters!" << endl;
}
else if (unit == "yd")
{
result = 0.9f * number;
cout << number << " Yards are " << result << " meters!" << endl;
}
else if (unit == "mi")
{
result = 1.6f * number;
cout << number << " Miles are " << result << " kilometers!" << endl;
}
else
{
cout << "\tINVALID!!!\n...the program will now exit...\n";
cin.clear();
cin >> unit;
cin >> number;
break;
}
}
cout << "Thank you for using English to Metric!\n" << endl;
return 0;}
What am I missing in order to get the last cout and exit the program without having to input anything after break?
The break in the else clause will exit the loop, but immediately before it you perform
cin.clear();
cin >> unit;
cin >> number;
break;
The cin >>s are why the program is waiting for additional input.
Without them, the cin.clear() is unnecessary, unless you plan to do additional cin operations later.
else
{
std::cin.clear(); // optional
break;
}
} // end while
std::cout << "Thank you\n";
Will work.
Main Program
#include <iostream>
#include <iomanip>
#include "pizza.h"
using namespace std;
int main() {
menuItem item;
menu:
item.getMenu();//Menu Prompt
cout << "\nI would like number: " << flush;
int menuChoice;
cin >> menuChoice;
while (menuChoice < 1 || menuChoice > 3) {
cout << "\nINVAILD INPUT:\nEnter a Value that corresponds with your menu choice" << endl;
}
if (menuChoice == 1) {
item.getPizza();
}
if (menuChoice == 2) {
item.getSandwhich();
}
if (menuChoice == 3) {
item.getSide();
}
int ready4checkout;
cout << "\n\n~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~" << endl;
cout << "\nAre you ready to checkout?\n" << endl;
cout << "checkout = 1\nAdd to the order = 2" << endl;
cout << "\nI would like to:" << flush;
cin >> ready4checkout;
if (ready4checkout == 1) {
item.addcheckout();
}
if (ready4checkout == 2) {
goto menu;
}
cin.ignore();
cin.get();
}
Header File
#include<iostream>
#include <iomanip>
using namespace std;
class menuItem {
protected:
float smallPizza = 5.99;
float mediumPizza = 6.99;
float largePizza = 9.99;
float halfSandwhich = 6.00;
float wholeSandwhich = 8.00;
float bonelessWings = .70;
float breadStix = 4.99;
public:
float checkout;
float pizzaCheck;
float sandCheck;
float sideCheck;
menuItem item(float smallPizza, float mediumPizza, float largePizza, float halfSandwhich, float wholeSandwhich, float bonelessWings, float breadStix,float checkout);
string getMenu() {
string menu;
cout << "~*~*~*~*~*~*~*~ Welcome to Pizza Italiano! ~*~*~*~*~*~*~*~*~\n\n" << endl;
cout << "~~~~~~~~~~~~~~~~~ Main Menu ~~~~~~~~~~~~~~~~~~" << endl;
cout << "Enter the value of the food that you wish to devour:\n" << endl;
cout << "\n1.Pizza\n2.Sandwhich\n3.Appetizer" << endl;
return menu;
}
string getPizza() {
float pizzaCheck;
string pizza;
float pizzaSize;
pizza:
cout << " \n~~~~~~ How would you like your pizza made? ~~~~~~\n" << endl;
cout << " Size" << endl;
cout << "-----------" << endl;
cout << "1. Large $9.99 \n2. Medium $6.99 \n3. Small $5.99" << endl;
cout << "\nI would like the number: " << flush;
cin >> pizzaSize;
cin.ignore();
while (pizzaSize < 1 || pizzaSize > 3) {
cout << "\nINVAILD INPUT:\nEnter a Value that corresponds with your menu choice" << endl;
goto pizza;
}
if(pizzaSize == 1) {
cout << "\n****You have selected a Large pizza****" << endl;
pizzaCheck = pizzaSize;
pizzaCheck = largePizza + pizzaCheck;
} else if(pizzaSize == 2) {
cout << "\n****You have selected a Medium Pizza****" << endl;
pizzaCheck = pizzaSize;
pizzaCheck = mediumPizza + pizzaCheck;
} else {
cout << "\n****You have selected a Personal pizza****" << endl;
pizzaCheck = pizzaSize;
pizzaCheck = smallPizza + pizzaCheck;
}
cin.get();
return pizza;
}
string getSandwhich() {
string sandwhich;
float sandSize;
Sandwhich:
cout << "~~~~~~~~~~~~ What size would you like your sandwhich to be? ~~~~~~~~~~~~~~~\n\n" << endl;
cout << "1. Six inch $6.00\n2. Twelve inch $8.00" << endl;
cout << "I would like number:" << flush;
cin >> sandSize;
while (sandSize < 1 || sandSize > 2) {
cout << "\nINVAILD INPUT:\nEnter a Value that corresponds with your menu choice" << endl;
goto Sandwhich;
}
if (sandSize == 1) {
cout << "**** You have selected a six inch sub ****" << endl;
sandCheck = halfSandwhich + sandSize;
} else {
cout << "**** You have selected a 12 inch sub ****" << endl;
sandCheck = wholeSandwhich + sandSize;
}
return sandwhich;
}
string getSide() {
string Appetizer;
float side;
sides:
cout << "~~~~~~~~~~~~~~~ Which appetizer would you like? ~~~~~~~~~~~~~~~~~\n\n" << endl;
cout << "1. Boneless Wings .70\n2. BreadStix $4.99\n\n" << endl;
cout << "I would like the number:" << flush;
cin >> side;
while (side < 1 || side > 2) {
cout << "\nINVAILD INPUT:\nEnter a Value that corresponds with your menu choice" << endl;
goto sides;
}
if (side == 1) {
cout << "\n**** You have selected Boneless wings ****\n" << endl;
cout << "How many wings would you like?\n" << endl;
cout << "I would like this many wings:" << flush;
int wings;
cin >> wings;
cout << "\n**** You will recieve " << wings << " wings. ****" << endl;
side = sideCheck;
sideCheck = bonelessWings += sideCheck;
} else {
cout << "\n**** You have selected an order of breadstix ****" << endl;
side = sideCheck;
sideCheck = breadStix += sideCheck;
}
return Appetizer;
}
float addcheckout() {
checkout = pizzaCheck;
cout << "\nYour total is " << checkout << endl;
cout << "\nThank You for your purchase!";
return checkout;
}
};
At the end of the program, when it gives the checkout total, it gives a value something like -1.07374e.+008
I am still learning how to code, and I am stumped on this one. Any help would be much appreciated!
I think you shadow your member field pizzaCheck in your method getPizza, so that you actually don‘t write to the member field but to your local var declared at the first line of that method.
Try removing that local var. (I did not test it yet though)