I have a bash script:
PS3='Please enter your choice: '
options=("1" "2" "3" "4" "Quit")
select opt in "${options[#]}"
do
case $opt in
"1")
echo "Set configuration"
break
;;
"2")
echo "Setting configuration and execution Install"
break
;;
"3")
echo "Setting configuration and execution Unlink"
break
;;
"4")
echo "Running tests"
break
;;
"Quit")
break
;;
*) echo "Selected option '$REPLY' couldn't be find in the list of options";;
esac
done
I have 2 questions:
How can I run this script with predefined option? (For example, I want to execute this script with already selected 1st option)
Is it possible to reuse one option in another option? (For example my 1st option just setting config and my 2nd option also setting the same config and after that execute install, can they be written like if option 2 selected execute 1st option and then 2nd?)
And if something written too badly, I'm open to suggestions =)
How can I run this script with predefined option? (For example, I want
to execute this script with already selected 1st option)
It's a bit ugly with select, move all case logic out from do ... done cycle, make your script take args and rearrange it like this:
#!/bin/bash
PS3='Please enter your choice: '
options=("1" "2" "3" "4" "Quit")
[[ $1 ]] && opt=$1 || select opt in "${options[#]}"; do break; done
case $opt in
"1") echo "Set configuration";;
"2") echo "Setting configuration and execution Install";;
"3") echo "Setting configuration and execution Unlink";;
"4") echo "Running tests";;
"Quit") :;;
*) echo "Selected option '$REPLY' couldn't be find in the list of options";;
esac
Is it possible to reuse one option in another option? (For example my
1st option just setting config and my 2nd option also setting the same
config and after that execute install, can they be written like if
option 2 selected execute 1st option and then 2nd?)
Turn the code in options into functions, this way you could easily reuse it
fun1(){ echo "Set configuration"; }
fun2(){ echo "Execution Install"; }
...
case $opt in
"1") fun1;;
"2") fun1; fun2;;
...
Also there are these operators for case: ;& and ;;&
man bash
...
Using ;& in place of ;; causes execution to continue with the list associated with the next set of patterns.
Using ;;& in place of ;; causes the shell
to test the next pattern list in the statement, if any, and execute any associated list on a successful match.
So if you want to make option 1 also run if option 2 selected this can be done like so:
case $opt in
"2") fun1;&
"1") fun1;;
...
But personally I found this method a bit tricky and hard to read.
If you put the select part in a function
main(){
select opt in "${options[#]}"
do
case $opt in
"1")
set_config # <--- an other funtion for option 1 to reuse it
break
;;
.
.
.
}
# set a default option
def_opt=1
# or use command line argument
def_opt="$1"
you can call main with predefined option '$def_opt' with yes
yes "$def_opt" | main
After digging into this and trying to do my best, I still need a little help to finish my script.
Running script without any parameters are now working perfect.
Passing options in that way (getopts :c:i:u:d:s:h:) leads me to an error message after executing command sh ./script.sh -c => Wrong argument 'c' provided, run sh ./scripts/collection.sh -h for help
Passing options in that way (getopts "ciudsh") => working perfect, but still if I use argument that wasn't passed (ex. x) it would lead to error: Wrong argument '' provided, run sh ./scripts/collection.sh -h for help or sometimes even to this Syntax error: "(" unexpected (expecting "fi")
Please see my full script below, unfortunately for security reasons I can't post the content of the functions itself.
I would appreciate any help on fixing style, errors or anything else.
Based on your advice and other answers on stackoverflow I came up to this:
#!/usr/bin/env bash
#Colors
BRed='\033[1;31m'
Green='\033[0;32m'
BCyan='\033[1;36m'
NC='\033[0m'
f1(){
...
}
f2(){
...
}
f3(){
...
}
f4(){
...
}
f5(){
...
}
Help(){
echo -e "${Green}====================================================================================================================${NC}"
echo "You may execute the commands by selecting a number from menu or pass it as argument, see examples below:"
echo ""
echo -e "${Green}sh $0 ${BCyan}-argument${NC} :To execute specific command"
echo -e "${Green}sh $0 ${NC} :To see menu with all available options"
echo ""
echo -e "${BCyan} -c ${NC}..."
echo -e "${BCyan} -i ${NC}..."
echo -e "${BCyan} -u ${NC}..."
echo -e "${BCyan} -d ${NC}..."
echo -e "${BCyan} -s ${NC}..."
echo -e "${BCyan} -h ${NC}..."
echo -e "${Green}====================================================================================================================${NC}"
exit 1;
}
if [ $# -eq 0 ]
then
PS3='Please enter your choice: '
options=("1" "2" "3" "4" "5" "Help" "Quit")
select opt in "${options[#]}"
do
case $opt in
"1")
f1;;
"2")
f1; f2;;
"3")
f1; f2;;
"4")
f3;;
"5")
f4;;
"Help")
Help;;
"Quit")
break;;
*) echo -e "${BRed}Selected option ${BCyan}'$REPLY'${NC} ${BRed}couldn't be find in the list of provided options${NC}"
break;;
esac
done
fi
while getopts :c:i:u:d:s:h: OPTION
do
case $OPTION in
c)
f1;;
i)
f1; f2;;
u)
f1; f3;;
d)
f4;;
s)
f5;;
h)
Help;;
*) echo -e "${BRed}Wrong argument ${BCyan}'$OPTARG'${NC} ${BRed}provided, run${NC} ${BCyan}sh $0 -h${NC} ${BRed}for help${NC}"
esac
done
Related
How to improve the following batch script by making so whenever a new script is added into the directory, it doesn't require to manually hardcode an extra line of code in script.
like: 3) source $(pwd)/script-3.sh; myfunc;;
script:
#Menu script
title="Menu"
prompt="Pick an option(number): "
#options=(
# "script-1.sh" \
# "script-2.sh" \
# "script-3.sh" \
# )
path=$(pwd)
array=($path/*.sh)
options=( "${array[#]##*/}" )
echo "$title"
PS3="$prompt"
select opt in "${options[#]}" "Quit"; do
case "$REPLY" in
1) source $(pwd)/script-1.sh; myfunc;;
2) source $(pwd)/script-2.sh; myfunc;;
3) source $(pwd)/script-3.sh; myfunc;;
$((${#options[#]}+1))) echo "Goodbye!"; break;;
*) echo "Invalid option. Try another one.";continue;;
esac
done
How to automate this part ?
select opt in "${options[#]}" "Quit"; do
case "$REPLY" in
1) source $(pwd)/script-1.sh; myfunc;;
2) source $(pwd)/script-2.sh; myfunc;;
3) source $(pwd)/script-3.sh; myfunc;;
$((${#options[#]}+1))) echo "Goodbye!"; break;;
*) echo "Invalid option. Try another one.";continue;;
esac
done
this is the current manual part, where need to be hard-coded a value everytime a new script is added.
for example, lets say I added a new script called" script-99.sh
then it would need to hardcode it in the main script like this:
case "$REPLY" in
1) source $(pwd)/script-1.sh; myfunc;;
2) source $(pwd)/script-2.sh; myfunc;;
3) source $(pwd)/script-3.sh; myfunc;;
4) source $(pwd)/script-99.sh; myfunc;; ##Had to hardcode this line
A simple solution would be
select opt in "${options[#]}" "Quit"; do
script=script-$REPLY.sh
if [[ -f $script ]]
then
source $script
else
echo Goodbye
break
fi
done
This also catches the case that someone deletes a script while the select-loop is still in process.
A more stable solution would be
quitstring=Quit
select opt in "${options[#]}" $quitstring; do
[[ $opt == $quitstring ]] && break
source $opt
done
After lots attempts, come up with this:
select opt in "${options[#]}" "Quit"; do
source $(pwd)/$opt; myfunc
done
it is working!
however to exit the script it need to press Ctrl+z
this part of the code bellow which used to exit the script, I wasn't able to figure out how to adapt into the solution above.
$((${#options[#]}+1))) echo "Goodbye!"; break;;
*) echo "Invalid option. Try another one.";continue;;
so this is not a complete answer.
I have the following code where the user picks a file type, then I run certain code for each case:
#!/bin/bash
PS3='Please enter your file type choice: '
options=(".c (C)" \
".cpp (C++)" \
".css (CSS)" \
".html (HTML)" \
".java (Java)" \
".ms (Groff)")
select option in "${options[#]}" # Asks for the option choice
do
case "${option}" in
".c (C)") # C programming file
echo "C OPTION SELECTED"
;;
".cpp (C++)") # C++ programming file
echo "C++ OPTION SELECTED"
;;
".css (CSS)") # CSS programming file
echo "CSS OPTION SELECTED"
;;
".html (HTML)") # HTML File
echo "HTML OPTION SELECTED"
;;
".java (Java)") # Java programming file
echo "JAVA OPTION SELECTED"
;;
".ms (Groff)") # Groff markup file
echo "GROFF OPTION SELECTED"
;;
*) echo "invalid option $option"
;;
esac
done
I was wondering how I can make it like this, where in the case statement you can address each case by the index of the array instead of the value of the array:
#!/bin/bash
PS3='Please enter your file type choice: '
options=(".c (C)" \
".cpp (C++)" \
".css (CSS)" \
".html (HTML)" \
".java (Java)" \
".ms (Groff)")
select option in "${options[#]}" # Asks for the option choice
do
case "${option}" in
1) # C programming file
echo "C OPTION SELECTED"
;;
2) # C++ programming file
echo "C++ OPTION SELECTED"
;;
3) # CSS programming file
echo "CSS OPTION SELECTED"
;;
4) # HTML File
echo "HTML OPTION SELECTED"
;;
5) # Java programming file
echo "JAVA OPTION SELECTED"
;;
6) # Groff markup file
echo "GROFF OPTION SELECTED"
;;
*) echo "invalid option $option"
;;
esac
done
I did a lot of research and I'm not the best at bash (but I'm learning). Sorry if the solution is obvious but I would appreciate your help, that you.
On bash 4.0 or newer, you can build a reverse index as an associative array:
declare -A options_reverse=()
for idx in "${!options[#]}"; do
val=${options[$idx]}
options_reverse[$val]=$idx
done
...after doing which, ${options_reverse[$option]} will map to the desired index.
Combined with the rest of your program, this would look like:
#!/bin/bash
case $BASH_VERSION in ''|[0-3].*) echo "ERROR: Bash 4.0+ required" >&2; exit 1;; esac
PS3='Please enter your file type choice: '
options=(
".c (C)"
".cpp (C++)"
".css (CSS)"
".html (HTML)"
".java (Java)"
".ms (Groff)"
)
declare -A options_reverse=()
for idx in "${!options[#]}"; do
val=${options[$idx]}
options_reverse[$val]=$idx
done
select option in "${options[#]}"; do
case "${options_reverse[$option]}" in
0) echo "C OPTION SELECTED";;
1) echo "C++ OPTION SELECTED";;
2) echo "CSS OPTION SELECTED";;
3) echo "HTML OPTION SELECTED";;
4) echo "JAVA OPTION SELECTED";;
5) echo "GROFF OPTION SELECTED";;
*) echo "invalid option $option";;
esac
done
From help option:
The line read is saved in the variable REPLY.
I've got a simple Bash Menu here. Everything seems to work great, except I can't figure out how to get back to the Main Menu from my SubMenu. Upon executing the script, I select "3" to go into the "SubMenu" from there, I press "3" again to go back to the "Main Menu" but instead it just keeps showing me the "SubMenu" options.
I tried replacing "break" with "./menu.sh" which is the name of my script, which does seem to work, however, I'm certain that's probably not the most ideal way to handle this issue.
#!/bin/bash
clear
while true
do
clear
echo "######"
echo " Menu"
echo "######"
echo ""
PS3='Select an option: '
options=("Option1" "Option2" "SubMenu" "Exit")
select opt in "${options[#]}"
do
case $opt in
"Option1")
echo Option1
read -p ""
break
;;
"Option2")
echo Option2
read -p ""
break
;;
"SubMenu")
while true
do
clear
echo "#########"
echo " SubMenu"
echo "#########"
echo ""
PS3='Select an option: '
options=(
"SubMenu Option1"
"SubMenu Option2"
"Main Menu"
)
select opt2 in "${options[#]}"
do
case $opt2 in
"SubMenu Option1")
echo "Sub-Menu Option1"
read -p ""
break
;;
"SubMenu Option2")
echo "Sub-Menu Option2"
read -p ""
break
;;
"Main Menu")
"./menu"
;;
*) echo "invalid option";;
esac
done
done
;;
"Exit")
exit
;;
*) echo "invalid option"
;;
esac
done
done
First of all, break will break out of select. To leave the submenu while loop, you need to break 3 (to leave the inner select, the submenu while, and the outer select).
Type help break for more information.
A short note on your other approach, calling your script again: You should not launch a new child process with each iteration. Bash has an elegant way of "restarting" a program:
exec "$0"
This will execute the given executable (in this case $0 – the current script) in the current process. See the exec() system call for more information or type help exec to read the Bash specifics.
I don't get why this won't work as it's really simple.
#!/bin/bash
type='A'
while getopts "t:" OPTION
do
case $OPTION in
t)
echo "The value of -t is $OPTARG"
type=$OPTARG
exit
;;
\?)
echo "Used for the help menu"
exit
;;
esac
done
echo $type
Output I get:
root#w:/etc/scripts# ./dns_add_record -t test
The value of -t is test
root#w:/etc/scripts# ./dns_add_record
A
Expected output:
root#w:/etc/scripts# ./dns_add_record -t test
The value of -t is test
test
Can someone figure out what is wrong? It's probably something stupid, but I can't get this working the way I want it to.
exit exits from the shell script.
Remove it from the -t case, it only makes sense for help.
Adding set -x to your script gives this trace:
+ type=A
+ getopts t: OPTION
+ case $OPTION in
+ echo 'The value of -t is 3'
The value of -t is 3
+ type=3
+ exit
I'm currently having problems with my script. Basically, what I want to happen is when I execute ./apache_new_vhost.sh -a -d google.com, it will create a file and directories and if I use the -r option, it should delete.
The script was able to use the functions like add_vhost. It could create a configuration and folder however the filename is empty because it could not read the value I passed to $domain.
while getopts ":a:r:d:h" opt; do
case $opt in
a) action=add_vhost
;;
r) action=remove_vhost
;;
d) domain=$OPTARG
;;
h) usage
exit 1
;;
\?) echo "Invalid option: -$OPTARG"
usage
exit 1
;;
:) echo "Error: option -$OPTARG requires an argument."
usage
exit 1
;;
esac
done
#if [ -z $domain ]; then
# usage
# exit 1
if [ $action == "add_vhost" ]; then
echo $action $domain
elif [ $action == "remove_vhost" ]; then
echo $action $domain
fi
The options are processed in the order you specify them on the command line. So in your example, case a) is processed first, and calls your add_vhost function right then.
But the d) case hasn't been processed yet, so you haven't set domain.
You need to change your logic a bit. Rather than calling your functions directly from the case statement, save what action was selected. i.e.:
a) action="add_vhost"
;;
Then after the case, check that you do have an action selected, and call that function.
As per your script you expect argument after option -a. So when you execute your script by
./apache_new_vhost.sh -a -d google.com
then -d will consider as argument given to -a option. So your second argument discarded.To solve it just give any argument after -a (ex: ./apache_new_vhost.sh -a 1 -d google.com )option or make changes in your getopt
while getopts ":ar:d:h" opt; do