I have an odd TFS issue that no one else on my team seems to be experiencing. As far as I know I'm the only one on my team who likes using the Pending Changes windows so I'm assuming the issue is there.
After I have a code review approved I will navigate to the Work Items tab of the pending changes window. I will check the "Check-in Action" box and select "Associate". Immediately the code review goes to a closed state with a note in the history of the review saying I closed the review on behalf of the reviewer. I then cannot check-in my code since the review is now in a closed state. I get Check-In Validation, Unsupported check-in action for work item ####. If I refresh the view, the review I tried to associate with is now gone.
The only way for me to check-in is to re-open the review, assign it to myself, then set it to resolved state. It retains the association from before and now that the review is in the proper state I can finally check my code in. As you can imagine this routine is getting old. Any ideas?
Edit: VS2010 by the way
Think I got it figured out. You can select what query the Pending Change screen uses. My query was looking for code reviews not in closed state. Once the code review is associated it gets closed and drops out of the query results. The pending changes window won’t let you check-in if nothing is checked in the work-items screen even though the code review was associated.
I made a new query for the window to use that looks for code reviews I created that have been resolved in the past 7 days. I wish I could see just my open code reviews, but this seems to be the best solution given the restrictions of the screen.
Related
I cannot seem to unlock the Unpushed Commits indicator to quickly view how many commits I have made. This is however not necessary when you regularly push, though I like to keep some projects locally.
Here is an example:
The same applies for the indicator next to it, which is the change indicator.
I looked in the git settings, though no such option seems to exist.
Currently using Visual Studio 2017RC, any suggestions?
I got the same issue as yours in my VS2017 RC, but if you put the mouse on it, it would share the correct value:
My suggestion is that you'd better edit your project files together, and then commit them with few times. Or just put the mouse on the "99*", and view the real items.
Of course, since it is the RC version, I also help you submitted a feedback to the product team here:
https://developercommunity.visualstudio.com/content/problem/15796/visual-studio-unpushed-git-commits-indicator-limit.html
You could vote and add your comment there:)
I submitted some code for review. I got feedback from the reviewer.
I made the changes to the code.
How can I submit the new changes back to the existing review for reappraisal.
I do not see a button anywhere. All I can do is Complete or abandon.
Do I have to setup a new Code Review?
That's the way we do it. Technically speaking, your changes have failed the code review so your code review is now complete. You should have some feedback which you can use to make some changes to your code and try again.
When you request a review, your changes are bundled in a shelveset and in order to see the differences since the last lot of differences, I imagine would be a difficult task for the code reviewer to handle.
Usually, we request a review from a number of people initially but then we will send the re-review only to the person(s) that rejected it.
I made a mistake while using Team Server Foundation. I had requested a code review and also added myself as a reviewer so I could add comments on each file. Once finished, I closed the review without realizing it would close it for everyone else.
How do I re-open a closed review? All it gives me is grayed out text or no available actions anywhere I try to open it (Source Control Explorer, Team Explorer, and Web).
You can't but you can still view the review.
In visual studio, in the Team Explorer panel click on Pending Changes.
Click on Action and select Find Shelvesets.
Enter your username in the research box.
In the list click on the code review you want to open.
The view as change for the Shelvesets Details.
In the Related Work Items section. Open the work item for the review.
And there it is.
You cannot re-open a code review, you will need to create a new one.
My team uses TFS 2013/Visual Studio 2013 to do code reviews. It all works fine but there is a really annoying thing which VS does that I can't seem to turn off.
If I submit a review and it comes back with suggested changes, I go through and make them, checking each one off as I go. The problem is each time I mark a code review item as done by checking the box to the far right of it in the Team Explorer -> Code Review view, VS opens the diff window for that particular item showing the review comments. I don't want to see any of that, I just want to mark the item as done so I know I've dealt with it.
Is there any way to prevent VS from showing the diff window when you mark a code review item as done?
It seems that TFS doesn't handle concurrent work item editing very well.
We ran into two problematic scenarios:
Scenario A:
You start editing a work item.
While you're editing, someone else edits and saves the same item.
When you try to save you get the horrible TFS237079 error which which means you have to loose your changes, refresh the item and edit again. nice.
Scenario B:
You have a work item focused for a while.
Someone edits and saves the item.
When you start editing you're actually editing an outdated version of the work item and will get TFS23709 when trying to save.
I'm quite familiar with the TFS SDK (wrote some TFS VS Addon and custom work item controls) but can't find something like a "BeforeEdit" event for a work item.
Having such event would allow me to warn the user that someone else is currently editing (for scenario A) and get the latest revision before editing (for Scenario B).
Thanks,
Raviv.
Optimistic concurrency is what it is. The server isnt tracking who is editing work items so If you really wanted to do "Someone else is editing this item" notifications you would probably have to write your own services and custom controls to track it. You'd also have to deal with edit flags not being release if visual studio crashed and with the web UI. If you choose that path I wish you luck!