errors in code noob cant fix them [closed] - codeigniter

Question

This question is unlikely to help any future visitors; it is only relevant to a small geographic area, a specific moment in time, or an extraordinarily narrow situation that is not generally applicable to the worldwide audience of the internet. For help making this question more broadly applicable, visit the help center.
Closed 9 years ago.
I am working on a small application that displays data from a database table. I am getting 2 errors and dont know why are there, and I cant figure it out as I am still a noob. I guess its something stupid, please help.
ERRORS
A PHP Error was encountered
Severity: Notice
Message: Undefined variable: querys
Severity: Warning
Message: Invalid argument supplied for foreach()
these errors are located in my view page.
VIEW
<?php foreach ($queries as $row): ?>
<table>
<th>Name</th>
<th>Surname</th>
<th>phone</th>
<th>email</th>
<td><?php echo $row->name; ?></td>
<td><?php echo $row->surname; ?></td>
<td><?php echo $row->phone; ?></td>
<td><?php echo $row->email; ?></td>
</table>
<?php endforeach; ?>
CONTROLLER
function display($offset = 0)
{
$limit = 20;
$this->load->model('info_model');
$results = $this->info_model->search($limit, $offset);
$data['queries'] = $results['rows'];
$data['num_results'] = $results['num_rows'];
$this->load->view('info_view',$data);
}
MODEL
function search ($limit, $offset){
//results query
$q = $this->db->select('ID, name, surname, phone, email');
$this->db->from('tblinfo');
$this->db->limit($limit, $offset);
$ret['rows'] = $q->get()->result();
//count query
$q = $this->db->select('COUNT(*) as count', FALSE )
->from('tblinfo');
$tmp = $q->get()->result();
$ret['num_rows'] = $tmp[0]->count;
return $ret;
}
EDIT
i fixed the foreach error by inserting
<?php if(is_array($queries)): ?>
<?php endif; ?>
the only error i am getting is the
A PHP Error was encountered
Severity: Notice
Message: Undefined variable: queries

Answer 1

$data['query'] = $results['rows'];
should be
$data['querys'] = $results['rows']; // although correct spelling is "queries"
Then you can access $querys inside your view.

Answer 2

The problem seems to be with your models search() method, which is probably not returning any results. I would re-write it as follows to utilize codeigniters active record class:
function search ($limit, $offset){
//results query
$this->db->select('ID, name, surname, phone, email');
$q = $this->db->get('tblinfo', $limit, $offset);
$ret['rows'] = $q->result();
//count query
$ret['num_rows'] = $this->db->count_all('tblinfo');
return $ret;
}
You can use Codeigniters active record class to get a count of all records in a specific table using just $this->db->count_all('table_name');

Answer 3

Personally I think a function should perform only one task. Right now you are trying to do two tasks (return records and return a record count) in one function.
I would rewrite my model like this:
function search($limit, $offset)
{
$this->db->select('ID, name, surname, phone, email');
$this->db->from('tblinfo');
$this->db->limit($limit, $offset);
return $this->db->get();
}
And your controller could look like this:
function display($offset = 0)
{
$this->load->model('info_model');
$results = $this->info_model->search(20, $offset);
$data['queries'] = $results->result();
$data['num_results'] = $this->db->count_all('tblinfo'); // Alternatively you could make a separate model function that does this
$this->load->view('info_view', $data);
}

Answer 4

Maybe change your search code a little
$q = $this->db->select('ID, name, surname, phone, email')
->from('tblinfo')
->limit($limit, $offset);

Answer 5

Change your model code to this
function search ($limit, $offset){
//results query
$this->db->select('ID, name, surname, phone, email');
$this->db->from('tblinfo');
$this->db->limit($limit, $offset);
$q = $this->db->get();
$ret['rows'] = $q->result();
//count query
$q1 = $this->db->select('COUNT(*) as count', FALSE )
->from('tblinfo');
$tmp = $q1->get()->result();
$ret['num_rows'] = $tmp[0]->count;
return $ret;
}