WindowLeaked Error Android Dialog Builder during .show() method call - builder

Question

this is my first question on Stack Overflow and is has to do with the builder pattern for an Android dialog. I recently started reading through the book Hello Android 3rd Edition to learn how to build a basic Android application. I have basic Java experience (two intro programming courses and one data structures/algorithms class all with homework in Java), but am not familiar with builder patterns or Android in general yet.
I am getting a WindowLeaked error when executing the .show() command for the alert dialog builder in the openNewGameDialog() method shown below. I broke up the method into individual calls on the builder to identify which one was the source of the error:
// Creates a selection for game difficulty
private void openNewGameDialog() {
AlertDialog.Builder builderDifficulty = new AlertDialog.Builder(this);
builderDifficulty.setTitle(R.string.new_game_title);
builderDifficulty.setItems(R.array.difficulty,
new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialogInterface, int i) {
startGame(i);
}
});
builderDifficulty.show(); // Throws an error
}
I researched the problem I am having elsewhere on this site, but for the most part it appears that people are getting problems where they have not correctly dismissed the dialog. I don't think that the same problem is occurring for me, but I am not familiar with dialogs or builders like this, so I could be mistaken. The code is taken directly from an example in the book, so I was expecting it to work properly.
I am emulating a Nexus 5 with Android 4.4.2 to test the program. Here is the error text from LogCat:
06-18 15:37:05.260: E/WindowManager(1089): android.view.WindowLeaked: Activity book.example.sudoku.MainActivity has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{b1dfa088 V.E..... R....... 0,0-1026,684} that was originally added here
06-18 15:37:05.260: E/WindowManager(1089): at android.view.ViewRootImpl.<init>(ViewRootImpl.java:348)
06-18 15:37:05.260: E/WindowManager(1089): at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:248)
06-18 15:37:05.260: E/WindowManager(1089): at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69)
06-18 15:37:05.260: E/WindowManager(1089): at android.app.Dialog.show(Dialog.java:286)
06-18 15:37:05.260: E/WindowManager(1089): at android.app.AlertDialog$Builder.show(AlertDialog.java:951)
06-18 15:37:05.260: E/WindowManager(1089): at book.example.sudoku.MainActivity.openNewGameDialog(MainActivity.java:72)
06-18 15:37:05.260: E/WindowManager(1089): at book.example.sudoku.MainActivity.onClick(MainActivity.java:54)
06-18 15:37:05.260: E/WindowManager(1089): at android.view.View.performClick(View.java:4438)
06-18 15:37:05.260: E/WindowManager(1089): at android.view.View$PerformClick.run(View.java:18422)
06-18 15:37:05.260: E/WindowManager(1089): at android.os.Handler.handleCallback(Handler.java:733)
06-18 15:37:05.260: E/WindowManager(1089): at android.os.Handler.dispatchMessage(Handler.java:95)
06-18 15:37:05.260: E/WindowManager(1089): at android.os.Looper.loop(Looper.java:136)
06-18 15:37:05.260: E/WindowManager(1089): at android.app.ActivityThread.main(ActivityThread.java:5017)
06-18 15:37:05.260: E/WindowManager(1089): at java.lang.reflect.Method.invokeNative(Native Method)
06-18 15:37:05.260: E/WindowManager(1089): at java.lang.reflect.Method.invoke(Method.java:515)
06-18 15:37:05.260: E/WindowManager(1089): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
06-18 15:37:05.260: E/WindowManager(1089): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
06-18 15:37:05.260: E/WindowManager(1089): at dalvik.system.NativeStart.main(Native Method)
Any help would be appreciated!

Answer 1

I don't see dialogInterface.dismiss(); being called anywhere in your code. You'll probably want to add it right above startGame(i);.

Answer 2

Something to do with your startGame(i) method.
The code is running fine without any problem. Attached the complete code with screenshots
MainActivity.java
package com.example.userinput;
import android.app.Activity;
import android.app.AlertDialog;
import android.content.DialogInterface;
import android.os.Bundle;
import android.util.Log;
import android.view.View;
import android.widget.Button;
import android.widget.Toast;
public class MainActivity extends Activity {
Button send;
#Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
send = (Button) findViewById(R.id.send);
send.setOnClickListener(new View.OnClickListener() {
#Override
public void onClick(View v) {
openNewGameDialog();
Log.d("MainActivity", "Inside On Click Button");
}
});
}
// Creates a selection for game difficulty
private void openNewGameDialog() {
AlertDialog.Builder builderDifficulty = new AlertDialog.Builder(this);
builderDifficulty.setTitle(R.string.new_game_title);
builderDifficulty.setItems(R.array.difficult,
new DialogInterface.OnClickListener() {
#Override
public void onClick(DialogInterface dialogInterface, int i) {
//startGame(i);
Log.d("MainActivity", "Item on click");
showToast(i);
}
});
builderDifficulty.show(); // Throws an error
}
public void showToast(int i) {
Log.d("MainActivity", "Inside Toast");
Toast.makeText(getBaseContext(), "Open Dialog " + i,
Toast.LENGTH_LONG).show();
Log.d("MainActivity", "OpenDialog " + i);
}
}
activity_main.xml
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:context="${packageName}.${activityClass}" >
<Button
android:id="#+id/send"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_alignParentLeft="true"
android:layout_marginLeft="40dp"
android:layout_marginTop="30dp"
android:text="OpenNewGameDialog" />
</RelativeLayout>
difficult.xml
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string-array name="difficult">
<item>item1</item>
<item>item2</item>
<item>item3</item>
</string-array>
</resources>
strings.xml
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="app_name">UserInput</string>
<string name="hello_world">TextView tvTi</string>
<string name="new_game_title">New Game Title</string>
</resources>