select() for blocking socket in windows - windows

Question

void CSocket::WaitForConnetion()
{
CSocket* pSocket = NULL;
fd_set readfds;
readfds.fd_count = 1;
readfds.fd_array[0] = m_hSocket;
timeval timeout;
ZeroMemory(&timeout, sizeof(timeout));
timeout.tv_sec = 10;
while(!g_bQuit)
{
int iSelect = select(NULL, &readfds, NULL, NULL, &timeout);
if (iSelect == SOCKET_ERROR)
{
// error
break;
}
else
{
if (iSelect == 0)
{
// timeout
}
else
{
assert(iSelect == 1);
SOCKET new_sock = accept(m_hSocket, NULL, NULL);
if (new_sock != INVALID_SOCKET)
{
pSocket = new CSocketEx(new_sock);
// create a new thread to process the connection request with pSocket
}
}
continue;
}
}
Hi,all
CSocket is a socket wrapper.
Using blocking socket in my programm,calling accept function will be blocked when i want to exit thoroughly, so i have to terminate the thread calling accept.I want to use select function as above.But select often goes with non-blocking socket, are there any problems or concerns using blocking socket under such environment above?
With EJP's help.I modified the code below.Is there any error? And as you said if i use the way by closing socket handle,i must pass the socket handle to the other thread then close it,is it safty to operator one sokcet in different threads?
void CSocket::WaitForConnetion()
{
CSocket* pSocket = NULL;
timeval timeout;
ZeroMemory(&timeout, sizeof(timeout));
timeout.tv_sec = 10;
while(!g_bQuit)
{
fd_set readfds;
readfds.fd_count = 1;
readfds.fd_array[0] = m_hSocket;
int iSelect = select(NULL, &readfds, NULL, NULL, &timeout);
if (iSelect == SOCKET_ERROR)
{
// error
break;
}
else
{
if (iSelect == 0)
{
// timeout
}
else
{
assert(iSelect == 1);
SOCKET new_sock = accept(m_hSocket, NULL, NULL);
if (new_sock != INVALID_SOCKET)
{
pSocket = new CSocketEx(new_sock);
// create a new thread to process the connection request with pSocket
}
}
continue;
}
}