I am having trouble making this binary counter, to count minutes and seconds. When I try to verify, I get the error below. How do I fix this broken code?
Error message
Expected `;' before '}' token
Code
#define DATA 0
#define LATCH 1
#define CLOCK 2
#define DATA2 3
#define LATCH2 4
#define CLOCK2 5
void setup()
(
pinMode{LATCH, OUTPUT};
pinMode(CLOCK, OUTPUT);
pinMode(DATA, OUTPUT);
pinMode(LATCH2, OUTPUT);
pinMode(CLOCK2, OUTPUT);
pinMode(DATA2, OUTPUT);
)
void loop()
{
int i;
for (i = 0; i < 256; i++)
{
digitalWrite(LATCH, LOW);
shiftOut(DATA, CLOCK, MSBFIRST, i);
digitalWrite(LATCH, HIGH);
delay(200);
}
int c;
for (c = 0; c < 256; c++)
{
digitalWrite(LATCH2, LOW);
shiftOut(DATA2, CLOCK2, MSBFIRST, c);
digitalWrite(LATCH2, HIGH);
delay(100)
}
}
The problem is in this section (also pinMode{LATCH, OUTPUT};, as in comments):
void setup()
(
pinMode{LATCH, OUTPUT};
pinMode(CLOCK, OUTPUT);
pinMode(DATA, OUTPUT);
pinMode(LATCH2, OUTPUT);
pinMode(CLOCK2, OUTPUT);
pinMode(DATA2, OUTPUT);
)
The parenthesis pair should be a pair of curly brackets (braces):
void setup()
{
pinMode(LATCH, OUTPUT);
pinMode(CLOCK, OUTPUT);
pinMode(DATA, OUTPUT);
pinMode(LATCH2, OUTPUT);
pinMode(CLOCK2, OUTPUT);
pinMode(DATA2, OUTPUT);
}
Related
How do you program Arduino to do a countdown timer 10 times using a buzzer, then after that, the light will turn on (relay). In addition, 4 PIR sensors will detect movement, if there is movement, the light will turn off for 10 seconds after which the light will turn on again. I already try to code but something feels off because the light is on at the start and the sensor detects when the timer is still running.
Here is the code that I try to code:
#define relayPin 12
#define pirPin1 8
#define pirPin2 9
#define pirPin3 10
#define pirPin4 11
int val1 = 0,val2 = 0, val3 = 0, val4 = 0 ;
long buzzerFrequency = 1000;
float buzzerDuration = 100;
int startNumber = 9; //countdown starts with this number
int endNumber = 0; //countdown ends with this number
const int buzzerPin = 6;
void setup() {
// put your setup code here, to run once:
pinMode(buzzerPin,OUTPUT);
pinMode(relayPin,OUTPUT);
pinMode(pirPin1, INPUT);
pinMode(pirPin2, INPUT);
pinMode(pirPin3, INPUT);
pinMode(pirPin4, INPUT);
Serial.begin(115200);
}
void buzzer(){
if (startNumber >= endNumber) {
for (int i = 0; i <= 1; i++){
tone(buzzerPin,buzzerFrequency,buzzerDuration);
}
delay(1000);
startNumber--;
}
}
void allPir(){
val1 = digitalRead(pirPin1);
val2 = digitalRead(pirPin2);
val3 = digitalRead(pirPin3);
val4 = digitalRead(pirPin4);
if(val1 == HIGH || val2 == HIGH || val3 == HIGH || val4 == HIGH){
digitalWrite(relayPin, HIGH);
Serial.println("Movement! delay 10 second");
Serial.println("Light off");
delay(10000);
}else{
digitalWrite(relayPin, LOW);
Serial.println("No Movement");
Serial.println("Light on");
}
}
void loop() {
// put your main code here, to run repeatedly:
buzzer();
allPir();
}
The countdown should have finished first with a buzzer sound, then the light will turn on, then the PIR sensor will check the environment. How to fix it? and what do I need to add?
I'm currently doing a circuit which has two seven segment display. Is there any codes to lessen the usage of digitalwrite()? your text
I also found some codes in arduino for a single seven segment to reduce the digitalwrite.
Here is my code
int E1 = 13;
int E2 = 12;
int D1 = 11;
int D2 = 10;
int C1 = 9;
int C2 = 8;
int G1 = 7;
int G2 = 6;
int F1 = 5;
int F2 = 4;
int a1 = 3;
int a2 = 2;
int b1 = 1;
int B2 = 0;
//setting up the pin
void setup()
{
pinMode(E1, OUTPUT);
pinMode(E2, OUTPUT);
pinMode(D1, OUTPUT);
pinMode(D2, OUTPUT);
pinMode(C1, OUTPUT);
pinMode(C2, OUTPUT);
pinMode(G1, OUTPUT);
pinMode(G2, OUTPUT);
pinMode(F1, OUTPUT);
pinMode(F2, OUTPUT);
pinMode(a1, OUTPUT);
pinMode(a2, OUTPUT);
pinMode(b1, OUTPUT);
pinMode(B2, OUTPUT);
}
byte pinNumArr [7]{A1, B1, C1, D1, E1, F1,G1};
byte number7S [10] [7] =
{
{HIGH,HIGH,HIGH,HIGH,HIGH,HIGH, LOW}, // Number 0
{LOW,HIGH,HIGH,LOW,LOW,LOW, LOW}, // Number 1
{HIGH,HIGH,LOW,HIGH,HIGH,LOW,HIGH}, // Number 2
{HIGH,HIGH,HIGH,HIGH,LOW,LOW,HIGH}, // Number 3
{LOW,HIGH,HIGH,LOW,LOW,HIGH,HIGH}, // Number 4
{HIGH,LOW,HIGH,HIGH,LOW,HIGH,HIGH}, // Number 5
{HIGH,LOW,HIGH,HIGH,HIGH,HIGH,HIGH}, // Number 6
{HIGH,HIGH,HIGH,LOW,LOW,LOW,LOW}, // Number 7
{HIGH,HIGH,HIGH,HIGH,HIGH,HIGH,HIGH}, // Number 8
{LOW,HIGH,HIGH,HIGH,LOW,HIGH,HIGH} // Number 9
};
void displayNumber(byte value = 0 )
{
for (int idx = 0; idx < 7; idx++)
{
digitalWrite(pinNumArr[idx], number7S[value][idx]);
value = number7S[value][idx];
}
};
void loop()
{
displayNumber();
delay(500);
}
I want to lessen the usage of digitalwrite for double seven segment display
You can do direct port manipulation instead of all those digitalWrite().
Digital pins 0-7 are on PORTD and digital pins 8-13 are on PORTB.
You can set all of the pins in one line like this:
PORTB = B00000000; //Set pin 8-13 LOW
or you could say:
PORTB = B00010100; //Set pin 10 and 12 HIGH, all others low
I'm working on my college project on which I have to measure the temperature show it on 16x2 LCD and also to switch the cooling device according to the temperature, also I have to use pH Sensor and have to display its value on 16x2. Currently I'm using the code below for Temperature and switching, but it is not working properly. It shows the temperature on the screen but also some garbage value, and also not switching properly.
#include <Wire.h>
#include <LCD.h>
#include <LiquidCrystal_I2C.h>
#include <dht.h>
dht DHT;
#define DHT11_PIN 7
LiquidCrystal_I2C lcd(0x27,2,1,0,4,5,6,7);
const int ledPin = 6;
void setup()
{
lcd.setBacklightPin(3,POSITIVE);
lcd.setBacklight(HIGH);
lcd.begin(16, 2);
lcd.clear();
Serial.begin(9600);
for (int DigitalPin = 8; DigitalPin <= 8; DigitalPin++) {
pinMode(DigitalPin, OUTPUT);
}
}
void loop()
{
int chk = DHT.read11(DHT11_PIN);
float temp=(DHT.temperature);
float Hum=(DHT.humidity);
lcd.print("Temp C ");
lcd.setCursor(6,0);
lcd.print(temp);
lcd.setCursor(0,1);
lcd.println("Humid % ");
lcd.setCursor(6,1);
lcd.print(Hum);
delay(1000);
if (temp <= 29)
digitalWrite(8, LOW);
else if (temp>30)
digitalWrite(8, HIGH);
}
I will divide my answer into two parts:
Hardware:
Please describe your hardware configuration in order to narrow down your problem: How are you switching the relay? Is it optically coupled? Are you using a transistor? If so, what type? Does your relay have reverse diode protection? (Do not connect your relay directly to an Arduino pin)
Code
2.1. This for-loop in your setup() is incorrect:
for (int DigitalPin = 8; DigitalPin <= 8; DigitalPin++) {
pinMode(DigitalPin, OUTPUT);
}
You are indexing from 8 to 8, hence you don't need a for loop to declare a single pin as an output.
2.2. In general, you can assign your output pins to variables, or as a macro like you did for the DHT. Just be consistent. Additionally, your code needs general tidying up:
a . Start your code with all libraries calling
#include <Wire.h> // The Wire.h library is already called by the LiquidCrystal_I2C library, so you don't need to call it if you use the I2C one
#include <LCD.h> // You are using the LCD library...
#include <LiquidCrystal_I2C.h> // but also the I2C lcd library. You don't need both.
#include <dht.h> // Is this the latest version? Use Adafruit's
b. Try to group all your macros at the beginning. Declare pins or constants here:
// Using macros
#define DHT11_PIN 7
#define DigitalPin 8
#define DHT11_PIN 7
or using constants for pins. Choose one, not both:
// Group all your const int together, for the sake of clarity
const int DHT_PIN = 7;
const int DigitalPin = 8;
const int ledPin = 6;
c. I believe this constructor is not correct for the library you chose. Check the example from this library (assuming it is the same, which I believe it is)
LiquidCrystal_I2C lcd(0x27,2,1,0,4,5,6,7);
try with this constructor, instead:
// Set the LCD address to 0x27 for a 16 chars and 2 line display
LiquidCrystal_I2C lcd(0x27, 16, 2);
d. The setup() function needs some changes too:
void setup()
{
// You don't seem to be using the serial library. However, if you use it, it is
// preferable to start it first.
Serial.begin(9600);
// LCD configuration
lcd.begin(16, 2); // Always call the begin() method first
lcd.setBacklightPin(3,POSITIVE); // Then, use additional configuration methods.
lcd.setBacklight(HIGH);
lcd.clear();
// Once again, please check if you are using the right library.
// It might be the cause of the garbage you see.
// Initialize the type of pin
pinMode(DigitalPin, OUTPUT);
}
e. According to Adafruit's library (please see the examples), you are missing a Macro to declare the type of DHT sensor you are using:
#define DHTTYPE DHT11
f. In your main loop() you are reading values with some strange parenthesis:
int chk = DHT.read11(DHT11_PIN);
float temp=(DHT.temperature);
float Hum=(DHT.humidity);
which, according to the latest library, should be:
// The latest library does not have this prototype: int chk = DHT.read11(DHT11_PIN); What is it for in your dht lib?
float temp = DHT.readTemperature(); // instead of: float temp=(DHT.temperature); --> which should be DHT.temperature(); in any case
float hum = DHT.readHumidity(); // instead of: float Hum=(DHT.humidity);
TL;DR: Share your hardware in order to assist you. Update your libraries, clean-up your code, and use the right methods from the latest libraries.
Thankyou so much for your guidance, below is the working code for me:
#include <Wire.h>
#include <LiquidCrystal_I2C.h>
#include <DHT.h>
#define DHTPIN 7 //digital pin for sensor
#define DHTTYPE DHT11 // DHT 11
DHT dht(DHTPIN, DHTTYPE);
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);
void setup()
{
pinMode(8, OUTPUT); //for configuring relay output
lcd.begin(16, 2);
dht.begin();
}
void loop() {
delay(1000);
float h = dht.readHumidity();
// Read temperature as Celsius (the default)
float t = dht.readTemperature();
// Read temperature as Fahrenheit (isFahrenheit = true)
float f = dht.readTemperature(true);
// Check if any reads failed and exit early (to try again).
if (isnan(h) || isnan(t) || isnan(f))
{
lcd.print("NO CONNECTION");
return;
}
//Hum code
lcd.setCursor(0, 0);
lcd.print("Hum:");
lcd.print(h);
lcd.print(" % ");
//Temp code
lcd.setCursor(0, 1);
lcd.print("Temp:");
lcd.print(t);
lcd.print(" C");
//To operate relay
{
if (t <= 26)
digitalWrite(8, LOW);
else if (t>27)
digitalWrite(8, HIGH);
}
}
I am reading the output in voltage of a turbidity sensor : https://www.dfrobot.com/product-1394.html?tracking=5b603d54411d5 with an Arduino UNO. I want to print the value of volts outage and its NTU (turbidity units) on an LCD screen ADM1602U Sparkfun.
I cant seem to print the dtata correctly on the lCD, it opens and lights up (so I think the wiring is ok) but no data appear.
Here is the code I am using:
#include <Wire.h>
#include <LiquidCrystal_I2C.h>
// Set the LCD address to 0x27 for a 16 chars and 2 line display
LiquidCrystal_I2C lcd(0x27, 16, 2);
int sensorPin = A0;
int val = 0;
float volt;
float ntu;
void setup()
{
Serial.begin(9600);
lcd.init();
// Turn on the blacklight and print a message.
lcd.backlight();
}
void loop()
{
volt = ((float)analogRead(sensorPin)/1023)*5;
ntu = -1120.4*square(volt)+5742.3*volt-4353.8;
val = analogRead(volt);
Serial.println(volt);
lcd.clear();
lcd.setCursor(0,0);
lcd.print(volt);
lcd.print(" V");
lcd.setCursor(0,1);
lcd.print(ntu);
lcd.print(" NTU");
delay(10);
}
float round_to_dp( float in_value, int decimal_place )
{
float multiplier = powf( 10.0f, decimal_place );
in_value = roundf( in_value * multiplier ) / multiplier;
return in_value;
}
I used an analogread just to see if I was getting correct voltage values for the sensor and I am.
Thanks
Ok so I found the answer, the libary used was not appropriate to print on a 16x2 LCD display. The following code worked FYI:
#include <Wire.h>
#include <SoftwareSerial.h>
// Set the LCD address to 0x27 for a 16 chars and 2 line display
SoftwareSerial LCD(10, 11); // Arduino SS_RX = pin 10 (unused), Arduino SS_TX = pin 11
int sensorPin = A0;
float volt;
float ntu;
void setup()
{
Serial.begin(9600);
LCD.begin(9600); // set up serial port for 9600 baud
delay(500); // wait for display to boot
}
void loop()
{
volt = ((float)analogRead(sensorPin)/1023)*5;
ntu = -1120.4*square(volt)+5742.3*volt-4352.9;
Serial.println(volt);
// move cursor to beginning of first line
LCD.write(254);
LCD.write(128);
// clear display by sending spaces
LCD.write(" ");
LCD.write(" ");
// move cursor to beginning of first line
LCD.write(254);
LCD.write(128);
LCD.print(volt);
LCD.write(" V");
LCD.write(254);
LCD.write(192);
LCD.print(ntu);
LCD.write(" NTU");
delay(1000);
}
I have a HC-SR04 Ultrasonic sensor connected to my Arduino Uno. The problem I'm having is when I check the Serial Monitor to see if the sensor is working: it only says "Out of Range" regardless of the distance. I believe I may have the distance calculation wrong because the RedLED stays on and the buzzer doesn't go off.
Here's my .ino code:
#define trigPin 6
#define echoPin 7
#define RedLED 9
#define buzzer 3
int sound = 500;
void setup() {
Serial.begin (9600);
pinMode(trigPin, OUTPUT);
pinMode(echoPin, INPUT);
pinMode(RedLED, OUTPUT);
pinMode(buzzer, OUTPUT);
}
void loop() {
long duration, distance;
digitalWrite(trigPin, LOW);
delayMicroseconds(2);
digitalWrite(trigPin, HIGH);
delayMicroseconds(10);
digitalWrite(trigPin, LOW);
duration = pulseIn(echoPin, HIGH);
distance = (duration/5) / 29.1;
if (distance < 20) {
digitalWrite(RedLED, HIGH);
sound = 1000;
}
else {
digitalWrite(RedLED,LOW);
}
if (distance > 20 || distance <= 0){
Serial.println("Out of range");
noTone(buzzer);
}
else {
Serial.print(distance);
Serial.println(" cm");
tone(buzzer, sound);
}
delay(300);
}
Can't post a comment so I'll post it in Answer.
Check that you have connected VCC to 5v and not to 3.3v.
I think your calculations are ok. Also to exclude calculations just print the duration and see if it changes.