Running a makefile using shell script - bash

I have a directory structure as follows:
.
├── one
│   ├── one_one
│   │   └── one_one_one
│   │   ├── Makefile
│   │   └── one_one_oneTest.cpp
│   └── one_two
│   ├── Makefile
│   └── one_twoTest.cpp
├── three
│   ├── Makefile
│   └── threeTest.cpp
└── two
└── two_one
├── Makefile
└── two_oneTest.cpp
I want to run the make command where ever I find the Makefile. So, I have written a shell script as follows.
#!/bin/bash
find . -type f -name Makefile -exec make \;
But it gives error saying make: *** No targets specified and no makefile found. Stop.
If I just run find . -type f -name Makefile, I get
./two/two_one/Makefile
./three/Makefile
./one/one_two/Makefile
./one/one_one/one_one_one/Makefile
which is the correct output I expected.
If I run the Makefile using make command, it runs properly, so I think the Makefile is correct.
What can be wrong with the shell script?
Just for reference, one of my Makefiles is as follows:
all: TestTwoOne
TestTwoOne: two_oneTest.cpp
g++ two_oneTest.cpp -o TestTwoOne

Your "current directory" is not being changed to the appropriate subdirectories for running the make. Do this instead:
find . -type f -name Makefile -execdir make \;

Related

Makefile pattern rules cannot expand into directory with wildcards

I am trying to use make to build a set of markdown documents from specific and shared files.
PKGS := foo bar baz app
DEFAULT := DEPENDENCIES.md RULES.md
BUILD := .build
VPATH := .:packages
$(BUILD)/%.history.md: $(DEFAULT) $(wildcard %/RULES.*.md) $(foreach f,$(DEFAULT),%/$(f))
echo "!! BUILDING NOW $#"
echo $^
echo
with the following directory structure:
.
├── ABSTRACT.md
├── DEPENDENCIES.md
├── IMPLEMENTATION.md
├── Makefile
├── packages
│   ├── foo
│   │   ├── ABSTRACT.md
│   │   ├── DEPENDENCIES.md
│   │   ├── IMPLEMENTATION.md
│   │   ├── RULES.0.md -> ../COMMON.md
│   │   └── RULES.md
│   ├── COMMON.md
│   ├── bar
│   │   ├── ABSTRACT.md
│   │   ├── DEPENDENCIES.md
│   │   ├── IMPLEMENTATION.md
│   │   └── RULES.md
│   ├── baz
│   │   ├── ABSTRACT.md
│   │   ├── DEPENDENCIES.md
│   │   ├── IMPLEMENTATION.md
│   │   └── RULES.md
│   └── app
│   ├── ABSTRACT.md
│   ├── DEPENDENCIES.md
│   ├── IMPLEMENTATION.md
│   ├── RULES.0.md -> ../COMMON.md
│   └── RULES.md
└── RULES.md
However, $(wildcard %/RULES.*.md) always seems to expand into an empty list.
When executing make .build/foo.history.md I expected it to evaluate the prerequisites as DEPENDENCIES.md RULES.md packages/foo/RULES.0.md packages/foo/DEPENDENCIES.md packages/foo/RULES.md but instead I see this:
make .build/foo.history.md
echo "!! BUILDING NOW .build/foo.history.md"
!! BUILDING NOW .build/foo.history.md
echo DEPENDENCIES.md RULES.md packages/foo/DEPENDENCIES.md packages/foo/RULES.md
DEPENDENCIES.md RULES.md packages/foo/DEPENDENCIES.md packages/foo/RULES.md
echo
I've also tried adding some extra targets to better understand the process:
# Pattern rule with `%` as a directory clearly works.
%.static: %/RULES.0.md
echo $# -> $^
%.semi: %/RULES.*.md
echo $# -> $^
%.x: $(wildcard packages/%/RULES.*.md)
echo $# -> $^
# Wildcards using * also clear work.
app.y: $(wildcard packages/app/RULES.*.md)
echo $# -> $^
# Combination of both fails.
# I expect that if the target is `foo.z` for the prerequisites to expand into `foo/RULES.*.md`,
# searching within the VPATH.
%.z: $(wildcard %/RULES.*.md)
echo $# -> $^
Which results in this:
$ make app.static --just-print
echo app.static -> packages/app/RULES.0.md
$ make app.semi --just-print
make: *** No rule to make target 'app.semi'. Stop.
$ make app.x --just-print
echo app.x ->
$ make app.y --just-print
echo app.y -> packages/app/RULES.0.md
$ make app.z --just-print
echo app.z ->
I've also tried using .SECONDEXPANSION, but I couldn't get it to work with that either and I keep seeing other people recommending against it.
Additionally, it does work for $(foreach f,$(DEFAULT),%/$(f)) expanding correctly into packages/app/DEPENDENCIES.md packages/app/RULES.md which adds confusion as to why it doesn't work in $(wildcard).
The high-level problem is that you're trying to use too many unfamiliar tools at once. Let's take VPATH out of the picture for now.
The wildcard function will work, with secondary expansion:
.SECONDEXPANSION:
$(BUILD)/%.history.md: $$(wildcard packages/%/RULES.*.md)
echo "!! BUILDING NOW $#"
echo $^
echo
Notice that we must escape the $ in the prerequisite list with another $. I don't know why people advised against secondary expansion, but I see no easier way to get the effect you want.
Now about that VPATH. There isn't much need for it, since you want to search only one directory (packages/). Also, it doesn't work well with wildcard because VPATH tells Make where to look for prerequisites; it doesn't tell wildcard where to look for matches. And Make doesn't know what prerequisite to look for until after wildcard has done its work, which it can't because it doesn't know where to look. I advise you to do without it.

loop through specific sub folders inside a folder and delete files contains specific name - AIX

My folder structure is as follows:
there are 100 folders and every folder has 3 sub folders (imagine A, B and C). My task is to delete files which has specific text inside folder C only, from all the 100 folders.
i have minimal knowledge on Unix commands and my task is to perform on AIX server
i tried to google around and found the script below (it actually doesn't do the deletion).
and when i tried to execute the following script , i get the following error
"test.sh[5]: accepted: not found."
but there is actually "accepted" folder existed.not sure why the error is occurred.
for dir in $(ls)
do
for dir2 in $(ls)
do
cd accepted
echo $(ls)
done
done
Could any one help me update the script to perform "loop through sub folders inside a folder and delete files contains specific text inside specific sub folder only" ?
Let me assume the directory tree as an example:
X
├── A
│   ├── D
│   │   ├── bar.txt
│   │   └── foo.txt
│   ├── E
│   │   ├── bar.txt
│   │   └── foo.txt
│   └── F
│   ├── bar.txt
│   └── foo.txt
├── B
│   ├── D
│   │   ├── bar.txt
│   │   └── foo.txt
│   ├── E
│   │   ├── bar.txt
│   │   └── foo.txt
│   └── F
│   ├── bar.txt
│   └── foo.txt
└── C
├── D
│   ├── bar.txt
│   └── foo.txt
├── E
│   ├── bar.txt
│   └── foo.txt
└── F
├── bar.txt
└── foo.txt
And suppose you want to remove files which starts with foo from the directory F only.
Then please try the following:
find X/*/F -type f -name "foo*" -delete
Now the directory tree will look like:
X
├── A
│   ├── D
│   │   ├── bar.txt
│   │   └── foo.txt
│   ├── E
│   │   ├── bar.txt
│   │   └── foo.txt
│   └── F
│   └── bar.txt
├── B
│   ├── D
│   │   ├── bar.txt
│   │   └── foo.txt
│   ├── E
│   │   ├── bar.txt
│   │   └── foo.txt
│   └── F
│   └── bar.txt
└── C
├── D
│   ├── bar.txt
│   └── foo.txt
├── E
│   ├── bar.txt
│   └── foo.txt
└── F
└── bar.txt
I hope this meets your requirement.
While possible to implement the logic for identifying the files using tree search, this is not required for this case. Consider the following.
Note that solution will NOT work if any file names have special characters (spaces, quotes, new lines). It will work for "normal" file names (With the characters a-zA-Z0-9_-. etc)..
file_list=$(grep -l SomeText */C/*)
rm $file_list
Possible to combine into one line - use with care
rm $(grep -l SomeText */C/*)
You can also use rm -i instead of rm to get prompted for each file to be removed, if needed.

move files from subdirectory into parent folder with same name

I have several folders for each year and inside of those folders there are files corresponding different stations. Somewhat like this:
.
├── 2017.1
│   ├── AAAA.2017
│   ├── BBBB.2017
│   └── CCCC.2017
├── 2018.1
│   ├── AAAA.2018
│   ├── BBBB.2018
│   └── CCCC.2018
└── 2019.1
├── AAAA.2019
├── BBBB.2019
└── CCCC.2019
What I want to do is to move all of these files into the main directory "."according to their name, so it would be something like this:
├── AAAA
│   ├── AAAA.2017
│   ├── AAAA.2018
│   └── AAAA.2019
├── BBBB
│   ├── BBBB.2017
│   ├── BBBB.2018
│   └── BBBB.2019
├── CCCC
│   ├── CCCC.2017
│   ├── CCCC.2018
│   └── CCCC.2019
I tried some simple code in which I create the folders and simply move the files according to their station. I was wondering if there was a more "elegant" or simple way of doing it
mkdir AAAA BBBB CCCC
for file in 20*/AAAA*; do
cp "$file" "/Users/admin/Desktop/test/AAAA"
done
for file in 20*/BBBB*; do
cp "$file" "/Users/admin/Desktop/test/BBBB"
done
for file in 20*/CCCC*; do
cp "$file" "/Users/admin/Desktop/test/CCCC"
done
I suggest while loop solution.
SRC_DIR=/path/to/dir
DEST_DIR=/tmp
cd "${SRC_DIR}"
find . -type f \
| while read -r FILE; do
BASENAME=${FILE##*/}
mkdir -p "${DEST_DIR}/${BASENAME%.*}" && cp -a $FILE "${DEST_DIR}/${BASENAME%.*}"
done

make: automatic variables in pattern rule prerequisites

I'm using GNU Make on Arch Linux to generate PDFs from LilyPond source files. I have a directory structure as follows:
scores/
├── makefile
├── out
│   ├── others-songs
│   │   ├── ...
│   │   ├── ...
│   │   └── 失恋阵线联盟
│   │   ├── 失恋阵线联盟.edition.log
│   │   ├── 失恋阵线联盟.oll.log
│   │   └── 失恋阵线联盟.pdf
│   └── ...
├── src
│   ├── others-songs
│   │   ├── ...
│   │   ├── ...
│   │   └── 失恋阵线联盟
│   │   ├── chorus.ily
│   │   ├── verse.ily
│   │   ├── words.ily
│   │   └── 失恋阵线联盟.ly
│   └── ...
The PDFs in the out directory depend on the .ily and .ly files in the corresponding directory in src. The following implicit pattern rule works if the .ly file is modified, but not if any of the other files are:
LY = $(shell find src -iname '*.ly')
PDF = $(subst src,out,$(LY:.ly=.pdf))
pdf: $(PDF)
out/%.pdf: src/%.ly
#mkdir -p $(dir $#)
#lilypond --include=$(lib) \
-dpoint-and-click=\#f \
-o $(basename $#) $<
I tried doing several different things, like appending $(<D)*.ily to the prerequisites, but it wasn't successful. I've looked at the GNU make manual online for help, but I didn't come up with anything that that I was able to apply to my particular situation.
How can I write a pattern rule that makes each PDF depend on all the files in the appropriate corresponding source directory?
EDIT
I may not have been clear enough with my first question. The behavior I want is if any of the files in the source directories are changed, the corresponding PDF is updated. For example, if chorus.ily is changed, then 失恋阵线联盟.ly is made.
A working example:
LY := $(shell find src -iname '*.ly')
PDF := ${LY:src/%.ly=out/%.pdf}
pdf: $(PDF)
define pdf_deps
$(1:src/%.ly=out/%.pdf) : $(wildcard $(dir ${1})*)
endef
# Make each pdf depend on all the files in its src directory.
$(foreach ly,${LY},$(eval $(call pdf_deps,${ly})))
out/%.pdf:
#echo "making $# from $^"
Usage:
$ ls -1R
.:
Makefile
out
src
./out:
./src:
A
B
./src/A:
a.ly
./src/B:
b.1
b.ly
$ make
making out/B/b.pdf from src/B/b.ly src/B/b.1
mkdir -p out/B
touch out/B/b.pdf
making out/A/a.pdf from src/A/a.ly
mkdir -p out/A
touch out/A/a.pdf
$ make
make: Nothing to be done for 'pdf'.
$ touch src/B/b.ly
$ make
making out/B/b.pdf from src/B/b.ly src/B/b.1
mkdir -p out/B
touch out/B/b.pdf
$ make
make: Nothing to be done for 'pdf'.
$ touch src/B/b.1
$ make
making out/B/b.pdf from src/B/b.ly src/B/b.1
mkdir -p out/B
touch out/B/b.pdf
$ make
make: Nothing to be done for 'pdf'.

recreate directory structure and recursively process each file with gnu make

I have a directory tree like this:
├── dir_a
│   └── file_1.txt
├── dir_b
│   └── dir_c
│   ├── file_2.txt
| └── file_3.txt
└── file_4.txt
I want to mirror this directory structure to hold the results of a command that processes each text file. I.e., the output would look like this:
├── build
│   ├── dir_a
│   │   └── processed_file_1.txt
│   ├── dir_b
│   │   └── dir_c
│   │   ├── processed_file_2.txt
│   | └── processed_file_3.txt
│   └── processed_file_4.txt
├── dir_a
│   └── file_1.txt
├── dir_b
│   └── dir_c
│   ├── file_2.txt
| └── file_3.txt
└── file_4.txt
I'm not very adept with Makefiles, so my question is: how can I get a Makefile to recreate the directory structure and recursively process all text files to place them into the right place inside the build directory? I'll be running this repeatedly as the input files change, so a Makefile that doesn't process unchanged files seems like the right way to go.
Update:
I should also mention that new input files will be added frequently, so I don't want the Makefile to name them explicitly.
It would be easier if you used stems with different suffixes rather than inserting that "processed_" string, but here's an example that works for me here:
OUTPUTS := build/dir_a/processed_file_1.txt \
build/dir_b/dir_c/processed_file_2.txt \
build/dir_b/dir_c/processed_file_3.txt \
build/processed_file_4.txt
all: $(OUTPUTS)
.SECONDEXPANSION:
$(OUTPUTS): build/% : $$(subst processed_file_,file_,%)
mkdir -p $(dir $#)
cp $< $#
clean:
rm -rf build
You could remove the complication of .SECONDEXPANSION by changing the end of the filename instead of the beginning:
OUTPUTS := build/dir_a/file_1.out \
build/dir_b/dir_c/file_2.out \
build/dir_b/dir_c/file_3.out \
build/file_4.out
all: $(OUTPUTS)
$(OUTPUTS) : build/%.out : %.txt
mkdir -p $(dir $#)
cp $< $#
clean:
rm -rf build
As Carl suggested, you could use secondary expansion, but in conjunction with order-only prerequisites.
BUILD_DIR = build
IN_FILES := dir_a/file_1.out \
dir_b/dir_c/file_2.out \
dir_b/dir_c/file_3.out \
file_4.out
OUT_FILES := $(IN_FILES:%=$(BUILD_DIR)/%)
all: $(OUT_FILES)
.SECONDEXPANSION:
$(OUT_FILES) : $(BUILD_DIR)/%.out : %.txt | $$(#D)/.
# your text processing rule here...
%/. :
mkdir -p $*
| $$(#D) means:
during the secondary expansion calculate the value of $(#D) automatic variable (which is the directory part of the target), and
add the order-only dependency on it, that is ensure that the directory exists, but don't consider remaking the target if it is older than the directory (which is an often case)

Resources