How add a circuit breaker for <int:gateway> in spring integration - spring

Question

Here is my code i had a gateway defined in my spring-config.xml like below
<int:gateway id="myGateway"
service-interface="com.sample.si.MyService"
error-channel="myError-channel"
default-request-channel="sendServiceChannel"
>
<int:method name="sendService" request-channel="sendServiceChannel" /
When i debug my test it is directly going to RequesthandlerCircuitBreakerAdvice.class and never going to my error channel, below is my error channel
<int:channel id="myError-channel">
</int:channel>
<int:chain input-channel="myError-channel">
<int:service-activator ref="myErrorHandler" method="resolveError" />
</int:chain>
I want to redirect to error channel when i had an exception from gateway and want to redirect every message to error channel with the circuitbreaker halfopen timelimit. Any help is appreciated
Edit Showing Outbound gateway
<int-ws:outbound-gateway id="sendMyService"
uri="${my.gateway.send.uri}"
mapped-request-headers="*"
marshaller="SOAPMarshaller"
unmarshaller="SOAPMarshaller"
message-sender="soapMessageSender"
request-channel="sendServiceChannel"
fault-message-resolver="faultResolver"
reply-channel="sendServiceResponseChannel">
<int:request-handler-advice-chain>
<bean class="org.springframework.integration.handler.advice.RequestHandlerCircuitBreakerAdvice">
<property name="threshold" value="1" />
<property name="halfOpenAfter" value="10000" />
</bean>
</int:request-handler-advice-chain>
I want the circuit breaker between the and so that i dont want to hit the outbound gateway when the provided uri in the outbound gateway is not available, thanks for looking in to it Gary Russell
Here is my testcase
public class EmailGatewayProducerConsumerTest {
#Inject
#Qualifier("myGateway")
private Myservice myService;
#Test
public void senderTest(){
MyRequest myRequest = new MyRequest(12,"rajendra","rajednra.ch#hotmail.com");
try {
myService.sendService(myRequest);
}catch (Exception e){
//System.out.println("Caught Exception " +e);
}
}
}
The error handler is a sending the exception message to queue and reading it back and sending again to gateway here is my error handler code
public class ErrorHandler{#Inject private JmsTemplate jmsTemplate;
public void resolveError( Message<MessagingException> message) {
try{
MyRequest myRequest=(MessageRequest)message.getPayload().getFailedMessage().getPayload()
jmsTemplate.convertAndSend(DATA_QUEUE, myRequest);
} catch(Exception e){
//log error
}
}
}
Here is my consumer which consumes it and sends back to the gateway
#JmsListener(destination = DATA_QUEUE)public void consume(MyRequest myRequest) throws InterruptedException {
log.info("Receiving event: {}", myRequest);
try {
myService.sendService(myRequest)
}catch (Exception e){
log.error(e.toString());
} }
Exception:
Caused by: org.springframework.ws.client.WebServiceIOException: I/O error: Connect to localhost:10002 timed out; nested exception is org.apache.http.conn.ConnectTimeoutException: Connect to localhost:10002 timed out
at org.springframework.ws.client.core.WebServiceTemplate.sendAndReceive(WebServiceTemplate.java:561)
at org.springframework.integration.ws.MarshallingWebServiceOutboundGateway.doHandle(MarshallingWebServiceOutboundGateway.java:81)
at org.springframework.integration.ws.AbstractWebServiceOutboundGateway.handleRequestMessage(AbstractWebServiceOutboundGateway.java:188)
at org.springframework.integration.handler.AbstractReplyProducingMessageHandler$AdvisedRequestHandler.handleRequestMessage(AbstractReplyProducingMessageHandler.java:144)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at org.springframework.integration.handler.advice.AbstractRequestHandlerAdvice$1.execute(AbstractRequestHandlerAdvice.java:74)
at org.springframework.integration.handler.advice.RequestHandlerCircuitBreakerAdvice.doInvoke(RequestHandlerCircuitBreakerAdvice.java:61)
at org.springframework.integration.handler.advice.AbstractRequestHandlerAdvice.invoke(AbstractRequestHandlerAdvice.java:69)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:207)
at com.sun.proxy.$Proxy102.handleRequestMessage(Unknown Source)
at org.springframework.integration.handler.AbstractReplyProducingMessageHandler.doInvokeAdvisedRequestHandler(AbstractReplyProducingMessageHandler.java:117)
at org.springframework.integration.handler.AbstractReplyProducingMessageHandler.handleMessageInternal(AbstractReplyProducingMessageHandler.java:102)
at org.springframework.integration.handler.AbstractMessageHandler.handleMessage(AbstractMessageHandler.java:78)
... 90 more

Answer 1

The gateway (and hence error channel) is downstream of your circuit breaker - you need to show what's upstream of (before) the service-activator - that's where you need to configure the error-channel to handle the circuit-breaker result.
That said, you have a circular dependency here - the gateway is sending to the service-activator, which is invoking the gateway again.
You need to explain further what you are trying to do - show more config - upstream and downstream.
EDIT
Bear in mind that will cause an infinite loop because the failed message will be retried indefinitely.
Sending to JMS should not make any different compared to this test case, which works exactly as I would expect (including the infinite loop)...
public interface GW {
void send(String foo);
}
<int:gateway id="gw" service-interface="com.example.GW" default-request-channel="foo"
error-channel="errorChannel"/>
<int:service-activator input-channel="foo" expression = "1 / 0"> <!-- always fail -->
<int:request-handler-advice-chain>
<bean class="org.springframework.integration.handler.advice.RequestHandlerCircuitBreakerAdvice">
<property name="threshold" value="1" />
<property name="halfOpenAfter" value="10000" />
</bean>
</int:request-handler-advice-chain>
</int:service-activator>
<int:bridge input-channel="errorChannel" output-channel="retryChannel" />
<int:channel id="retryChannel">
<int:queue />
</int:channel>
<int:chain input-channel="retryChannel">
<int:transformer expression="payload.failedMessage.payload" />
<int:service-activator ref="gw" />
<int:poller fixed-delay="1000" />
</int:chain>
Result:
org.springframework.messaging.MessageHandlingException: Expression evaluation failed: 1 / 0;
...
Caused by: java.lang.ArithmeticException: / by zero
CircuitBreakerOpenException: Circuit Breaker is Open for ServiceActivator for [ExpressionEvaluatingMessageProcessor for: [1 / 0]]
CircuitBreakerOpenException: Circuit Breaker is Open for ServiceActivator for [ExpressionEvaluatingMessageProcessor for: [1 / 0]]
CircuitBreakerOpenException: Circuit Breaker is Open for ServiceActivator for [ExpressionEvaluatingMessageProcessor for: [1 / 0]]

Answer 2

Above is my edited configuration that worked for me to implement the circuit breaker, after all the changes I still had this issue with halfOpenAfter time, which I increased to 60000 and it worked the above solution in the question should work for circuit breaker, follow the comment of me and Gary Russell.