I am using the following function to generate passwords:
genpasswd() {
local l=$1
[[ "$l" == "" ]] && l=15
echo $(tr -dc "[:print:]" < /dev/urandom | head -c ${l})
}
This works almost all of the time; however, every now and then I get a password with a strange character or a password that is not the correct length. This can be demonstrated by running the following command:
COUNTER=0; while [ $COUNTER -lt 1000000 ]; do; pass=$(genpasswd); if [ ${#pass} -ne 15 ]; then; echo $pass; fi; done
It generated the following output for me for instance (I cut it off after a little while):
G/bteEpm
U^e^!7oT\hGC3)
S7Dcpio1GlQTM
CYOyMMA
$Ze^li
&EKl}'o]u7[]T5
i|y9#6P7?
I9)y
3HIZ"0S%65X[md
sIiWTHk2&0>k}e
O
iy3WET^1q+|(
Mh'6A:Z^;lP-x`
e
htQ%sGl4LWl2
:hhHeoG(Hd%(ct
lp?[Qw'~Z994iy
{SK"
giUI|L4Vz
d0G]+?x|
baR
G0B[sqBr,sXiZ:
o&vi[D4HA/uRwg
^(a(UX40ubapQJ
wh6ZW)]"=\O_:n
pNUapE`t$k#b1K
A`6^)?|'
Xt$vA
M8t!#T(J2#
a
B]FazJBd6#2iY1
\7d-V$O+LQcn8#
6<f-\%GNXKNqU'
W}kY{,N&WU[Gc1
]GPrZn678Vy0c`
O#"o#0zQh^g.('
1Sy).
]5J#rA-S
nk9g
(0{z][,M[
P5vB9[5A1C#h`o
_PC+r1S9$hg%CS
T1p-M6iB9t`-_F
o8RR-V`(|&M#'8
OD-k=SMu}7N$#C
2#qus0),FNMhIq
z$mzQ>kW9;HZ}!
dn#KA
Q>6,35gu
2Uj]_&|TbG"ZNo
1:U)JFjou{SaR9
vq}O}IV}s9:cT#
*[%(1U:lbB.NR!
w{znznAf.'6#UC
6_1m/E0\XaHv`V
q3#yuQ0mY+\pF&
%=,l^vE+]')[gO
AT4cMA5{p<Q'M:
xC9jR'I'Vx=LFQ
+RyVQ6%j{nTz>u
=oVpz+Uw+#CV?Q
KRkH
s'sl$Bk:$
f[}2*>^|q_5_|)
u>l}%*I.O/1ea!
&+joM"k-0`Dz-u
t
3
#`H[/?X!]A
[(p)*,4P>OB.K]
PVv}w#/RAw4#$M
x.S[GjK2Y?-O|A
f5NoAZ\ofTrkg&
DYcij8)]d3?<Yi
F+d#pK>kc7KtoP
7#EPtAe$QSw#%s
[P*I.k?DdM}lZc
jkuL37]OGu`CW\
q.c2%qm"'7r(se
vFwGk5;pj08>5
.DXE
lHhj%8.~
W<}wun]hMym%/<
!}7<JpP`,-h~%^
9UW?L=sEvymmI^
4#w4/E|=}5bQpb
^C
Why is it doing this? I assume some sort of escape character issue or something but I can't figure it out. How can I fix it?
Thanks to #hek2mgl I now have the following function which does not have the same problem:
genpasswd() {
local len=$1
[[ -z $len ]] && len=15
pwgen -syN 1 "$len"
}
Related
I am trying to create a unix shell/bash function to get a specific value from a YAML file.
I don't want to use Python/Ruby or other scripting languages or do not want to install any packages that are not natively available in bash.
The function should take the property name name and yaml file name as input and return the value of the property.
Sample YAML is given below.
---
Action: start
Version: 642
Domains:
Domain:
Name: SanityTest
AppSpaces:
AppSpace:
Name: SanityAppSpace
AppNodes:
AppNode:
Name: SanityAppnode
Applications:
Application:
Name: InstagramTest.application
Version: "1.0"
AppNode:
Name: SanityAppnode_1
Applications:
Application:
Name: InstagramTest.application
Version: "1.0"
I am looking for some function that works like:
DomainName=getValue Domains_Domain[1]_Name /path/my_yaml.yml
AppSpaceName=getValue Domains_Domain[$DomainName]_AppSpaces_AppSpace[1]_Name /path/my_yaml.yml
AppNodeName=getValue Domains_Domain[$DomainName]_AppSpaces_AppSpace[$AppSpaceName]_AppNodes_AppNode[1]_Name /path/my_yaml.yml
AppName=getValue Domains_Domain[$DomainName]_AppSpaces_AppSpace[$AppSpaceName]_AppNodes_AppNode[$AppNodeName]_Applications_Application[1]_Name /path/my_yaml.yml
AppVersion=getValue Domains_Domain[$DomainName]_AppSpaces_AppSpace[$AppSpaceName]_AppNodes_AppNode[$AppNodeName]_Applications_Application[$AppName]_Version /path/my_yaml.yml
I came up with the below code so far, but it is not working as expected. Appreciate any help. Please advise if my approach is wrong and if there is better way.
function getValue {
local ymlFile=$2
local Property=$1
IFS='_' read -r -a props_tokens <<< "${Property}"
local props_index=0
echo "${props_tokens[props_index]}"
CheckingFor="Domains"
currEntity_Index=0
while IFS= read -r line; do
curr_prop="${props_tokens[props_index]}"
curr_prop_Index=0
IFS=':' read -r -a curr_line_props <<< "${line}"
curr_line_prop = ${curr_line_props[0]}
if [ "${props_tokens[props_index]}" == *"["*"]"* ]
then
IFS='[' read -r -a prop_tokens <<< "${props_tokens[props_index]}"
curr_prop=${prop_tokens[0]}
curr_prop_Index=${prop_tokens[1]::-1}
echo "Index processed"
echo $curr_prop
echo $curr_prop_Index
else echo "No Index for this property"
fi
if [ "$curr_line_prop" != "$CheckingFor" ]
then continue
fi
if [ "|Action|Name|Version|" == *"$curr_prop"* ]
then
return curr_line_props[1]
fi
if [ "$curr_prop" == "$CheckingFor" ]
then
if [ "|Domains|AppSpaces|AppNodes|Applications|" == *"$curr_prop"* ]
then
props_index++
case $CheckingFor in
Domains)
CheckingFor="Domain";;
Domain)
CheckingFor="AppSpaces";;
AppSpaces)
CheckingFor="AppSpace";;
AppSpace)
CheckingFor="AppNodes";;
AppNodes)
CheckingFor="AppNode";;
AppNode)
CheckingFor="Applications";;
Applications)
CheckingFor="Application";;
*) echo "$curr_prop - not switched";;
esac
continue
else
if [ "$curr_prop_Index" == 0 ]
then
case $CheckingFor in
Domains)
CheckingFor="Domain";;
Domain)
CheckingFor="AppSpaces";;
AppSpaces)
CheckingFor="AppSpace";;
AppSpace)
CheckingFor="AppNodes";;
AppNodes)
CheckingFor="AppNode";;
AppNode)
CheckingFor="Applications";;
Applications)
CheckingFor="Application";;
*) echo "$curr_prop - not switched";;
esac
props_index++
continue
else
Integer_regex='^[0-9]+$'
if [[ $curr_prop_Index =~ $Integer_regex ]]
then
# Iterate until we get to the nth Item
currEntity_Index++
if [ $currEntity_Index == $curr_prop_Index ]
then
case $CheckingFor in
Domains)
CheckingFor="Domain";;
Domain)
CheckingFor="AppSpaces";;
AppSpaces)
CheckingFor="AppSpace";;
AppSpace)
CheckingFor="AppNodes";;
AppNodes)
CheckingFor="AppNode";;
AppNode)
CheckingFor="Applications";;
Applications)
CheckingFor="Application";;
*) echo "$curr_prop - not switched";;
esac
currEntity_Index=0
else
fi
props_index++
continue
else
# Iterate until the name of the entity match and continue with next property token
# How to handle if the search sipllied into next object?
fi
fi
fi
else
props_index++
continue
fi
done < $ymlFile
return "${props_tokens[props_index]}"
}
We have a 15 year (or so) old script we are trying to figure out and document. We have found some errors in it but one specific log file gives us much headache. and I would love some help figuring it out.
First the function that are run with the question:
#=========================================================#
# Define function removeOldBackupFile. #
#=========================================================#
removeOldBackupFile()
{
#set -x
echo "Removing old backups if they exists." >> "${report}"
local RCLOC=0
spaceBefore=$(getAvailableSpace ${backupDirectory})
timesToWait=60 # Wait a maximum of 10 minutes before bailing
cat ${oldDbContainer} | while read fileName
do
echo "Old file exists. Removing ${fileName}." >> "${report}"
removeFileIfExist "${fileName}"
RC=$?
echo "Resultcode for removing old backup is: RC=$RC." >> "${report}"
RCLOC=$(($RC+$RCLOC))
spaceAfter=$(getAvailableSpace ${backupDirectory})
# Wait for the OS to register that the file is removed
cnt=0
while [ $spaceAfter -le $spaceBefore ]; do
cnt=$((cnt+1))
if [ $cnt -gt $timesToWait ]; then
echo "Waited too long for space in ${backupDirectory}" | tee -a "${report}"
RCLOC=$(($RCLOC+1))
return $RCLOC
fi
sleep 10
spaceAfter=$(getAvailableSpace ${backupDirectory})
done
done
return $RCLOC
}
The place where this function is ran looks as follows:
#=========================================================#
# Remove old backupfiles if any exist. #
#=========================================================#
removeOldBackupFile
RC=$?
RCSUM=$(($RC+$RCSUM))
We have identified that the if condition is a bit wrong and the while loops would not work as intended if there are multiple files.
But what bothers us is output from a log file:
...
+ cnt=61
+ '[' 61 -gt 60 ']'
+ echo 'Waited too long for space in /<redacted>/backup'
+ tee -a /tmp/maintenanceBackupMessage.70927
Waited too long for space in /<redacted>/backup
+ RCLOC=1
+ return 1
+ return 0
+ RC=0
+ RCSUM=0
...
As seen in the log output after the inner loop have ran 60 times and ending it returns 1 as expected.. BUT! it also have return 0 after!? Why is it also returning 0?
We are unable to figure out the double returns... Any help appriciated
The first return executes in the subshell started by the pipe cat ${oldDbContainer} | while .... The second return is from return $RCLOC at the end of the function. Get rid of the useless use of cat:
removeOldBackupFile()
{
#set -x
echo "Removing old backups if they exists." >> "${report}"
local RCLOC=0
spaceBefore=$(getAvailableSpace ${backupDirectory})
timesToWait=60 # Wait a maximum of 10 minutes before bailing
while read fileName
do
...
done < ${oldDbContainer}
return $RCLOC
}
I want to Analyse a logfile for specific Errors.
Therefore i want to be able to loop through the last x lines of the files and check every line with a specific REGEX Pattern and then define a specific return value.
The logfile Looks in case of success as follows at the Moment when i want to check it.
….
sftp> get blahblah/blahblah
sftp> bye
In case of an Error there is something between the two sftp lines.
What i allready tried is to solve the Problem with a specific regex which worked fine on some online Regex testers but couldn´t get it to work in ksh.
My current Approach is the following
LOG_FIL="test_log"
MODE="${1}"
check_log_file() {
ERRNBR=${1}
REGEX=${2}
TAIL=${3}
RETURN="0"
echo "ERRNBR = ${ERRNBR}"
echo "REGEX = ${REGEX}"
echo "TAIL = ${TAIL}"
while read line; do
echo "${line}"
if [[ "${line}" =~ ${REGEX} ]]; then
RETURN="0"
echo "bin hier"
else
RETURN=${ERRNBR}
echo "bin wo anders"
break
fi
done <<<$(tail -${TAIL} ${LOG_FIL})
echo "${RETURN}"
return ${RETURN}
}
echo "sftp> get cwi/cdk_final*" >> ${LOG_FIL}
if [ "${MODE}" == "1" ]; then
echo "Werner ist der beste" >>${LOG_FIL}
fi
check_log_file "22" "^(sftp> ).*$" "1"
echo "$?"
echo "sftp> bye" >> ${LOG_FIL}
check_log_file "21" "((sftp> ).*|(sftp> bye))" "2"
echo "$?"
The results i get are the following
edv> sh cdk_test4sftp.sh 1
ERRNBR = 22
REGEX = ^(sftp> ).*$
TAIL = 1
Werner ist der beste
bin wo anders
22
22
ERRNBR = 21
REGEX = ((sftp> ).*|(sftp> bye))
TAIL = 2
Werner ist der beste sftp> bye
bin hier
0
0
What i hoped to achieve was that the Output coming from the tail command would be seperated. So that i ccould test each line individually.
Your second regex:
((sftp> ).*|(sftp> bye))
Matches the following line, which is why your function returns 0:
Werner ist der beste sftp> bye
Since you want to match the following pattern on each line:
sftp> get blahblah/blahblah
sftp> bye
Your regex should look more like the first one you used to match:
^(sftp> ).*$
(function(){})();
window.getJetPaths=function(b){var c={knockout:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/knockout/knockout-3.4.0","knockout.mapping":"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/knockout/knockout.mapping-latest",jquery:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/jquery/jquery.min",jqueryui:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/jquery/jquery-ui-1.12.0.custom.min","jqueryui-amd":"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/jquery/jqueryui-amd-1.12.0.min",promise:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/es6-promise/es6-promise.min",
require:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/require/require",hammerjs:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/hammer/hammer-2.0.8.min",ojs:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/oj/v4.2.0/min",ojL10n:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/oj/v4.2.0/ojL10n",ojtranslations:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/oj/v4.2.0/resources",ojdnd:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/dnd-polyfill/dnd-polyfill-1.0.0.min",
signals:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/js-signals/signals.min",customElements:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/webcomponents/custom-elements.min",crossroads:null,history:null,text:"/emsaasui/uifwk/libs/4.2.0-41239.001032001/js/oraclejet/js/libs/require/text"},a;for(a in c)c[a]?b[a]=c[a]:delete b[a];return b};
window.getJetBundles=function(){return window.isDevMode?[]:"customElements hammerjs jqueryui jqueryui-amd jqueryui-amd/data jqueryui-amd/disable-selection jqueryui-amd/focusable jqueryui-amd/ie jqueryui-amd/keycode jqueryui-amd/plugin jqueryui-amd/position jqueryui-amd/safe-active-element jqueryui-amd/safe-blur jqueryui-amd/scroll-parent jqueryui-amd/tabbable jqueryui-amd/unique-id jqueryui-amd/version jqueryui-amd/widget jqueryui-amd/widgets/draggable jqueryui-amd/widgets/mouse jqueryui-amd/widgets/sortable knockout knockout.mapping ojL10n ojdnd ojs/internal-deps/dvt/DvtAxis ojs/internal-deps/dvt/DvtChart ojs/internal-deps/dvt/DvtDiagram ojs/internal-deps/dvt/DvtGauge ojs/internal-deps/dvt/DvtLegend ojs/internal-deps/dvt/DvtNBox ojs/internal-deps/dvt/DvtOverview ojs/internal-deps/dvt/DvtPanZoomCanvas ojs/internal-deps/dvt/DvtPictoChart ojs/internal-deps/dvt/DvtSubcomponent ojs/internal-deps/dvt/DvtTagCloud ojs/internal-deps/dvt/DvtThematicMap ojs/internal-deps/dvt/DvtTimeAxis ojs/internal-deps/dvt/DvtTimeComponent ojs/internal-deps/dvt/DvtTimeline ojs/internal-deps/dvt/DvtToolkit ojs/internal-deps/dvt/DvtTreeView ojs/ojaccordion ojs/ojanimation ojs/ojarraydatagriddatasource ojs/ojarraypagingdatasource ojs/ojarraytabledatasource ojs/ojbutton ojs/ojchart ojs/ojcheckboxset ojs/ojcollapsible ojs/ojcollectiondatagriddatasource ojs/ojcollectionpagingdatasource ojs/ojcollectiontabledatasource ojs/ojcollectiontreedatasource ojs/ojcomponentcore ojs/ojcomponents ojs/ojconveyorbelt ojs/ojcore ojs/ojcube ojs/ojcustomelement ojs/ojdatacollection-common ojs/ojdatacollection-utils ojs/ojdatagrid ojs/ojdatagrid-model ojs/ojdataprovider ojs/ojdataprovideradapter ojs/ojdatasource-common ojs/ojdatetimepicker ojs/ojdefer ojs/ojdiagram ojs/ojdialog ojs/ojdomscroller ojs/ojdvt-base ojs/ojeditablevalue ojs/ojeventtarget ojs/ojfilmstrip ojs/ojflattenedtreedatagriddatasource ojs/ojflattenedtreetabledatasource ojs/ojgauge ojs/ojindexer ojs/ojinputnumber ojs/ojinputtext ojs/ojjquery-hammer ojs/ojjsontreedatasource ojs/ojkeyset ojs/ojknockout ojs/ojknockout-model ojs/ojknockout-validation ojs/ojkoshared ojs/ojlabel ojs/ojlegend ojs/ojlistdataproviderview ojs/ojlistview ojs/ojmasonrylayout ojs/ojmenu ojs/ojmessaging ojs/ojmodel ojs/ojmodule ojs/ojmoduleanimations ojs/ojnavigationlist ojs/ojnbox ojs/ojoffcanvas ojs/ojoptgroup ojs/ojoption ojs/ojpagingcontrol ojs/ojpagingcontrol-model ojs/ojpagingdatagriddatasource ojs/ojpagingtabledatasource ojs/ojpictochart ojs/ojpopup ojs/ojpopupcore ojs/ojprogress ojs/ojprogressbar ojs/ojpulltorefresh ojs/ojradiocheckbox ojs/ojradioset ojs/ojrouter ojs/ojrowexpander ojs/ojselectcombobox ojs/ojslider ojs/ojsunburst ojs/ojswipetoreveal ojs/ojswitch ojs/ojtable ojs/ojtable-model ojs/ojtabs ojs/ojtagcloud ojs/ojtemplateengine ojs/ojthematicmap ojs/ojtime-base ojs/ojtimeline ojs/ojtoolbar ojs/ojtouchproxy ojs/ojtrain ojs/ojtree ojs/ojtree-model ojs/ojtreemap ojs/ojvalidation ojs/ojvalidation-base ojs/ojvalidation-datetime ojs/ojvalidation-number ojtranslations/nls/localeElements ojtranslations/nls/ojtranslations promise signals text".split(" ")};
window.getUifwkBundles=function(){return window.isDevMode?[]:"uifwk/js/util/ajax-util uifwk/js/util/df-util uifwk/js/util/logging-util uifwk/js/sdk/logging-feature-usage-util uifwk/js/util/message-util uifwk/js/util/mobile-util uifwk/js/util/preference-util uifwk/js/util/screenshot-util uifwk/js/util/typeahead-search uifwk/js/util/usertenant-util uifwk/js/util/zdt-util uifwk/js/util/uifwk-preload-util uifwk/js/sdk/context-util uifwk/js/sdk/menu-util uifwk/js/widgets/aboutbox/js/aboutbox uifwk/js/widgets/brandingbar/js/brandingbar uifwk/js/widgets/datetime-picker/js/datetime-picker uifwk/js/widgets/navlinks/js/navigation-links uifwk/js/widgets/timeFilter/js/timeFilter uifwk/js/widgets/widgetselector/js/widget-selector uifwk/js/widgets/tooltip/tooltip uifwk/js/sdk/widget-selector-util text!uifwk/js/widgets/aboutbox/html/aboutbox.html text!uifwk/js/widgets/navlinks/html/navigation-links.html text!uifwk/js/widgets/brandingbar/html/brandingbar.html text!uifwk/js/widgets/timeFilter/html/timeFilter.html text!uifwk/js/widgets/datetime-picker/html/datetime-picker.html text!uifwk/js/widgets/widgetselector/html/widget-selector.html".split(" ")};
//# sourceMappingURL=jetLoader.map
This is the file content here i want to replace window.getJetPaths whole defenition with a return statement only.
It is giving errors for not able to replace "/,{,}"
Below is my script:
#!/bin/bash
filePath='D:/emsaasui/uifwk/libs/4.2.0-41239/js/jetLoader.js'
line=$(awk '/getJetPaths/{print NR}' $filePath)
str=$(tail -n +$line $filePath)
#echo $str
tempStr=""
count=0
for (( i=0 ; i < ${#str} ; i++ )) {
arr[$i]=${str:i:1}
#printf "%s\n" "${arr[#]}"
if [[ ${arr[$i]} = '{' ]]
then
count=$((count+1))
echo $count
fi
if [[ $count -eq "1" || $count -eq "2" ]]
then
tempStr=${tempStr}${arr[$i]}
fi
if [[ ${arr[$i]} = '}' ]]
then
count=$((count-1))
if [[ $count = 0 ]]
then
break
fi
fi
}
echo $tempStr
sed 's/\\$tempStr{\([^}]*\)}/\1 %/g'
Thanks in advance.
Simplest case - it's all on one line anyway. Just do a literal substitution.
Assuming file is named x -
sed 's/window.getJetPaths=function.*return b};/window.getJetPaths=function(b){return b};/' x > y
Watch the metacharacters. Sed gives special meaning to those, and they don't match unless carefully qualified, or included in a broad match.
This is my script:
#!/bin/bash
JOB_NUM=4
function checkJobNumber() {
if (( $JOB_NUM < 1 || $JOB_NUM > 16 )); then
echo "pass"
fi
}
...
checkJobNumber
...
When I try to launch the script I get the message:
./script.sh line 49: ((: < 1 || > 16 : syntax error: operand expected (error token is "< 1 || > 16 ")
(Please notice the spaces in the error message)
I really don't understand what the problem is. If I do the evaluation manually at the command line, it works.
Also, I tried different evaluations like if [[ "$JOB_NUM" -lt 1 -o "$JOB_NUM" gt 16 ]];... still no success.
UPDATE: As suggested I made few more attempts in the rest of the code outside the function call, and I found the problem.
My variables declaration was actually indented this way:
JOB_NUM= 4
THREAD_NUM= 8
.....
VERY_LONG_VAR_NAME= 3
and apparently this hoses the evaulation. BAH! It always worked for me before, so why doesn’t it now?
If I delete the white spaces, the evaluation works:
JOB_NUM=4
THREAD_NUM=8
....
VERY_LONG_VAR_NAME=3
OK I officially hate bash . . . sigh :(
this will work fine
#!/bin/bash
JOB_NUM=7
function checkJobNumber() {
if [ $JOB_NUM -lt 0 ] || [ $JOB_NUM -gt 16 ] ; then
echo "true"
else
echo "false"
fi
}
checkJobNumber
And if you want to check variable during tests you can write in your bash :
set -u
this will generate a message like "JOB_NUM: unbound variable" if variable is not well set