C++ Messagebox in Chinese [duplicate] - winapi

Question

This question already has answers here:
Why does my simple C++ GUI application show a message box in Chinese?
(3 answers)
Why does message box in C++ show chinese message [duplicate]
(3 answers)
Closed 6 years ago.
ConsoleApplication.cpp
// ConsoleApplication2.cpp : Defines the entry point for the console application.
//
#include "stdafx.h"
int main()
{
std::cout << "Hello World" << std::endl;
MessageBox(0, LPTSTR("Text Here"), LPTSTR("Text Here"), MB_OK);
std::cin.clear();
std::cout << "Press Enter to continue" << std::endl;
std::cin.ignore(32767, '\n');
std::cin.get();
return 0;
}
stdafx.h
// stdafx.h : include file for standard system include files,
// or project specific include files that are used frequently, but
// are changed infrequently
//
#pragma once
#include "targetver.h"
#include <stdio.h>
#include <tchar.h>
#include <iostream>
#include <Windows.h>
#include <sstream>
Whenever I run the MessageBox code, it comes out in Chinese characters.
The code is above.

Answer 1

Your LPTSTR type-cast is wrong. When compiling with UNICODE defined, MessageBox() resolves to MessageBoxW(), and LPTSTR resolves to wchar*, so you are really doing this:
MessageBoxW(0, (wchar*)"Text Here", (wchar*)"Text Here", MB_OK);
You are telling the compiler to type-cast narrow strings as if they were wide strings. The narrow string "Text Here" consists of bytes 54 65 78 74 20 48 65 72 65. When those same bytes are interpreted as a wide string, they produce the Chinese string "敔瑸䠠牥e".
If you are going to use TCHAR-based APIs, like MessageBox(), you need to use the TEXT() macro when passing char/string literals to them at compile-time, eg:
MessageBox(0, TEXT("Text Here"), TEXT("Text Here"), MB_OK);
When UNICODE is defined, TEXT() compiles a literal as wide. When UNICODE is not defined, TEXT() compiles a literal as narrow.
Otherwise, do not rely on TCHAR-based APIs at all. Use Ansi/Unicode versions explicitly, eg:
MessageBoxA(0, "Text Here", "Text Here", MB_OK);
MessageBoxW(0, L"Text Here", L"Text Here", MB_OK);
On a side note: your call to cin.ignore() should use std::numeric_limits instead of hard-coding the length:
#include <limits>
std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');