I have this problem in my code, where I cannot submit a signup form in jsp. Here are the code intervening in the signup operation.
User.java
#Entity
#Table(name = "user", catalog = "spring_abc", uniqueConstraints = {#UniqueConstraint(columnNames = "email"),
#UniqueConstraint(columnNames = "username")})
public class User implements java.io.Serializable {
public static final String ROLE_ADMIN = "admin";
public static final String ROLE_MEMBER = "member";
private static final long serialVersionUID = 7376961072110620611L;
private Integer id;
private Long commentCount;
private Date createAt;
private String description;
#Email(message = "Entrez le format de l'email correct")
private String email;
private long number;
private String password;
public void setDepartement(String departement) {
this.departement = departement;
}
private long points;
private String role;
#Size(max = 60, message = "Pas plus de soixante caractères")
private String signature;
private Long topicCount;
#Size(max = 60, message = "Pas plus de soixante caractères")
private String twitter;
private Date updateAt;
#Pattern(regexp = "^(?!_)(?!.*?_$)[A-Za-z0-9|_]{3,9}", message = "Nom d'utilisateur, ne peut pas commencer ou se terminer par un trait de soulignement")
private String username;
private Set<Follow> followsForFollowerId = new HashSet<Follow>(0);
private Set<Notification> notifications = new HashSet<Notification>(0);
private Set<Topic> topics = new HashSet<Topic>(0);
private Set<Comment> comments = new HashSet<Comment>(0);
private Set<Focus> focuses = new HashSet<Focus>(0);
private Set<Collection> collections = new HashSet<Collection>(0);
private Set<Follow> followsForFollowingId = new HashSet<Follow>(0);
private Set<Comment> likeComments = new HashSet<Comment>();
The methode signup the service Part.
#Transactional
public User signup(User user, String password1, Errors errors) {
if (errors.hasErrors()) {
return null;
}
String username = user.getUsername();
String password = user.getPassword();
String email = user.getEmail();
if (userRepo.findOneByUsername(username) != null) {
errors.rejectValue("username", "username", "Nom d'utilisateur déjà enregistré");
} else if (userRepo.findOneByEmail(email) != null) {
errors.rejectValue("email", "email", "E-mail est déjà enregistré");
} else if (!password.equals(password1)) {
errors.rejectValue("password", "password", "Les mots de passe ne se correspondent pas");
}
if (errors.hasErrors()) {
return null;
}
user.setPassword(EncryptUtil.encryptUsernameAndPassword(username, password));
user.setCreateAt(new Date());
return userRepo.save(user);
}
Controller Account.java
#RequestMapping(value = "/signup", method = RequestMethod.POST)
public String singupAction(#Validated User user,
Errors erros,
String password1,
RedirectAttributes attributese,
HttpServletRequest request) {
User signinUser = userServ.signup(user, password1, erros);
if (erros.hasErrors()) {
attributese.addFlashAttribute("user", user);
attributese.addFlashAttribute("error", erros.getAllErrors());
return "redirect:/account/signup";
}
request.getSession().setAttribute("user", signinUser);
attributese.addFlashAttribute("msg", "Vous êtes inscrit avec succès");
return "redirect:/";
}
Signup.jsp, The problem appears when i try to validate information.
<form action="${x}/account/signup" data-toggle="validator" role="form" method="POST">
<input class="form-control" data-error="S'il vous plaît entrer une adresse email valide" placeholder="E-mail" type="email" id="email" name="email" value="${user.email}" />
<input class="form-control" id="username" data-error="Entre 6 et 18 caractères" pattern="^[_A-z0-9]{6,18}$" placeholder="Votre username" type="text" name="username" value="${user.username}" />
<input class="form-control" data-minlength="6" type="password" name="password" id="password" placeholder="Mot de passe" data-error="Entre 6 et 18 caractères" />
<input type="submit" class="btn btn-info btn-block" value="S'inscrire">
The stack I'm getting doesn't make any sense to me. It doesn't point out the problem
org.apache.jasper.JasperException: javax.el.ELException: java.lang.IllegalAccessException: Class javax.el.BeanELResolver can not access a member of class java.util.Collections$UnmodifiableCollection with modifiers "public"
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:432)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:492)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:378)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
Caused by: javax.el.ELException: java.lang.IllegalAccessException: Class javax.el.BeanELResolver can not access a member of class java.util.Collections$UnmodifiableCollection with modifiers "public"
at javax.el.BeanELResolver.invokeMethod(BeanELResolver.java:742)
at javax.el.BeanELResolver.invoke(BeanELResolver.java:470)
at javax.el.CompositeELResolver.invoke(CompositeELResolver.java:257)
You need to add getters and setters in your entity for each field.
e.g. private long number;
Should have defined following in your entity.
public long getNumber(){ return this.number;}
public void setNumber(long number){ this.number = number; }
from your stacktrace it is clear that it is trying to access fields with public getter method but it couldn't find it so thrown exception.
Related
So my issue is a bit different from others. The error that it is throwing is not a field name but rather the input in a form. I've never encountered this error before
Error. The contents of '' is what I key for password
org.springframework.beans.NotReadablePropertyException: Invalid
property 'Yijian#123' of bean class [com.Alex.UserPackage.User]: Bean
property 'Yijian#123' is not readable or has an invalid getter method:
Does the return type of the getter match the parameter type of the
setter? at
org.springframework.beans.AbstractNestablePropertyAccessor.getPropertyValue(AbstractNestablePropertyAccessor.java:622)
~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE] at
org.springframework.beans.AbstractNestablePropertyAccessor.getPropertyValue(AbstractNestablePropertyAccessor.java:612)
~[spring-beans-5.2.7.RELEASE.jar:5.2.7.RELEASE] at
org.springframework.validation.AbstractPropertyBindingResult.getActualFieldValue(AbstractPropertyBindingResult.java:104)
~[spring-context-5.2.7.RELEASE.jar:5.2.7.RELEASE]
Entity class
#Entity
#ValidPassword
public class User {
#Pattern(regexp="[a-zA-Z]+", message = "Enter letters only!")
private String firstName;
#Pattern(regexp="[a-zA-Z]+", message = "Enter letters only!")
private String lastName;
private String password;
private String matchingPassword;
private String passportNumber;
public String getPassword() {
return password;
}
public void setPassword(String password) {
this.password = password;
}
public String getMatchingPassword() {
return matchingPassword;
}
public void setMatchingPassword(String matchingPassword) {
this.matchingPassword = matchingPassword;
}
}
#ValidPassword custom annotation. The error started to occur after I used the getters for password and matchingPassword
private String message;
#Override
public boolean isValid(User user, ConstraintValidatorContext context) {
String password = user.getPassword();
String matchingPassword = user.getMatchingPassword();
if (password== null || matchingPassword == null) {
return false;
}
System.out.println("PASSWORDS: " + password + matchingPassword);
boolean flag = Pattern.matches("^(?=.*?[A-Z])(?=.*?[a-z])(?=.*?[0-9])(?=.*?[#?!#$%^&*-]).{8,}$", password);
boolean flag1 = password.equals(matchingPassword);
if ( !flag1 ) {
message = "Passwords do not match!";
}
context.disableDefaultConstraintViolation();
context.buildConstraintViolationWithTemplate(message)
.addPropertyNode(password).addConstraintViolation();
return flag && flag1;
}
//Show default message if no special message is set
#Override
public void initialize(ValidPassword validPassword) {
message = validPassword.message();
}
Form password portion
<div class = "row">
<div class="col-sm-6 form-group">
<label>Password : </label> <Input type="password"
th:field="*{password}" th:required="required" class="form-control" />
<p th:if="${#fields.hasErrors('password')}"
th:errors="*{password}" class="alert alert-danger"></p>
</div>
You are passing the property value instead of the property name to addPropertyNode(password).
Replace the following:
context.buildConstraintViolationWithTemplate(message)
.addPropertyNode(password).addConstraintViolation();
with:
context.buildConstraintViolationWithTemplate(message)
.addPropertyNode("password").addConstraintViolation();
I want to create a controller with #ModelAttribute which allows me to insert to my Customer table data. I've done one with the employee but how can I save two hibernate mapped entities in JSP form with #ModelAttribute? also, I'm using basic generated repositories with JpaRepository interface. I want to make those two entities in relation saving it.
I tried to make #ModelAttribute JSP forms, but I don't know how to set other table entity in relation.
Employee
#Entity
#Table
public class Employee {
#Id
#GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;
private String firstName;
private String lastName;
#Digits(integer = 10, fraction = 0, message = "Must be a digit")
private Integer age;
private BigDecimal salary;
#Temporal(TemporalType.DATE)
#DateTimeFormat(pattern = "yyyy-MM-dd")
#PastOrPresent(message = "Date must be past or present")
private Date birthDate;
#Temporal(TemporalType.DATE)
#DateTimeFormat(pattern = "yyyy-MM-dd")
#PastOrPresent(message = "Date must be past or present")
private Date hireDate;
private boolean sex; //false - woman, true - man
#OneToOne(mappedBy = "employee")
private Address address;
public Employee() {
}
public Employee(String firstName, String lastName, Integer age, BigDecimal salary, Date birthDate, Date hireDate,
boolean sex) {
this.firstName = firstName;
this.lastName = lastName;
this.age = age;
this.salary = salary;
this.birthDate = birthDate;
this.hireDate = hireDate;
this.sex = sex;
}
public Long getId() {
return id;
}
public void setId(Long id) {
this.id = id;
}
public String getFirstName() {
return firstName;
}
public void setFirstName(String firstName) {
this.firstName = firstName;
}
public String getLastName() {
return lastName;
}
public void setLastName(String lastName) {
this.lastName = lastName;
}
public Integer getAge() {
return age;
}
public void setAge(Integer age) {
this.age = age;
}
public BigDecimal getSalary() {
return salary;
}
public void setSalary(BigDecimal salary) {
this.salary = salary;
}
public Date getBirthDate() {
return birthDate;
}
public void setBirthDate(Date birthDate) {
this.birthDate = birthDate;
}
public Date getHireDate() {
return hireDate;
}
public void setHireDate(Date hireDate) {
this.hireDate = hireDate;
}
public boolean isSex() {
return sex;
}
public void setSex(boolean sex) {
this.sex = sex;
}
public Address getAddress() {
return address;
}
public void setAddress(Address address) {
this.address = address;
}
}
Address
#Entity
#Table
public class Address {
#Id
#GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;
private String country;
private String city;
private String street;
private Integer houseNumber;
private Integer local;
private String postalCode;
#OneToOne
#JoinColumn(name = "employee_id")
private Employee employee;
public Address() {
}
public Address(String country, String city, String street, Integer houseNumber, Integer local, String postalCode) {
this.country = country;
this.city = city;
this.street = street;
this.houseNumber = houseNumber;
this.local = local;
this.postalCode = postalCode;
}
public Long getId() {
return id;
}
public void setId(Long id) {
this.id = id;
}
public String getCountry() {
return country;
}
public void setCountry(String country) {
this.country = country;
}
public String getCity() {
return city;
}
public void setCity(String city) {
this.city = city;
}
public String getStreet() {
return street;
}
public void setStreet(String street) {
this.street = street;
}
public Integer getHouseNumber() {
return houseNumber;
}
public void setHouseNumber(Integer houseNumber) {
this.houseNumber = houseNumber;
}
public Integer getLocal() {
return local;
}
public void setLocal(Integer local) {
this.local = local;
}
public String getPostalCode() {
return postalCode;
}
public void setPostalCode(String postalCode) {
this.postalCode = postalCode;
}
public Employee getEmployee() {
return employee;
}
public void setEmployee(Employee employee) {
this.employee = employee;
}
}
Controller
#Controller
#RequestMapping("/user")
public class UserController {
#Autowired
public EmployeeService employeeService;
#Autowired
public AddressService addressService;
#GetMapping("/add")
public String addUser(Model model) {
model.addAttribute("employee", new Employee());
return "user/addEmployee";
}
#PostMapping("/add")
public String postAddUser(#Valid #ModelAttribute("employee") Employee employee, BindingResult bs) {
if(bs.hasErrors()) {
return "user/addAddress";
} else {
employeeService.saveOrUpdate(employee);
return "user/success";
}
}
#GetMapping("/address/add")
public String addAddress(Model model) {
List<Employee> employees = employeeService.findAll();
model.addAttribute("employees", employees);
model.addAttribute("address", new Address());
return "user/addAddress";
}
#PostMapping("/address/add")
public String postAddAddress(#ModelAttribute("address") Address address, #RequestParam("employee_id") Long id) {
Employee employee = employeeService.findById(id);
address.setEmployee(employee);
employee.setAddress(address);
addressService.saveOrUpdate(address);
employeeService.saveOrUpdate(employee);
return "user/addAddress";
}
}
addAddress.jsp
<%# taglib prefix="form" uri="http://www.springframework.org/tags/form"%>
<%# taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"%>
<html>
<head></head>
<body>
<h2>Address Form</h2>
<form:form action="/user/address/add" method="POST" modelAttribute="address">
City: <form:input path="city"/><br>
Street: <form:input path="street" /><br>
House Number: <form:input path="houseNumber"/><br>
Local: <form:input path="local"/><br>
Postal Code: <form:input path="postalCode" /><br>
<select name="employee_id">
<c:forEach var="employee" items="${employees}">
<option value="${employee.id}">${employee.id} ${employee.firstName} ${employee.lastName}</option>
</c:forEach>
</select><br>
<input type="submit" />
</form:form>
</body>
</html>
addEmployee.jsp
<%# taglib prefix="form" uri="http://www.springframework.org/tags/form"%>
<%# taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"%>
<html>
<head></head>
<body>
<h2>Employee Form</h2>
<form:form action="/user/add" method="POST" modelAttribute="employee">
First Name: <form:input path="firstName"/> <form:errors path="firstName"></form:errors><br>
Last Name: <form:input path="lastName"/> <form:errors path="lastName"></form:errors><br>
Age: <form:input path="age" /> <form:errors path="age" type="number"></form:errors><br>
Salary: <form:input path="salary" type="number"/> <form:errors path="salary"></form:errors><br>
Birth Date<form:input path="birthDate" type="date"/> <form:errors path="birthDate"></form:errors><br>
Hire Date<form:input path="hireDate" type="date" /> <form:errors path="hireDate"></form:errors><br>
Female: <form:radiobutton path="sex" value="0" /> Male: <form:radiobutton path="sex" value="1" /><br>
<input type="submit" value="Wyślij"/>
</form:form>
</body>
</html>
I need to create a result in the database with those two entities with a relationship using #ModelAttribute. Is it possible?
If I understood your problem correctly,
To set the associated entity -
you need to have unique value to identify the entity (for ex. Employeeid for employees),
fetch the details for the Employeeid, this will result in employee entity object
set the employee entity object into customer entity object
similarly for Invoices.
then save customer entity object.
Check - https://thoughts-on-java.org/ultimate-guide-association-mappings-jpa-hibernate/
You could try to combine them something like this:
<form:form action="add" method="POST" modelAttribute="employee">
<form:hidden path="id"/>
First Name: <form:input path="firstName"/> <form:errors path="firstName"></form:errors><br>
Last Name: <form:input path="lastName"/> <form:errors path="lastName"></form:errors><br>
Age: <form:input path="age" /> <form:errors path="age" type="number"></form:errors><br>
Salary: <form:input path="salary" type="number"/> <form:errors path="salary"></form:errors><br>
Birth Date<form:input path="birthDate" type="date"/> <form:errors path="birthDate"></form:errors><br>
Hire Date<form:input path="hireDate" type="date" /> <form:errors path="hireDate"></form:errors><br>
Female: <form:radiobutton path="sex" value="0" /> Male: <form:radiobutton path="sex" value="1" /><br>
<form:form action="add" method="POST" modelAttribute="address">
<form:hidden path="addressId"/> // <- need to rename in your entity Address class
City: <form:input path="city"/><br>
Street: <form:input path="street" /><br>
House Number: <form:input path="houseNumber"/><br>
Local: <form:input path="local"/><br>
Postal Code: <form:input path="postalCode" /><br>
<select name="employee_id">
<c:forEach var="employee" items="${employees}">
<option value="${employee.id}">${employee.id} ${employee.firstName} ${employee.lastName}</option>
</c:forEach>
</select><br>
<input type="submit" value="Submit"/>
</form:form>
<input type="submit" />
</form:form>
In controller method:
#PostMapping("/add")
public String postAdd(#ModelAttribute("employee") #Valid Employee employee
BindingResult empBindingResult,
#ModelAttribute("address") Address address,
BindingResult addressBindingResult) {
// other code
}
Although I didn't use radiobutton and selector elements in this combination, the rest of code should work fine.
Spring MVC Multiple ModelAttribute On the Same Form
Multiple modelattributes in a JSP with Spring
I have a small problem with my form in spring, it is a simple form with title, username and password, validation works as if I try to submit an empty form I get an error however if I input values in and submit the form, it is submitted but it displays that values inserted are "null".
Domain:
#Entity
public class User {
#Id
#GeneratedValue(strategy = GenerationType.AUTO)
private Long id;
private String title;
#NotNull
#Size(min=2, max=30)
private String username;
#NotNull
#Size(min=6)
private String password;
public String getTitle() { return title; }
public String getUsername() { return username; }
public String getPassword() { return password; }
public Long getId() { return id; }
public void setId(Long id) {
this.id = id;
}
public void setUsername(String username) { this.username = username; }
public void setPassword(String password) { this.password = password; }
public void setTitle(String title) { this.title = title; }
public List<Note> getNotes() {
return notes;
}
#OneToMany
private List<Note> notes = new ArrayList<Note>();
}
Form:
<form action="#" th:action="#{/create/user}" th:object="${user}" method="post">
<input type="hidden" th:field="*{id}" />
<p>Title: <input type="text" th:field="*{title}" /></p>
<p>Username: <input type="text" th:field="*{username}" /></p>
<p>Password: <input type="password" th:field="*{password}" /></p>
<p><input type="submit" value="Submit" /></p>
</form>
<div class="form-group">
<ol class="list-group">
<li class="list-group-item list-group-item-info" th:each="user : ${user}">
<span th:text=" ${user.title} + ${user.username} + ${user.password} "></span>
delete
</li>
</ol>
</div>
Controller:
#Controller
public class UserController {
#Autowired
protected UserService userService;
#RequestMapping(value = "/create/user", method = RequestMethod.POST)
public String createUser(Model model, #Valid #ModelAttribute("user") User user, BindingResult bindingResult){
if(bindingResult.hasErrors()){
model.addAttribute("user", user);
model.addAttribute("users", userService.findAll());
model.addAttribute("type", "danger");
model.addAttribute("message", "Please fill in all the fields" +
"Username needs to be at least 2 characters" +
"Passwords needs to contain at least 6 characters");
return "user";
}
userService.save(user);
model.addAttribute("user", new User());
model.addAttribute("cards", userService.findAll());
model.addAttribute("type", "success");
model.addAttribute("message", "A new user has been added");
return "user";
}
If any additional code in needed please let me know, I am still newbie in Spring
Found an error by reviewing the code:
In the form when outputting registered users it was:
<li class="list-group-item list-group-item-info" th:each="user : ${user}">
While it should be:
<li class="list-group-item list-group-item-info" th:each="user : ${users}">
I have a #SessionScoped ManagedBean that I've injected into a #RequestScoped to access the user stored in the session. My code is working I just want to know if I'm using a good practice, if not can you tell me what's wrong please? Because I'm new to JSF and I don't want to learn some bad coding from the beginning, thank you very much in advance.
My Entity Utilisateur :
#Entity
public class Utilisateur {
#Id
#GeneratedValue( strategy = GenerationType.IDENTITY )
private Long id;
#NotNull( message = "Veuillez saisir une adresse email" )
#Pattern( regexp = "([^.#]+)(\\.[^.#]+)*#([^.#]+\\.)+([^.#]+)", message = "Merci de saisir une adresse mail valide" )
private String email;
#Column( name = "mot_de_passe" )
#NotNull( message = "Veuillez saisir un mot de passe" )
#Pattern(regexp = ".*(?=.{8,})(?=.*\\d)(?=.*[a-z])(?=.*[A-Z]).*", message = "Le mot de passe saisi n'est pas assez sécurisé")
private String motDePasse;
#NotNull( message = "Veuillez saisir un nom d'utilisateur" )
#Size( min = 3, message = "Le nom d'utilisateur doit contenir au moins 3 caractères" )
private String nom;
#Column( name = "date_inscription" )
private Timestamp dateInscription;
//getters .. setters..
}
My Entity Ferme :
#Entity
public class Ferme {
#Id
#GeneratedValue( strategy = GenerationType.IDENTITY )
#Column( name = "id_ferme" )
private Long id_ferme;
#Column( name = "nom_ferme" )
private String nom_ferme;
#ManyToOne
#JoinColumn( name = "utilisateur_id" )
private Utilisateur utilisateur;
//getters .. setters..
}
My #Statless DAO :
#Stateless
public class UtilisateurDao {
#PersistenceContext( unitName = "myBD_PU" )
private EntityManager em;
public List<Ferme> lister( Utilisateur user) throws DAOException {
try {
TypedQuery<Ferme> query = em.createQuery( "SELECT u FROM Ferme u WHERE u.utilisateur = :userid", Ferme.class );
query.setParameter("userid", user);
return query.getResultList();
} catch ( Exception e ) {
throw new DAOException( e );
}
}
}
My LoginBean :
#ManagedBean
#SessionScoped
public class LoginBean implements Serializable {
private static final long serialVersionUID = 1L;
private String email,mdp;
private Utilisateur user;
private boolean LoggedIn;
#EJB
UtilisateurDao utilisateurDao;
// getters .. setters
public String authentification() {
if (utilisateurDao.login(email, mdp) != null) {
user = utilisateurDao.login(email, mdp);
LoggedIn = true;
return "listeFermes.xhtml?faces-redirect=true";
}
LoggedIn = false;
FacesMessage message = new FacesMessage( "E-mail ou Mot de passe incorrecte!" );
FacesContext.getCurrentInstance().addMessage( null, message );
return "";
}
public String logout() {
FacesContext.getCurrentInstance().getExternalContext().invalidateSession();
return "/login.xhtml?faces-redirect=true";
}
}
My ListeFermesBean :
#ManagedBean
#RequestScoped
public class ListeFermesBean implements Serializable{
/**
*
*/
private static final long serialVersionUID = 1L;
#ManagedProperty(value="#{loginBean}")
private LoginBean loginBean;
#EJB
UtilisateurDao utilisateurDao;
private Utilisateur user;
private List<Ferme> liste;
public List<Ferme> getListe() {
liste = new ArrayList<Ferme>();
user = loginBean.getUser();
return liste = utilisateurDao.lister(user);
}
}
Login.xhtml :
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:f="http://java.sun.com/jsf/core" xmlns:h="http://java.sun.com/jsf/html">
...
...
<h:form id="Login">
<fieldset>
<legend>Login</legend>
<h:outputLabel for="email">Adresse email <span class="requis">*</span></h:outputLabel>
<h:inputText id="email" value="#{loginBean.email}" size="20" maxlength="60">
</h:inputText>
<h:message id="emailMessage" for="email" errorClass="erreur" />
<br />
<h:outputLabel for="motdepasse">Mot de passe <span class="requis">*</span></h:outputLabel>
<h:inputSecret id="motdepasse" value="#{loginBean.mdp}" size="20" maxlength="20">
</h:inputSecret>
<h:message id="motDePasseMessage" for="motdepasse" errorClass="erreur" />
<br />
<h:messages globalOnly="true" infoClass="erreur" />
<h:commandButton value="Login" action="#{loginBean.authentification}" styleClass="sansLabel">
</h:commandButton>
<br />
<h:commandButton value="Logout" action="#{loginBean.logout}" styleClass="sansLabel" />
<br />
<h:link value="Inscrivez-vous" outcome="inscription" />
</fieldset>
</h:form>
</h:body>
</html>
And finally the listeFermes.xhtml page which displays the List from listeFermesBean by User id stored in the object User in the session.
<!DOCTYPE html>
<html lang="fr"
xmlns="http://www.w3.org/1999/xhtml"
xmlns:f="http://java.sun.com/jsf/core"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:c="http://java.sun.com/jstl/core">
<h:head>
<title>SUCCES</title>
</h:head>
<h:body>
<ui:fragment rendered= "#{!loginBean.loggedIn}">
Not logged !
</ui:fragment>
<ui:fragment rendered= "#{loginBean.loggedIn}">
Welcome : #{loginBean.user.nom} <br />
E-mail : #{loginBean.user.email} <br />
<table border="1">
<tr>
<td>Nom Ferme</td>
<td>Nom User</td>
<td>ID User</td>
</tr>
<c:forEach items="#{ listeFermesBean.liste }" var="x">
<tr>
<td>#{x.nom_ferme}</td>
<td>#{x.utilisateur.nom}</td>
<td>#{x.utilisateur.id}</td>
</tr>
</c:forEach>
</table>
</ui:fragment>
</h:body>
</html>
As said in the comment you should use cdi injection. I believe this is a big no no as well:
public List<Ferme> getListe() {
liste = new ArrayList<Ferme>();
user = loginBean.getUser();
return liste = utilisateurDao.lister(user);
}
You should not do any business intensive things in your getters/setters. The reason is those can be called multiple times in the background.
Instead you should call your services in a method that is called AFTER the service has been injected.
#PostConstruct
public void init(){
listeFerm = utilisateurDao.lister(user);
}
public List<Ferm> getListFerm(){
return listFerm;
}
You didn't post your auth method(probably on purpose though).
Reguarding your Auth system you said you will deal with this after but still you don't need to go through the DAO with that. You should read about JAAS in the doc which is how to deal with this automatically then you don't need to go through a service and you can authenticate users in the bean. ie: Request.login(username, password) if my memory serves me right. You have to read about the subject though, you should use hash + salt when authenticating users.
#Named
#SessionScoped
public class LoginBean implements Serializable {
private static final long serialVersionUID = 1L;
private String email,mdp;
private Utilisateur user;
private boolean LoggedIn;
private List<Ferme> liste;
private Ferme ferme = new Ferme();
#Inject
UtilisateurDao utilisateurDao;
public Ferme getFerme() {
return ferme;
}
public void setFerme(Ferme ferme) {
this.ferme = ferme;
}
public void setListe(List<Ferme> liste) {
this.liste = liste;
}
public String getEmail() {
return email;
}
public void setEmail(String email) {
this.email = email;
}
public String getMdp() {
return mdp;
}
public void setMdp(String mdp) {
this.mdp = mdp;
}
public Utilisateur getUser() {
return user;
}
public void setUser(Utilisateur user) {
this.user = user;
}
public boolean isLoggedIn() {
return LoggedIn;
}
public void setLoggedIn(boolean loggedIn) {
LoggedIn = loggedIn;
}
public String authentification() {
if (utilisateurDao.login(email, mdp) != null) {
user = utilisateurDao.login(email, mdp);
LoggedIn = true;
return "listeFermes.xhtml?faces-redirect=true";
}
LoggedIn = false;
FacesMessage message = new FacesMessage( "Wrong E-mail or Password!" );
FacesContext.getCurrentInstance().addMessage( null, message );
return "";
}
public String logout() {
FacesContext context = FacesContext.getCurrentInstance();
context.addMessage(null, new FacesMessage("You are disconnected!"));
ExternalContext externalContext = context.getExternalContext();
externalContext.getFlash().setKeepMessages(true);
externalContext.invalidateSession();
return "/login.xhtml?faces-redirect=true";
}
public void deleteFerme(int id) {
utilisateurDao.supprimerFerme(user, id);
}
public void addFerme() {
utilisateurDao.creerFerme(ferme, user);
}
public List<Ferme> getListe() {
return liste;
}
#PostConstruct
public void init(){
liste = utilisateurDao.lister(user);
}
// Should I declare my Ferme and then initilize it new Ferme(); in the #PostConstruct too ? or leave it like it is ?
// & should I use the CRUD methods that use my "User" object stored in the session, in the #SessionScope bean? and then call the methods in my #RequestScoped bean? like this :
#SessionScope
public class LoginBean {
..
..
public void addFerme() {
utilisateurDao.creerFerme(ferme, user);
}
}
//////..... and then in the RequestScoped bean :
#RequestScoped
..
..
#Inject
private LoginBean loginBean;
public void addFerme() {
loginBean.addFerme();
}
// login Method
#Stateless
public class UtilisateurDao {
#PersistenceContext( unitName = "MyBD_PU" )
private EntityManager em;
public Utilisateur login(String email, String mdp) throws DAOException {
Utilisateur user = null;
Query requete = em.createQuery( JPQL_LOGIN );
requete.setParameter( PARAM_EMAIL, email ).setParameter(PARAM_PWD, mdp);
try {
user = (Utilisateur) requete.getSingleResult();
if (user!=null) {
return user;
}
return null;
} catch ( NoResultException e ) {
return null;
} catch ( Exception e ) {
FacesMessage message = new FacesMessage( FacesMessage.SEVERITY_ERROR, e.getMessage(), null );
FacesContext facesContext = FacesContext.getCurrentInstance();
facesContext.addMessage( null, message );
}
return user;
}
}
First little background info. Got a fairly standard User Role relationship where the User can have many roles. I have roles defined as a set within the user class. Now I know that html forms have all the values as strings and trying to get values as my custom Role object does not work. I implemented an initbinder to convert the id's back into object so that I can retrieve the selected values off of my checkboxes, that part works.
But I can't seem to go back the other way. I retrieve a User from the database that already has roles and want to pre populate role checkboxes with all the roles that a user has. Based on this example :
Checkboxes example
They say that:
form:checkboxes items="${dynamic-list}" path="property-to-store"
For multiple checkboxes, as long as the “path” or “property” value is
equal to any of the “checkbox values – ${dynamic-list}“, the matched
checkbox will be checked automatically.
My interpretation of that is I should be able to feed it a Set of all the roles and define the path to be the roles from the User object and it should match them thus causing the check box to pre populate.
Every example out there seems to have the value of dynamic-list as a String[]. Well thats great and dandy but how does this work for custom objects that our defined as a Set? Can I still use this one line definition for checkboxes or do I need to do some kind of data binding heading into the view also?
Here is my user dto, user controller, custom form binder, and user edit page.
User DTO
#Entity
#Table
public class User extends BaseDto
{
#Column(updatable = false) #NotBlank
private String username;
#Column(name = "encrypted_password") #Size(min = 6, message = "password must be at least 6 characters") #Pattern(regexp = "^\\S*$", message = "invalid character detected")
private String password;
#Column(name = "first_name")
private String firstName;
#Column(name = "last_name")
private String lastName;
#Column #NotNull
private boolean enabled;
#Column #Email #NotBlank
private String email;
#Transient
private String confirmPassword;
#ManyToMany(targetEntity = Role.class, fetch = FetchType.EAGER, cascade = CascadeType.REFRESH) #JoinTable(name = "user_role", joinColumns = #JoinColumn(name = "user_id"),
inverseJoinColumns = #JoinColumn(name = "role_id"))
private Set<Role> roles;
public User()
{
}
public User(final String usernameIn, final String passwordIn, final String firstNameIn, final String lastNameIn, final String emailIn, final boolean enabledIn)
{
username = usernameIn;
password = passwordIn;
firstName = firstNameIn;
lastName = lastNameIn;
email = emailIn;
enabled = enabledIn;
}
public String getUsername()
{
return username;
}
public void setUsername(final String usernameIn)
{
username = usernameIn;
}
public String getPassword()
{
return password;
}
public void setPassword(final String passwordIn)
{
password = passwordIn;
}
public String getFirstName()
{
return firstName;
}
public void setFirstName(final String firstNameIn)
{
firstName = firstNameIn;
}
public String getLastName()
{
return lastName;
}
public void setLastName(final String lastNameIn)
{
lastName = lastNameIn;
}
public String getEmail()
{
return email;
}
public void setEmail(final String emailIn)
{
email = emailIn;
}
public String getConfirmPassword()
{
return confirmPassword;
}
public void setConfirmPassword(final String confirmPasswordIn)
{
confirmPassword = confirmPasswordIn;
}
public boolean isEnabled()
{
return enabled;
}
public void setEnabled(final boolean enabledIn)
{
enabled = enabledIn;
}
public Set<Role> getRoles()
{
return roles;
}
public void setRoles(final Set<Role> rolesIn)
{
roles = rolesIn;
}
}
User Controller
#Controller #RequestMapping("/user")
public class UserController
{
#Autowired private UserService userService;
#Autowired private UserDao userDao;
#Autowired private RoleDao roleDao;
#InitBinder
public void bindForm(final WebDataBinder binder)
{
binder.registerCustomEditor(Set.class, "roles", new CustomFormBinder<RoleDao>(roleDao, Set.class));
}
#RequestMapping(method = RequestMethod.GET)
public String index(final ModelMap modelMap)
{
return "/user/index";
}
#RequestMapping(value = "/create", method = RequestMethod.GET)
public String create(final ModelMap modelMap)
{
modelMap.addAttribute("userInstance", new User());
modelMap.addAttribute("validRoles", new HashSet<Role>(roleDao.findAll()));
return "/user/create";
}
#RequestMapping(value = "/save", method = RequestMethod.POST)
public String save(final ModelMap modelMap, #Valid #ModelAttribute("userInstance") final User user, final BindingResult bindingResult)
{
// TODO move to service validation
if (user.getPassword() == null || !user.getPassword().equals(user.getConfirmPassword()) )
{
bindingResult.addError(new FieldError("userInstance", "password", "password fields must match"));
bindingResult.addError(new FieldError("userInstance", "confirmPassword", "password fields must match"));
}
if (user.getRoles() == null || user.getRoles().isEmpty())
{
bindingResult.addError(new FieldError("userInstance", "roles", "Must select at least one role for a User"));
}
if (bindingResult.hasErrors())
{
modelMap.addAttribute("validRoles", new HashSet<Role>(roleDao.findAll()));
return "/user/create";
}
userService.save(user);
return "redirect:/user/list";
}
#RequestMapping(value = "/edit/{id}", method = RequestMethod.GET)
public String edit(#PathVariable final Integer id, final ModelMap modelMap)
{
final User user = userDao.find(id);
if (user != null)
{
modelMap.addAttribute("userInstance", user);
modelMap.addAttribute("validRoles", new HashSet<Role>(roleDao.findAll()));
return "/user/edit";
}
return "redirect:/user/list";
}
#RequestMapping(value = "/edit", method = RequestMethod.GET)
public String editCurrent(final ModelMap modelMap)
{
return edit(userService.getLoggedInUser().getId(), modelMap);
}
#RequestMapping(value = "/update", method = RequestMethod.POST)
public String update(#Valid #ModelAttribute("userInstance") final User user, final BindingResult bindingResult)
{
if (bindingResult.hasErrors())
{
return "/user/edit";
}
userService.save(user);
return "redirect:/user/list";
}
#ModelAttribute("userInstances")
#RequestMapping(value = "/list", method = RequestMethod.GET)
public List<User> list()
{
return userDao.findAll();
}
}
Custom Form Binder
public class CustomFormBinder<T extends GenericDao> extends CustomCollectionEditor
{
private final T dao;
private static final Logger LOG = LoggerFactory.getLogger(CustomFormBinder.class);
public CustomFormBinder(final T daoIn, final Class collectionType)
{
super(collectionType, true);
dao = daoIn;
}
#Override
protected Object convertElement(final Object element)
{
try
{
// forms should return the id as the itemValue
return dao.find(Integer.valueOf(element.toString()));
}
catch (NumberFormatException e)
{
LOG.warn("Unable to convert " + element + " to an integer");
return null;
}
}
}
User Edit View
<html>
<head>
<title>Create User</title>
</head>
<body>
<c:url value="/user/update" var="actionUrl"/>
<form:form method="post" commandName="userInstance" action="${actionUrl}">
<h1>Edit User ${userInstance.username}</h1>
<div>
<form:label path="username">Username:</form:label>
<form:input path="username" id="username" readonly="true"/>
</div>
<div>
<form:label path="password">Password:</form:label>
<form:input path="password" id="password" type="password" readonly="true"/>
<tag:errorlist path="userInstance.password" cssClass="formError"/>
</div>
<div>
<form:label path="firstName">First Name:</form:label>
<form:input path="firstName" id="firstName"/>
<tag:errorlist path="userInstance.firstName" cssClass="formError"/>
</div>
<div>
<form:label path="lastName">Last Name:</form:label>
<form:input path="lastName" id="lastName"/>
<tag:errorlist path="userInstance.lastName" cssClass="formError"/>
</div>
<div>
<form:label path="email">Email:</form:label>
<form:input path="email" id="email" size="30"/>
<tag:errorlist path="userInstance.email" cssClass="formError"/>
</div>
<div>
**<%--Want to Pre Populate these checkboxed--%>
<form:checkboxes title="Assigned Roles:" path="roles" id="roles" items="${validRoles}" itemLabel="displayName" itemValue="id" element="div"/>**
<tag:errorlist path="userInstance.roles" cssClass="formError"/>
</div>
<form:hidden path="enabled"/>
<form:hidden path="id"/>
<form:hidden path="version"/>
<div class="submit">
<input type="submit" value="Update"/>
Cancel
</div>
</form:form>
</body>
</html>
You need a correct implemented equals method for Role!
If this is not enough have a look at class oorg.springframework.web.servlet.tags.form.AbstractCheckedElementTag. The method void renderFromValue(Object item, Object value, TagWriter tagWriter) is where the the checked flag is set.