Shell script to move files in while loop with counter - bash

Question

I am trying to move some files down a directory and rename them
the current file struct looks something like the following:
photos ->
{
1 -> Auction_Images -> <several image files>
item_image-1-1.jpg
item_image-2-1.jpg
...
2 -> Auction_Images -> <several image files>
item_image-3-1.jpg
...
3 -> Auction_Images -> <several image files>
my_script.sh
}
I want to be able to go into each numbered directory, check how many files/folders exist, if there is only one meaning the Auction_Images dir like folder 3 then I want to go into that Auction_Images dir and moved the photos out one directory and rename them. So far I have the following:
x=1
while [ $x -le 3 ]
do
cd $PWD/$x
echo Changed to dir: $PWD
count=ls | wc -l
echo $count
if [[ "$count" -eq 1 ]]
then
echo $PWD has 1 file/folder
fi
echo --------------------------------------------------
cd ..
x=$(( $x + 1 ))
done
the output I am getting is:
Changed to dir: /Users/jarvis/Desktop/imports/company/photos/1
0
--------------------------------------------------
Changed to dir: /Users/jarvis/Desktop/imports/company/photos/2
0
--------------------------------------------------
Changed to dir: /Users/jarvis/Desktop/imports/company/photos/3
0
The expected output would be:
Changed to dir: /Users/jarvis/Desktop/imports/company/photos/1
2
--------------------------------------------------
Changed to dir: /Users/jarvis/Desktop/imports/company/photos/2
1
--------------------------------------------------
Changed to dir: /Users/jarvis/Desktop/imports/company/photos/3
0
The current problem I am having is that the count doesn't seem to be captured correctly.

Answer 1

If I understood the question correctly, you could use something like this:
#!/usr/bin/env bash
shopt -s nullglob extglob
for dir in +([0-9])/; do
files=("$dir/"*)
count=${#files[#]}
echo "$PWD/$dir"
echo "$count"
if (( count == 1 )); then
#do something
echo "Only one file/folder"
mv -- "$files" /some/path/newname
fi
echo "=============================="
done
shopt -s nullglob = ensures you will not execute the loop if there are no directories
shopt -s extglob = enables extended globbing
for dir in +([0-9])/ = loops only over directories consisted of one or more numbers
files=("$dir/"*) = stores all files in currently searched directory into an array
count=${#files[#]} = counts the number of elements in the array -- number of files
mv -- "$files" /some/path/newname = moves the first and only element in the files array into the new location (note that $files is a shorter way of ${files[0]})
If you don't like the for loop I used and you insist on using this:
while [ $x -le 3 ]; do
x=$(( $x + 1 ))
done
you might consider using the C-style for loop:
for (( x=1; x<=3; x++ )); do
#do something
done
or brace expansion:
for x in {1..3}; do
#do something
done
That way you don't have to increment $x yourself. On top of that:
Quote expansions = echo "$PWD"
count=ls | wc -l = use command substitution instead: count=$(ls | wc -l)
Why you shouldn't parse the output of ls