I ran into what seems to be a bug in Painless where if a vector function is used, say l2norm(), the outcome remains the same outcome as the first iteration. I'm using the painless script in a function score, I hope the query below sheds some light. I'm using the "exception" to see what the value is in each of the iteration, and it's every time the score of the first vector. I know this because I cycled the parameters a couple of times, and the score is everytime "stuck" on the first thing. So what I think is happening is that the function l2norm() (and all vector functions?!) are object instances that can only be instantiated one time? If that would be the case, what would be a work around?
Link to the ES discussion: https://discuss.elastic.co/t/painless-bug-using-for-loops-and-vector-functions/267263
{
"query": {
"nested": {
"path": "media",
"query": {
"function_score": {
"boost_mode": "replace",
"query": {
"bool": {
"filter": [{
"exists": {
"field": "media.full_body_dense_vector"
}
}]
}
},
"functions": [{
"script_score": {
"script": {
"source": "if (params.filterVectors.size() > 0 && params.filterCutOffScore >= 0) {\n for (int i=0; i < params.filterVectors.size();i++) {\n def c = params.filterVectors[i]; double euDistance = l2norm(c, doc['media.full_body_dense_vector']);\n if (i==1) { throw new Exception(euDistance + ''); } \n }\n return 1.0f;",
"params": {
"filterVectors":[
[1.0,2.0,3.0],[0.1,0.4,0.5]
],
"filterCutOffScore": 1.04
},
"lang": "painless"
}
}
}]
}
}
}
},
"size": 500,
"from": 0,
"track_scores": true
}
While l2norm is a static method, it certainly shouldn't behave like a pure function!
I've investigated a bit and it seems there's only a loop-level bug. When you call l2norm outside of the loop with either parametrized or hard-coded vectors, the results will always be different -- as they should be. But not within the for loop (I've tested a while loop too -- same result). Here's a minimum reproducible example that could be used to report a bug on github:
"script": {
"source": """
def field = doc['media.full_body_dense_vector'];
def hardcodedVectors = [ [1,2,3], [0.1,0.4,0.5] ];
def noLoopDistances = [
l2norm(hardcodedVectors[0], field),
l2norm(hardcodedVectors[1], field)
];
def hardcodedDistances = [];
for (vector in hardcodedVectors) {
double euDistance = l2norm(vector, field);
hardcodedDistances.add(euDistance);
}
def parametrizedDistances = [];
for (vector in params.filterVectors) {
double euDistance = l2norm(vector, field);
parametrizedDistances.add(euDistance);
}
def comparisonMap = [
"no-loop": noLoopDistances,
"hardcoded": hardcodedDistances,
"parametrized": parametrizedDistances
];
Debug.explain(comparisonMap);
""",
"params": {
"filterVectors": [ [1,2,3], [0.1,0.4,0.5] ]
},
"lang": "painless"
}
which yields
{
"no-loop":[
8.558621384311845, // <-- the only time two different l2norm calls behave correctly
11.071133967619906
],
"parametrized":[
8.558621384311845,
8.558621384311845
],
"hardcoded":[
8.558621384311845,
8.558621384311845
]
}
What this tells me is that it's not a matter of runtime caching but rather something else that should be investigated further be the Elastic team.
The workaround, for now, would be to keep using the parametrized vectors but instead of looping perform stone-age-like checks:
if (params.filterVectors.length == 0) {
// default to something
} else if (params.filterVectors.length == 1) {
// call l2norm once
} else if (params.filterVectors.length == 2) {
// call l2norm twice, separately
}
P.S. Throwing a new Exception() in order to debug Painless is fine. Using Debug.explain is even better for reasons explained in this sub-chapter on Debugging of my Elasticsearch Handbook.
First off, thanks to Joe for confirming I wasn't imagining things and it's indeed a bug. Second, the lovely ElasticSearch team has been triaging the issue and confirmed it's a bug, so the answer to this post is a link to the Github Issue so in the future, people can track in which ElasticSearch version this behaviour is patched.
I have a elastic query script that meant to calculate the ground distance with the parameters I gave it and I have to use it in multiple queries Is there a way to avoid this duplication , for-example a way to calculate a global variable and use it in all the scripts in this example I want to calculate distance and use it in other queries and not calculate it every time.
"query":{
"bool":{
"filter":[
{
"script":{
"script":{
"lang":"painless",
"params":{
"9183":4896.4,
"9238":7487.3,
"9239":7491.2,
"9402":5150.7,
"9618":2069.5,
"9656":4028.6,
"9660":3612.1,
"10049":2823.4,
"10175":3679.2,
"10204":4975.8,
"10479":5167.8,
"10486":2762.7,
"10775":3193.2,
"10801":6596.8,
"11063":2814.7,
"11470":7309.8,
"11596":2818.4,
"11780":6254.9,
"11954":3907.4,
"12001":6377.1,
"12071":3065.1,
"12258":2264.4,
"12333":6048.1,
"13088":1844.1,
"13566":2266.9,
"13576":3946.4,
"13636":3620.8,
"13696":5970.7,
"13700":1648.4,
"13810":4451.7,
"13884":2935,
"13902":2193.5,
"14271":3963.1,
"14345":2979,
"14360":2260,
"14363":2533,
"14375":4024.7,
"14685":1849,
"14703":3769.1,
"14913":3943,
"14973":6767.3,
"14976":5951.1,
"15009":3894.1,
"15270":4590.9,
"15348":4954.9,
"15360":4540.2,
"15447":5774.2,
"15534":6915.4,
"15612":5732.6,
"15789":1556.5,
"15991":3018.4,
"16051":6406.7,
"16201":2814.5,
"16247":3254.8,
"16525":2193.2,
"16547":4422.9,
"16561":3540.8,
"16613":6754.8,
"16727":3264.6,
"16731":1956.7,
"17063":4275.2,
"17181":4354.4,
"17657":2913.3,
"17757":1762.8,
"17761":3522.6,
"17777":2029,
"17895":3989,
"17965":1972.1,
"18553":3753.8,
"18586":2186.5,
"18631":1959.4,
"19006":7236,
"19022":3970.5,
"19134":3753.7,
"19150":7410.3,
"19180":4115,
"19196":5071.1,
"19276":1780.9,
"19387":3530.3,
"19393":2040.8,
"19792":4689.2,
"19903":5166.4,
"19981":6781.6,
"20132":2498.1,
"20372":6799.3,
"20387":5453.5,
"20826":3829.1,
"20838":2317.9,
"20856":2399.4,
"21134":1339.1,
"21233":3963.6,
"21266":4757,
"21269":3583.9,
"21320":3926.3,
"21490":5100.5,
"21910":4792.5,
"23104":7408.4,
"23125":4892.9,
"23167":3526.2,
"24625":6983.8,
"24985":6782.1,
"25090":3500.3,
"25129":1451.9,
"25375":4687,
"25376":4050.8,
"25458":2138.1,
"25478":4776.8,
"25652":6463,
"26224":6259.5,
"26567":2313.6,
"26594":6465.6,
"26651":2068,
"26824":3592,
"26826":6396.7,
"26890":3790.7,
"26926":5943.1,
"26932":5018.9,
"26956":3626.5,
"27012":4201.9,
"27016":4209.1,
"27017":4212.2,
"27019":4203.1,
"27020":4202.2,
"27021":4211.1,
"27026":4190.1,
"27053":1834.6,
"27055":5564.1,
"27135":6467.4,
"27232":3588.8,
"27242":5898.2,
"27257":4061.2,
"27266":6913.4,
"27318":3917.6,
"27346":2122.8,
"27365":7021,
"27368":7619.7,
"27396":5375.8,
"27460":7504.4,
"27492":3885.6,
"27557":2989.4,
"27594":2830.4,
"27683":3882.7,
"27828":3980.8,
"27865":6066.5,
"28018":6863.6,
"28057":2569.9,
"28060":2569.7,
"minDistance":0
},
"source":"def a=doc['id'].getValue();if (!params.containsKey(a.toString())) {return false;}double distance=params[a.toString()]; return distance <= doc['maxClassDeliveryDistance'].getValue() && distance >= params['minDistance']"
}
}
},
{
"script":{
"script":{
"lang":"painless",
"params":{
"9183":4896.4,
"9238":7487.3,
"9239":7491.2,
"9402":5150.7,
"9618":2069.5,
"9656":4028.6,
"9660":3612.1,
"10049":2823.4,
"10175":3679.2,
"10204":4975.8,
"10479":5167.8,
"10486":2762.7,
"10775":3193.2,
"10801":6596.8,
"11063":2814.7,
"11470":7309.8,
"11596":2818.4,
"11780":6254.9,
"11954":3907.4,
"12001":6377.1,
"12071":3065.1,
"12258":2264.4,
"12333":6048.1,
"13088":1844.1,
"13566":2266.9,
"13576":3946.4,
"13636":3620.8,
"13696":5970.7,
"13700":1648.4,
"13810":4451.7,
"13884":2935,
"13902":2193.5,
"14271":3963.1,
"14345":2979,
"14360":2260,
"14363":2533,
"14375":4024.7,
"14685":1849,
"14703":3769.1,
"14913":3943,
"14973":6767.3,
"14976":5951.1,
"15009":3894.1,
"15270":4590.9,
"15348":4954.9,
"15360":4540.2,
"15447":5774.2,
"15534":6915.4,
"15612":5732.6,
"15789":1556.5,
"15991":3018.4,
"16051":6406.7,
"16201":2814.5,
"16247":3254.8,
"16525":2193.2,
"16547":4422.9,
"16561":3540.8,
"16613":6754.8,
"16727":3264.6,
"16731":1956.7,
"17063":4275.2,
"17181":4354.4,
"17657":2913.3,
"17757":1762.8,
"17761":3522.6,
"17777":2029,
"17895":3989,
"17965":1972.1,
"18553":3753.8,
"18586":2186.5,
"18631":1959.4,
"19006":7236,
"19022":3970.5,
"19134":3753.7,
"19150":7410.3,
"19180":4115,
"19196":5071.1,
"19276":1780.9,
"19387":3530.3,
"19393":2040.8,
"19792":4689.2,
"19903":5166.4,
"19981":6781.6,
"20132":2498.1,
"20372":6799.3,
"20387":5453.5,
"20826":3829.1,
"20838":2317.9,
"20856":2399.4,
"21134":1339.1,
"21233":3963.6,
"21266":4757,
"21269":3583.9,
"21320":3926.3,
"21490":5100.5,
"21910":4792.5,
"23104":7408.4,
"23125":4892.9,
"23167":3526.2,
"24625":6983.8,
"24985":6782.1,
"25090":3500.3,
"25129":1451.9,
"25375":4687,
"25376":4050.8,
"25458":2138.1,
"25478":4776.8,
"25652":6463,
"26224":6259.5,
"26567":2313.6,
"26594":6465.6,
"26651":2068,
"26824":3592,
"26826":6396.7,
"26890":3790.7,
"26926":5943.1,
"26932":5018.9,
"26956":3626.5,
"27012":4201.9,
"27016":4209.1,
"27017":4212.2,
"27019":4203.1,
"27020":4202.2,
"27021":4211.1,
"27026":4190.1,
"27053":1834.6,
"27055":5564.1,
"27135":6467.4,
"27232":3588.8,
"27242":5898.2,
"27257":4061.2,
"27266":6913.4,
"27318":3917.6,
"27346":2122.8,
"27365":7021,
"27368":7619.7,
"27396":5375.8,
"27460":7504.4,
"27492":3885.6,
"27557":2989.4,
"27594":2830.4,
"27683":3882.7,
"27828":3980.8,
"27865":6066.5,
"28018":6863.6,
"28057":2569.9,
"28060":2569.7
},
"source":"def a=doc['id'].getValue();if (!params.containsKey(a.toString())) {return false;}double distance=params[a.toString()];return distance <= doc['maxDeliveryRadius'].getValue()"
}
}
}
]
}
}
}
Mapping :
{
"id":{
"type":"long"
},
"maxClassDeliveryDistance":{
"type":"long"
},
"maxDeliveryRadius":{
"type":"long"
}
}
You should use a stored script instead so you can reference it by id:
POST _scripts/distance-script
{
"script": {
"lang": "painless",
"source":"def a=doc['id'].getValue();if (!params.containsKey(a.toString())) {return false;}double distance=params[a.toString()];return distance <= doc['maxDeliveryRadius'].getValue()"
}
}
You can then reference the above script in your query:
{
"query": {
"bool": {
"filter": [
{
"script": {
"script": {
"lang": "painless",
"params": { ... },
"id": "distance-script"
}
}
},
{
"script": {
"script": {
"lang": "painless",
"params": { ... },
"id": "distance-script"
}
}
}
]
}
}
}
UPDATE
I think we can solve this differently. You have two script queries in a bool/filter which means AND. Also, you have the same parameters in both scripts. Hence, you could combine both scripts and get away with a single script, like this one:
POST _scripts/distance-script
{
"script": {
"lang": "painless",
"source":"""
def a = doc.id.value.toString();
if (!params.containsKey(a) {
return false;
}
double distance = params[a];
return distance <= doc.maxClassDeliveryDistance.value && distance >= params['minDistance'] && distance <= doc.maxDeliveryRadius.value;
"""
}
}
We're trying to replicate this ES plugin https://github.com/MLnick/elasticsearch-vector-scoring. The reason is AWS ES doesn't allow any custom plugin to be installed. The plugin is just doing dot product and cosine similarity so I'm guessing it should be really simple to replicate that in painless script. It looks like groovy scripting is deprecated in 5.0.
Here's the source code of the plugin.
/**
* #param params index that a scored are placed in this parameter. Initialize them here.
*/
#SuppressWarnings("unchecked")
private PayloadVectorScoreScript(Map<String, Object> params) {
params.entrySet();
// get field to score
field = (String) params.get("field");
// get query vector
vector = (List<Double>) params.get("vector");
// cosine flag
Object cosineParam = params.get("cosine");
if (cosineParam != null) {
cosine = (boolean) cosineParam;
}
if (field == null || vector == null) {
throw new IllegalArgumentException("cannot initialize " + SCRIPT_NAME + ": field or vector parameter missing!");
}
// init index
index = new ArrayList<>(vector.size());
for (int i = 0; i < vector.size(); i++) {
index.add(String.valueOf(i));
}
if (vector.size() != index.size()) {
throw new IllegalArgumentException("cannot initialize " + SCRIPT_NAME + ": index and vector array must have same length!");
}
if (cosine) {
// compute query vector norm once
for (double v: vector) {
queryVectorNorm += Math.pow(v, 2.0);
}
}
}
#Override
public Object run() {
float score = 0;
// first, get the ShardTerms object for the field.
IndexField indexField = this.indexLookup().get(field);
double docVectorNorm = 0.0f;
for (int i = 0; i < index.size(); i++) {
// get the vector value stored in the term payload
IndexFieldTerm indexTermField = indexField.get(index.get(i), IndexLookup.FLAG_PAYLOADS);
float payload = 0f;
if (indexTermField != null) {
Iterator<TermPosition> iter = indexTermField.iterator();
if (iter.hasNext()) {
payload = iter.next().payloadAsFloat(0f);
if (cosine) {
// doc vector norm
docVectorNorm += Math.pow(payload, 2.0);
}
}
}
// dot product
score += payload * vector.get(i);
}
if (cosine) {
// cosine similarity score
if (docVectorNorm == 0 || queryVectorNorm == 0) return 0f;
return score / (Math.sqrt(docVectorNorm) * Math.sqrt(queryVectorNorm));
} else {
// dot product score
return score;
}
}
I'm trying to start with just getting a field from index. But I'm getting error.
Here's the shape of my index.
I've enabled delimited_payload_filter
"settings" : {
"analysis": {
"analyzer": {
"payload_analyzer": {
"type": "custom",
"tokenizer":"whitespace",
"filter":"delimited_payload_filter"
}
}
}
}
And I have a field called #model_factor to store a vector.
{
"movies" : {
"properties" : {
"#model_factor": {
"type": "text",
"term_vector": "with_positions_offsets_payloads",
"analyzer" : "payload_analyzer"
}
}
}
}
And this is the shape of the document
{
"#model_factor":"0|1.2 1|0.1 2|0.4 3|-0.2 4|0.3",
"name": "Test 1"
}
Here's how I use the script
{
"query": {
"function_score": {
"query" : {
"query_string": {
"query": "*"
}
},
"script_score": {
"script": {
"inline": "def termInfo = doc['_index']['#model_factor'].get('1', 4);",
"lang": "painless",
"params": {
"field": "#model_factor",
"vector": [0.1,2.3,-1.6,0.7,-1.3],
"cosine" : true
}
}
},
"boost_mode": "replace"
}
}
}
And this is the error I got.
"failures": [
{
"shard": 2,
"index": "test",
"node": "ShL2G7B_Q_CMII5OvuFJNQ",
"reason": {
"type": "script_exception",
"reason": "runtime error",
"caused_by": {
"type": "wrong_method_type_exception",
"reason": "wrong_method_type_exception: cannot convert MethodHandle(List,int)int to (Object,String)String"
},
"script_stack": [
"termInfo = doc['_index']['#model_factor'].get('1',4);",
" ^---- HERE"
],
"script": "def termInfo = doc['_index']['#model_factor'].get('1',4);",
"lang": "painless"
}
}
]
The question is how do I access the index field to get #model_factor in painless scripting?
Option 1
Due to the fact that #model_factor is a text field, in painless scripting, it would be possible to access it, setting fielddata=true in the mapping. So the mapping should be:
{
"movies" : {
"properties" : {
"#model_factor": {
"type": "text",
"term_vector": "with_positions_offsets_payloads",
"analyzer" : "payload_analyzer",
"fielddata" : true
}
}
}
}
And then it can be scored accessing doc-values:
{
"query": {
"function_score": {
"query" : {
"query_string": {
"query": "*"
}
},
"script_score": {
"script": {
"inline": "return Double.parseDouble(doc['#model_factor'].get(1)) * params.vector[1];",
"lang": "painless",
"params": {
"vector": [0.1,2.3,-1.6,0.7,-1.3]
}
}
},
"boost_mode": "replace"
}
}
}
Problems with Option 1
So it is possible to access the field data value setting fielddata=true, but in this case, the value is the vector index as a term, not the value of the vector which is stored in the payload. Unfortunately, it looks like there is no way to access the Token Payload (where the real vector index value is stored) using painless scripting and doc-values. See the source code for elasticsearch and another similar question re: accessing term info.
So the answer is that using painless scripting is NOT possible to access the payload.
I tried also to store the vector values with a simple pattern tokenizer but when accessing the term vector values the order is not preserved, and this is probably the reason for which the author of the plugin decided to use the term as a string and then retrieve the position 0 of the vector as the term "0" and then find the real vector value in the payload.
Option 2
A very simple alternative is to use n fields in the documents, each of them represents a position in the vector, so in your example, we have a 5 dim vector with values stored in v0...v4 directly as double:
{
"#model_factor":"0|1.2 1|0.1 2|0.4 3|-0.2 4|0.3",
"name": "Test 1",
"v0" : 1.2,
"v1" : 0.1,
"v2" : 0.4,
"v3" : -0.2,
"v4" : 0.3
}
and then the painless scripting should be:
{
"query": {
"function_score": {
"query" : {
"query_string": {
"query": "*"
}
},
"script_score": {
"script": {
"inline": "return doc['v0'].getValue() * params.vector[0];",
"lang": "painless",
"params": {
"vector": [0.1,2.3,-1.6,0.7,-1.3]
}
}
},
"boost_mode": "replace"
}
}
}
It should be easily possible to iterate on the input vector length and get the fields dynamically to calculate the dot product modifying doc['v0'].getValue() * params.vector[0] that I wrote for simplicity.
Problems with Option2
Option 2 is viable as long as the vector dimension remains not big. I think that default Elasticsearch max number of fields per document is 1000, but it can be changed also in AWS environment:
curl -X PUT \
'https://.../indexName/_settings' \
-H 'cache-control: no-cache' \
-H 'content-type: application/json'
-d '{
"index.mapping.total_fields.limit": 2000
}'
Moreover, it should be tested also the script speed on a large number of documents.
Maybe in re-scoring / re-ranking scenarios, it is a viable solution.
Option 3
The third option is really an experiment and the most fascinating in my opinion.
It tries to exploit the internal Elasticsearch representation of the Vector Space Model and does not use any scripting to score but reuse the default similarity score based on tf/idf.
Lucene, that seats at Elasticsearch core, is already using internally a modification of the cosine similarity to calculate the similarity score between documents in his Vector Space Model representation of terms as the formula below, taken from the TFIDFSImilarity javadoc, shows:
In particular, the weights of the vector representing the field are the tf/idf values of the terms of that field.
So we could index a document with termvectors, using as term the index of the vector. If we repeat it N times, we represent the value of the vector, exploiting the tf part of the scoring formula.
This means that the domain of the vector should be transformed and rescaled in {1.. Infinite} Positive Integer numbers domain. We start from 1 so that we are sure that all the documents contain all the terms, it will make it easier to exploit the formula.
For example, the vector: [21, 54, 45] can be indexed as a field in a document using a simple whitespace analyzer and the following value:
{
"#model_factor" : "0<repeated 21 times> 1<repeated 54 times> 2<repeated 45 times>",
"name": "Test 1"
}
then to query, i.e. calculate the dot product, we boost the single terms that represent the index position of the vector.
So using the same example above the input vector: [45, 1, 1] will be transformed in the query:
"should": [
{
"term": {
"#model_factor": {
"value": "0",
"boost": 45
}
}
},
{
"term": {
"#model_factor": "1" // boost:1 by default
}
},
{
"term": {
"#model_factor": "2" // boost:1 by default
}
}
]
norm(t,d) should be disabled in the mapping so that it is not used in the formula above. The idf part is constant for all the documents because all of them contains all the terms (having all the vectors the same dimension).
queryNorm(q) is the same for all the documents in the formula above so it is not a problem.
coord(q,d) is a constant because all the documents contain all the terms.
Problems with Option 3
Need to be tested.
It works only for positive numbers vectors, see this question in math stackoverflow for making it works also for negative numbers.
It is not the exact same of a dot product but very close to find similar documents based on raw vectors.
Scalability on large vector dimension can be an issue at querying time because this means we need to do a N dim terms query with different boosting.
I will try it in a test index and edit this question with the results.