How to mv using sed to rename files with trailing space? - bash

Question

We have a very large file structure that has been very badly built. Paths contain lots of spaces, #, spaces around dashes.
It's all hosted on a Synology NAS, so I don't have access to the whole array of tools usually included (like rename).
I'm trying to rename file AND folder names that have a leading and trailing spaces.
# Global vars
tstamp=$(date +%Y-%m-%d_%H%M%S)
# Change for separator to newline
IFS=$'\n'
echo "$tstamp - Renaming files with leading space: \n"
for filename in $(find . -type f -name '[[:space:]]*')
do
newFilename=$(echo $filename |sed 's/\/[[:space:]]/\//g')
echo "original: $filename"
echo "new : $newFilename"
mv -i -v -n $filename $newFilename
echo "\n"
done
echo "$tstamp - Renaming files with trailing space: \n"
for filename in $(find . -type f -name '*[[:space:]]')
do
newFilename=$(echo $filename |sed 's/[[:space:]]$//g')
echo "original: $filename"
echo "new : $newFilename"
mv -i -v -n $filename $newFilename
echo "\n"
done
# A slash "/" in a filename is not possible thus it's not verified
echo "$tstamp - Renaming files with unsupported characters (\ / \" : < > ; | * ?):"
for filename in $(find . -type f -name '*\**' -o -name '*\\*' -o -name '*"*' -o -name '*:*' -o -name '*<*' -o -name '*>*' -o -name '*;*' -o -name '*|*' -o -name '*\?*')
do
newFilename=$(echo $filename |sed 's/\(\\\|"\|:\|<\|>\|;\||\|\*\|\?\)//g')
echo "original: $filename"
echo "new : $newFilename"
mv -i -v -n $filename $newFilename
echo "\n"
done
echo "Done."
#EOF
Renaming files with unsupported characters works well, but not the leading and trainling spaces.
Here's an actual output where I replaced some names for security purposes:
original:
./ABC- Financing/2018 - ABC Capital Bl Fund 2018 (VCCI)/0 - Dataroom/8 - Vérification diligente/3. Governance/ 2017Q1/ Documents de Julie/#eaDir/ PPP#SynoResource
new:
./ABC - Financing/2018 - ABC Capital Innovation Fund 2018 (GGGG)/0 - Dataroom/8 - Vérification diligente/3. Governance/2017Q1/Documents de Julie/#eaDir/PPP#SynoResource
./ABC - Financing/2018 - ABC Capital Innovation Fund 2018 (GGGG)/0 - Dataroom/8 - Vérification diligente/3. Governance/ 2017Q1/ Documents de Julie/#eaDir/ CDP#SynoResource → ./ABC - Financing/2018 - ABC Capital Innovation Fund 2018 (GGGG)/0 - Dataroom/8 - Vérification diligente/3. Governance/2017Q1/Documents de Julie/#eaDir/PPP#SynoResource
mv: cannot move "./ABC - Financing/2018 - ABC Capital Innovation Fund 2018 (GGGG)/0 - Dataroom/8 - Vérification diligente/3. Governance/ 2017Q1/ Documents de Julie/#eaDir/ PPP#SynoResource" to "./ABC - Financing/2018 - ABC Capital Innovation Fund 2018 (GGGG)/0 - Dataroom/8 - Vérification diligente/3. Governance/2017Q1/Documents de Julie/#eaDir/PPP#SynoResource": No such file or directory
I don't understand why the file isn't found by the mv command.

Answer 1

Start with this (uses GNU versions of find and sed):
#/bin/env bash
readarray -d '' paths < <(find . -depth -print0)
for old in "${paths[#]}"; do
printf 'Working on path %q\n' "$old" >&2
new=$(
printf '%s' "$old" |
sed -z '
s#[\\":<>;|*?]##g
s#[[:space:]]*/[[:space:]]*#/#g
s#[[:space:]]*$##
'
)
if [[ "$new" != "$old" ]]; then
printf 'old: %q\n' "$old" >&2
printf 'new: %q\n' "$new" >&2
[[ -f "$new" ]] && printf 'Warning: %q already exists.\n' "$new" >&2
mv -i -v -n -- "$old" "$new"
printf '\n'
fi
done
You can probably replace the printf | sed with some bash builtins for a performance improvement but life's too short for me to try to figure that out and the above should be clear and simple enough for any other changes you need to make.
The above is untested so make sure you take a backup of your files and test it thoroughly on a temp dir before running on your real files.

Answer 2

Lets try to do it safely and correctly this way instead:
#!/usr/bin/env bash
shopt -s extglob # setup extended globbing so it can match group multipe times
# Find all files or directories names that:
# either starts with spaces,
# or ends with spaces,
# or contains any of the \ " : < > ; | * ? prohibited characters
find . \
-depth \
\( -type f -or -type d \) \
-regextype posix-extended \
-regex '.*/([[:space:]].*|.*[[:space:]]|.*[\\":<>;|*?].*)' \
-print0 \
| while IFS= read -r -d '' filename; do
# Isolates the file name from its directory path
base="$(basename -- "${filename}")"
# ExtGlob strips-out all instances of prohibited characters class using //
# [\\\":<>;|*?]
base="${base//[\\\":<>;|*?]/}"
# ExtGlob strips-out leading spaces
# *([[:space:]]):
# * 0 or any times the following (group)
# [[:space:]] any space character
base="${base/*([[:space:]])/}"
# ExtGlob strips-out trailing spaces using %%
base="${base%%*([[:space:]])}"
# Compose a new file name from the new base
newFilename="$(dirname -- "${filename}")/${base}"
# Prevent the new file name to collide with existing files
# by adding a versionned suffix
suffix=''
count=1
while [[ -e "${newFilename}${suffix}" ]]; do
suffix=".$((count++))"
done
newFilename="${newFilename}${suffix}"
printf \
"original: '%s'\\nnew : '%s'\\n\\n" \
"${filename}" \
"${newFilename}"
mv -- "${filename}" "${newFilename}"
done
echo 'Done.'