Invalid argument supplied for foreach() on laravel - laravel

Question

I have like error message : Invalid argument supplied for foreach()
For my method index() I have this:
public function index(Request $request)
{
if(\Auth::user()->hasRole('admin')){
if($request->has('search'))
$remarks = Remark::orderBy('instruction', 'asc')->where('instruction','like','%'.$request->input('search').'%');
else
$remarks = Remark::all();
}else{
\Auth::user()->load('remarks');
$remarks = \Auth::user()->remarks;
}
return view('admin.remarks.index', compact('remarks'));
}
Concerning my index.blade.php I have my loop "for" which is like this:
<th>Instruction</th>
<th>Description</th>
<th>Date seance</th>
<th>Name Candidate</th>
<th>Email</th>
</tr>
</thead>
#foreach($remarks as $remark)
<tr>
<td> {{$remark->instruction}}</td>
<td> {{$remark->description}}</td>
<td> {{$remark->seances->date_seance}}</td>
<td> {{$remark->seances()->first()->candidates->name}}</td>
<td> {{$remark->seances()->first()->candidates->email}}</td>
<td>
Do you have an idea of my problem please? I don't understand ??

Answer 1

You need to call get() after the Eloquent Query Builder to fetch the data from the database. Unless it's an Eloquent Query Builder Object (which is not iterable, so cannot be used in a for loop).
The function get() will return the result as a Laravel Collection (which is iterable).
$remarks = Remark::orderBy('instruction', 'asc')
->where('instruction','like','%'.$request->input('search').'%')
->get();

Answer 2

you should querying from database not from session and don't forgot define relations on users model :
on users model:
public function remarks(){
return $this->hasMany(Remark:class)
}
on your controller
public function index(Request $request)
{
if(\Auth::user()->hasRole('admin')){
if($request->has('search'))
$remarks = Remark::orderBy('instruction', 'asc')->where('instruction','like','%'.$request->input('search').'%');
else
$remarks = Remark::all();
}else{
$user = Users::find(Auth::id());
$remarks=$user->remarks
}
return view('admin.remarks.index', compact('remarks'));
}