bash: Call a function from a while with arguments - bash

Question

I have this working:
$ find . -name 'copy_*.txt' |while read i ; do echo $i; git mv $i ${i%.txt}.cob ;done
I whant to have the main body in a bash function:
$ my_mv () { echo $1; mv $1 ${1%.cob}.toto; }
To then call it with:
$ find . -name 'copy_*.txt' |while read i ;do my_mv $i; done
But I get a silent execution and nothing append:
$ my_mv () { echo $1; mv $1 ${1%.cob}.toto; }
$ find . -name 'copy_*.txt' |while read i ;do my_mv $i; done
$
same with:
$ my_mv () { printf '%s\n' $1; mv $1 ${1%.cob}.toto; }

Answer 1

As said in the comments, it's not working, because you're searching for files copy_*.txt and are trying to move files with suffix .cob. Furthermore
your variables are not quoted and will cause problems with white space in filenames.
Export your function to make my_mv available in find and use -exec to prevent problems with filenames containing newlines:
my_mv () { for i; do echo "$i"; mv "$i" "${i%.cob}.toto"; done; }
export -f my_mv
find . -name 'copy_*.cob' -exec bash -c 'my_mv "$#"' bash {} +
Its often easier to use a small shell script instead of a function:
find . -name 'copy_*.cob' -exec sh -c '
for i; do
echo "$i"
mv "$i" "${i%.cob}.toto"
done
' sh {} +
Or move the code into a shell script mymv.sh
#!/bin/sh
for i; do
echo "$i"
mv "$i" "${i%.cob}.toto"
done
and execute the script in find:
find . -name 'copy_*.cob' -exec ./mymv.sh {} +