Laravel Loop through Array Value and Update Users - laravel

Question

I have an app I am working on. I am supposed to get some data from the external API. I am comparing the email from the database to the email in the response, so as to be able to update the user associated with a particular email.
Here is my full code
public function checkpaysub(Request $request) {
$userss = User::all()->pluck('email');
//dd($userss);
foreach($userss as $users) {
$email = $users;
//$ref= $request->reference_code;
$url= 'https://api.paystack.co/customer/';
$url .= $email;
//dd($url);
$client = new Client();
$response = $client->request('GET', $url, [
'headers' => [
'Authorization' => 'Bearer '.'##################',
],
]);
$statusCode = $response->getStatusCode();
$body = json_decode($response->getBody()->getContents());
$sub_cus = $body->status;
$sub_status = $body->data->subscriptions[0]->status;
$sub_email = $body->data->email;
$user_exist = User::where('email', $sub_email)->exists();
if(($body->status == 'true') && $user_exist && $sub_status){
$user = User::where('email', $sub_email)->first();
$user->sub_status = $sub_status;
$user->save();
$users = new UserResource(User::where('email', $sub_email)->first());
return response()->json(array(
'user' => $users
));
}
elseif (($body->status == 'true') && $user_exist) {
$user = User::where('email', $sub_email)->first();
$user->sub_status = "inactive";
$user->save();
$users = new UserResource(User::where('email', $sub_email)->first());
return response()->json(array(
'user' => $users
));
}
}
}
}
This only updates one user. I want to loop through the email and update each user based on the email.

Answer 1

because you have return in foreach so it's only going to loop once.
public function checkpaysub(Request $request) {
$userss = User::all()->pluck('email');
$returnedUsers = collect([]);
foreach($userss as $users) {
$email = $users;
$url= 'https://api.paystack.co/customer/';
$url .= $email;
$client = new Client();
$response = $client->request('GET', $url, [
'headers' => [
'Authorization' => 'Bearer '.'##################',
],
]);
$statusCode = $response->getStatusCode();
$body = json_decode($response->getBody()->getContents());
$sub_cus = $body->status;
$sub_status = $body->data->subscriptions[0]->status;
$sub_email = $body->data->email;
$user_exist = User::where('email', $sub_email)->exists();
if(($body->status == 'true') && $user_exist && $sub_status){
$user = User::where('email', $sub_email)->first();
$user->sub_status = $sub_status;
$user->save();
$users = new UserResource(User::where('email', $sub_email)->first());
$returnedUsers->push($users);
}
elseif (($body->status == 'true') && $user_exist) {
$user = User::where('email', $sub_email)->first();
$user->sub_status = "inactive";
$user->save();
$users = new UserResource(User::where('email', $sub_email)->first());
$returnedUsers->push($users);
}
}
return response()->json(array(
'user' => $returnedUsers->all()
));
}

Answer 2

This can be refactored in a big way to be much more simple:
$client = new Client();
$usersWithUpdatedSubscriptions = collect();
User::chunk(100, function ($users) use ($client, $usersWithUpdatedSubscriptions) {
foreach($users as $user) {
$response = $client->request('GET', "https://api.paystack.co/customer/$user->email", [
'headers' => [
'Authorization' => 'Bearer '.'##################',
],
]);
$body = json_decode($response->getBody()->getContents());
if ($body->status == 'true') && $user->email === data_get($body->data, 'email', null)) {
$user->update([
'sub_status' => data_get($body->data->subscriptions, '0.email', null) ?? 'inactive'
]);
$usersWithUpdatedSubscriptions->push(new UserResource($user));
}
}
});
return response()->json(array(
'user' => $usersWithUpdatedSubscriptions->toArray()
));
What we're doing here:
chunking to ensure we free some memory.
moved the client instantiation outside of the loop so we're not wasting resources on re-instantiation.
created a simple array to hold reference to our users that we can push into.
reduced redundant queries
leveraged null coalescing to simplify deterministic sub_status logic
moved the return outside of the loop