file_path counts spaces as end of filename [duplicate] - bash
I am trying to save the result from find as arrays.
Here is my code:
#!/bin/bash
echo "input : "
read input
echo "searching file with this pattern '${input}' under present directory"
array=`find . -name ${input}`
len=${#array[*]}
echo "found : ${len}"
i=0
while [ $i -lt $len ]
do
echo ${array[$i]}
let i++
done
I get 2 .txt files under current directory.
So I expect '2' as result of ${len}. However, it prints 1.
The reason is that it takes all result of find as one elements.
How can I fix this?
P.S
I found several solutions on StackOverFlow about a similar problem. However, they are a little bit different so I can't apply in my case. I need to store the results in a variable before the loop. Thanks again.
Update 2020 for Linux Users:
If you have an up-to-date version of bash (4.4-alpha or better), as you probably do if you are on Linux, then you should be using Benjamin W.'s answer.
If you are on Mac OS, which —last I checked— still used bash 3.2, or are otherwise using an older bash, then continue on to the next section.
Answer for bash 4.3 or earlier
Here is one solution for getting the output of find into a bash array:
array=()
while IFS= read -r -d $'\0'; do
array+=("$REPLY")
done < <(find . -name "${input}" -print0)
This is tricky because, in general, file names can have spaces, new lines, and other script-hostile characters. The only way to use find and have the file names safely separated from each other is to use -print0 which prints the file names separated with a null character. This would not be much of an inconvenience if bash's readarray/mapfile functions supported null-separated strings but they don't. Bash's read does and that leads us to the loop above.
[This answer was originally written in 2014. If you have a recent version of bash, please see the update below.]
How it works
The first line creates an empty array: array=()
Every time that the read statement is executed, a null-separated file name is read from standard input. The -r option tells read to leave backslash characters alone. The -d $'\0' tells read that the input will be null-separated. Since we omit the name to read, the shell puts the input into the default name: REPLY.
The array+=("$REPLY") statement appends the new file name to the array array.
The final line combines redirection and command substitution to provide the output of find to the standard input of the while loop.
Why use process substitution?
If we didn't use process substitution, the loop could be written as:
array=()
find . -name "${input}" -print0 >tmpfile
while IFS= read -r -d $'\0'; do
array+=("$REPLY")
done <tmpfile
rm -f tmpfile
In the above the output of find is stored in a temporary file and that file is used as standard input to the while loop. The idea of process substitution is to make such temporary files unnecessary. So, instead of having the while loop get its stdin from tmpfile, we can have it get its stdin from <(find . -name ${input} -print0).
Process substitution is widely useful. In many places where a command wants to read from a file, you can specify process substitution, <(...), instead of a file name. There is an analogous form, >(...), that can be used in place of a file name where the command wants to write to the file.
Like arrays, process substitution is a feature of bash and other advanced shells. It is not part of the POSIX standard.
Alternative: lastpipe
If desired, lastpipe can be used instead of process substitution (hat tip: Caesar):
set +m
shopt -s lastpipe
array=()
find . -name "${input}" -print0 | while IFS= read -r -d $'\0'; do array+=("$REPLY"); done; declare -p array
shopt -s lastpipe tells bash to run the last command in the pipeline in the current shell (not the background). This way, the array remains in existence after the pipeline completes. Because lastpipe only takes effect if job control is turned off, we run set +m. (In a script, as opposed to the command line, job control is off by default.)
Additional notes
The following command creates a shell variable, not a shell array:
array=`find . -name "${input}"`
If you wanted to create an array, you would need to put parens around the output of find. So, naively, one could:
array=(`find . -name "${input}"`) # don't do this
The problem is that the shell performs word splitting on the results of find so that the elements of the array are not guaranteed to be what you want.
Update 2019
Starting with version 4.4-alpha, bash now supports a -d option so that the above loop is no longer necessary. Instead, one can use:
mapfile -d $'\0' array < <(find . -name "${input}" -print0)
For more information on this, please see (and upvote) Benjamin W.'s answer.
Bash 4.4 introduced a -d option to readarray/mapfile, so this can now be solved with
readarray -d '' array < <(find . -name "$input" -print0)
for a method that works with arbitrary filenames including blanks, newlines, and globbing characters. This requires that your find supports -print0, as for example GNU find does.
From the manual (omitting other options):
mapfile [-d delim] [array]
-d
The first character of delim is used to terminate each input line, rather than newline. If delim is the empty string, mapfile will terminate a line when it reads a NUL character.
And readarray is just a synonym of mapfile.
The following appears to work for both Bash and Z Shell on macOS.
#! /bin/sh
IFS=$'\n'
paths=($(find . -name "foo"))
unset IFS
printf "%s\n" "${paths[#]}"
If you are using bash 4 or later, you can replace your use of find with
shopt -s globstar nullglob
array=( **/*"$input"* )
The ** pattern enabled by globstar matches 0 or more directories, allowing the pattern to match to an arbitrary depth in the current directory. Without the nullglob option, the pattern (after parameter expansion) is treated literally, so with no matches you would have an array with a single string rather than an empty array.
Add the dotglob option to the first line as well if you want to traverse hidden directories (like .ssh) and match hidden files (like .bashrc) as well.
you can try something like
array=(`find . -type f | sort -r | head -2`) , and in order to print the array values , you can try something like echo "${array[*]}"
None of these solutions suited me because I didn't feel like learning readarray and mapfile. Here is what I came up with.
#!/bin/bash
echo "input : "
read input
echo "searching file with this pattern '${input}' under present directory"
# The only change is here. Append to array for each non-empty line.
array=()
while read line; do
[[ ! -z "$line" ]] && array+=("$line")
done; <<< $(find . -name ${input} -print)
len=${#array[#]}
echo "found : ${len}"
i=0
while [ $i -lt $len ]
do
echo ${array[$i]}
let i++
done
You could do like this:
#!/bin/bash
echo "input : "
read input
echo "searching file with this pattern '${input}' under present directory"
array=(`find . -name '*'${input}'*'`)
for i in "${array[#]}"
do :
echo $i
done
In bash, $(<any_shell_cmd>) helps to run a command and capture the output. Passing this to IFS with \n as delimiter helps to convert that to an array.
IFS='\n' read -r -a txt_files <<< $(find /path/to/dir -name "*.txt")
Related
for loop displays all elements of array instead of single element [duplicate]
I am trying to save the result from find as arrays. Here is my code: #!/bin/bash echo "input : " read input echo "searching file with this pattern '${input}' under present directory" array=`find . -name ${input}` len=${#array[*]} echo "found : ${len}" i=0 while [ $i -lt $len ] do echo ${array[$i]} let i++ done I get 2 .txt files under current directory. So I expect '2' as result of ${len}. However, it prints 1. The reason is that it takes all result of find as one elements. How can I fix this? P.S I found several solutions on StackOverFlow about a similar problem. However, they are a little bit different so I can't apply in my case. I need to store the results in a variable before the loop. Thanks again.
Update 2020 for Linux Users: If you have an up-to-date version of bash (4.4-alpha or better), as you probably do if you are on Linux, then you should be using Benjamin W.'s answer. If you are on Mac OS, which —last I checked— still used bash 3.2, or are otherwise using an older bash, then continue on to the next section. Answer for bash 4.3 or earlier Here is one solution for getting the output of find into a bash array: array=() while IFS= read -r -d $'\0'; do array+=("$REPLY") done < <(find . -name "${input}" -print0) This is tricky because, in general, file names can have spaces, new lines, and other script-hostile characters. The only way to use find and have the file names safely separated from each other is to use -print0 which prints the file names separated with a null character. This would not be much of an inconvenience if bash's readarray/mapfile functions supported null-separated strings but they don't. Bash's read does and that leads us to the loop above. [This answer was originally written in 2014. If you have a recent version of bash, please see the update below.] How it works The first line creates an empty array: array=() Every time that the read statement is executed, a null-separated file name is read from standard input. The -r option tells read to leave backslash characters alone. The -d $'\0' tells read that the input will be null-separated. Since we omit the name to read, the shell puts the input into the default name: REPLY. The array+=("$REPLY") statement appends the new file name to the array array. The final line combines redirection and command substitution to provide the output of find to the standard input of the while loop. Why use process substitution? If we didn't use process substitution, the loop could be written as: array=() find . -name "${input}" -print0 >tmpfile while IFS= read -r -d $'\0'; do array+=("$REPLY") done <tmpfile rm -f tmpfile In the above the output of find is stored in a temporary file and that file is used as standard input to the while loop. The idea of process substitution is to make such temporary files unnecessary. So, instead of having the while loop get its stdin from tmpfile, we can have it get its stdin from <(find . -name ${input} -print0). Process substitution is widely useful. In many places where a command wants to read from a file, you can specify process substitution, <(...), instead of a file name. There is an analogous form, >(...), that can be used in place of a file name where the command wants to write to the file. Like arrays, process substitution is a feature of bash and other advanced shells. It is not part of the POSIX standard. Alternative: lastpipe If desired, lastpipe can be used instead of process substitution (hat tip: Caesar): set +m shopt -s lastpipe array=() find . -name "${input}" -print0 | while IFS= read -r -d $'\0'; do array+=("$REPLY"); done; declare -p array shopt -s lastpipe tells bash to run the last command in the pipeline in the current shell (not the background). This way, the array remains in existence after the pipeline completes. Because lastpipe only takes effect if job control is turned off, we run set +m. (In a script, as opposed to the command line, job control is off by default.) Additional notes The following command creates a shell variable, not a shell array: array=`find . -name "${input}"` If you wanted to create an array, you would need to put parens around the output of find. So, naively, one could: array=(`find . -name "${input}"`) # don't do this The problem is that the shell performs word splitting on the results of find so that the elements of the array are not guaranteed to be what you want. Update 2019 Starting with version 4.4-alpha, bash now supports a -d option so that the above loop is no longer necessary. Instead, one can use: mapfile -d $'\0' array < <(find . -name "${input}" -print0) For more information on this, please see (and upvote) Benjamin W.'s answer.
Bash 4.4 introduced a -d option to readarray/mapfile, so this can now be solved with readarray -d '' array < <(find . -name "$input" -print0) for a method that works with arbitrary filenames including blanks, newlines, and globbing characters. This requires that your find supports -print0, as for example GNU find does. From the manual (omitting other options): mapfile [-d delim] [array] -d The first character of delim is used to terminate each input line, rather than newline. If delim is the empty string, mapfile will terminate a line when it reads a NUL character. And readarray is just a synonym of mapfile.
The following appears to work for both Bash and Z Shell on macOS. #! /bin/sh IFS=$'\n' paths=($(find . -name "foo")) unset IFS printf "%s\n" "${paths[#]}"
If you are using bash 4 or later, you can replace your use of find with shopt -s globstar nullglob array=( **/*"$input"* ) The ** pattern enabled by globstar matches 0 or more directories, allowing the pattern to match to an arbitrary depth in the current directory. Without the nullglob option, the pattern (after parameter expansion) is treated literally, so with no matches you would have an array with a single string rather than an empty array. Add the dotglob option to the first line as well if you want to traverse hidden directories (like .ssh) and match hidden files (like .bashrc) as well.
you can try something like array=(`find . -type f | sort -r | head -2`) , and in order to print the array values , you can try something like echo "${array[*]}"
None of these solutions suited me because I didn't feel like learning readarray and mapfile. Here is what I came up with. #!/bin/bash echo "input : " read input echo "searching file with this pattern '${input}' under present directory" # The only change is here. Append to array for each non-empty line. array=() while read line; do [[ ! -z "$line" ]] && array+=("$line") done; <<< $(find . -name ${input} -print) len=${#array[#]} echo "found : ${len}" i=0 while [ $i -lt $len ] do echo ${array[$i]} let i++ done
You could do like this: #!/bin/bash echo "input : " read input echo "searching file with this pattern '${input}' under present directory" array=(`find . -name '*'${input}'*'`) for i in "${array[#]}" do : echo $i done
In bash, $(<any_shell_cmd>) helps to run a command and capture the output. Passing this to IFS with \n as delimiter helps to convert that to an array. IFS='\n' read -r -a txt_files <<< $(find /path/to/dir -name "*.txt")
How can I append an entry to an array in a while loop in bash?
When I declare an array in bash $ ARRAY=('ele1' ele2') I can append an element to it with $ ARRAY+=('ele3'). echo ${ARRAY[#]} ele1 ele2 ele3 However, inside a script in a while loop I don't get it to work: FOUNDFILES=$(ls -lA) LINE_CNT=1 ARRAY=() echo -e "$FOUNDFILES" | while read line do ARRAY+=("test") LINE_CNT=$((LINE_CNT+1)) done echo "${ARRAY[#]}" echo $LINE_CNT LINE_CNT variable delivers the amount of files that were found, but my array stays empty. What am I doing wrong?
A few things: Don't assume that find outputs exactly one file name per line; that breaks in the presence of filenames containing newlines. Don't assume that newlines output by find are the only whitespace in the output. Don't use find at all when a glob will do. shopt -s globstar foundfiles=(./**/"$1") declare -a array line_cnt=1 for f in "${foundfiles[#]}"; do array+=(test) line_count=$((line_count + 1)) done If your call to find is more complex than a glob can handle, and your version of find can output null-delimited file names, use # -d for readarray was introduced in bash 4.4; earlier versions # require something more complex; see Gordan Davidson's answer at # https://stackoverflow.com/a/1120952/1126841 readarray -t -d $'\0' < <(find . ... -name "$1" -print0) If your find does not support outputting null-delimited file names, rethink writing this in bash. (You might consider using zsh, which has a vastly richer set of glob features that can eliminate many cases where you would otherwise need find.)
bash loop same variable from multiple configs
I'm trying to loop same variables from multiple files in bash. Here's my file structure and their contents; script.sh first.conf second.conf Inside of first.conf; var=Hello1 Inside of second.conf; var=Hello2 Inside of script.sh; #!/bin/bash _a=`find ~/ -name "*.conf"` source ${_a} for x in ${_a} do echo "$var" done This might look really dumb tho, I'm really new to programming. What I'm trying to do is to loop and echo these $vars from 2 different configs. How can I do that?
Consider: while IFS= read -r -d '' conf; do (source "$conf" && echo "$var") done < <(find ~ -name '*.conf' -print0) Breaking down how this works: The while read syntax is discussed in BashFAQ #1. The variant with -d '' expects input separated by NULs rather than newlines -- more on that later. Putting (source "$conf" && echo "$var") in parens prevents side effects on the rest of your script -- while this has a performance cost, it ensures that variables added by source are only present for the echo. Using the && prevents the echo from running if the source command fails. <(...) is process substitution syntax; it's replaced with a filename that can be read to retrieve the output of the command therein (in this case find). Using this syntax rather than piping into the loop avoids the bugs discussed in BashFAQ #24. The -print0 action in find prints the name of the file found, followed by a NUL character -- a zero byte. What's useful about NUL bytes is that, unlike any other ASCII character, they can't exist in UNIX paths; using them thus prevents your code from being subject to trickery (think about someone running d=$'./tmp/\n/etc/passwd\n' && mkdir -p -- "$d" && touch "$d/hi.conf" -- traditional find output would have /etc/passwd showing up on its own line, but with find -print0, the newlines in the name aren't mistaken for a separator between files.
This is a shorter and simpler way. #!/bin/bash for f in *.conf do source "$f"; echo "$f : $var" done
Assign files in a list when using the bash find command
Im trying to see if I can assign the output of the find command to a variable. In this case it would be a list and iterate one file at a time to evaluate the file. Ive tried this: #!/bin/bash PATH=/Users/mike/test LIST='find $PATH -name *.txt' for newfiles in #LIST; do #checksize echo $newfiles done My output is: #LIST Im trying to do the same this as the glob command in perl in bash. var = glob "PATH/*.txt";
Use $(command) to execute command and substitute its output in place of that construct. list=$(find "$PATH" -name '*.txt') And to access a variable, put $ before the name, not # (your perl experience is showing). for newfiles in $list; do echo "$newfiles" done However, it's dangerous to parse the output of find like this, because you'll get incorrect results if any of the filenames contain whitespace -- it will be treated as multiple names. It's better to pipe the output: find "$PATH" -name '*.txt' | while read -r newfiles; do echo "$newfiles" done Also, notice that you should quote any variables that you don't want to be split into multiple words if they contain whitespace. And avoid using all-uppercase variable names. This is conventionally reserved for environment variables.
LIST=$(find $PATH -name *.txt) for newfiles in $LIST; do Beware that you will have issues if any of the files have whitespace in the names.
Assuming you are using bash 4 or later, don't use find at all here. shopt -s globstar nullglob list=( "$path"/**/*.txt ) for newfile in "${list[#]}"; do echo "$newfile" done
for loop to iterate over lines in string
I have a string that has multiple lines. I want to read each line and do something with it. filelist=<some function that runs ls -1 on multiple servers> for file in $filelist do echo $file | do_something done Unfortunately, it doesn't separate the lines. If I replace filelist with $(ls -1), then it works.
Try to set IFS: IFS= ;x=$(ls -1) ; IFS=$'\n' ;for i in $x ; do echo i=$i ; done
Don't parse ls and use quotes around your variables. Like echo "$file" | do_something So, if we cannot parse ls, then how can we solve it? Well, this is a common question, so it is answered here. Here is a quote from it: # Bash unset a i while IFS= read -r -d '' file; do a[i++]="$file" done < <(find /tmp -type f -print0) The preceding example reads all the files under /tmp (recursively) into an array, even if they have newlines or other whitespace in their names, by forcing read to use the NUL byte (\0) as its line delimiter. Since NUL is not a valid byte in Unix filenames, this is the safest approach besides using find -exec. IFS= is required to avoid trimming leading/trailing whitespace, and -r is needed to avoid backslash processing. We don't know how do you retrieve a file list from your server, so I cannot help you futher. But it should be simple, you just replace your ls command by find and that's it. Also you might want to check out man find to see how could you stop it from doing it recursively(in case you don't want that).