Authentication Manager is NoOpAuthenticationManager when method security operation. Why? - spring

I set up Spring Security with a custom Authentication Provider.
Custom authentication works normally if method security (such as #Secured) is not set.
But when I set up Method Security, AuthenticationServiceException occurs.
I tried debugging.
authenticationManager.authenticate was called once more upon entering a controller with method security enabled. However, the authentication manager was empty(=NoOpAuthenticationManager) at this time.
I called the API below.
#RestController
#RequestMapping("/test")
#Secured("ROLE_USER")
class TestController

I found a solution.
I had set the setting as below.
spring:
main:
lazy-initialization: true
I think the cause was an lazy injection.

Related

Spring-security 6 - 403 denied because AuthenticationProvider not called

I've recently upgraded a project from using spring-security 6.0.0-M6 to 6.0.0, gradle config if you want to see it.
This project does not use spring-boot.
Context
My securityFilterChain is configured via code and looks approximately like this:
http.
authenticationManager(authnManager).
securityContext().securityContextRepository(securityRepo).
and().
authorizeRequests(). // <-- DEPRECATED
requestMatchers(RAID_V2_API + "/**").fullyAuthenticated().
The full codebase, starting with the FilterChain config, is publicly available.
Note that usage of WebSecurityConfigurerAdapter is deprecated, and I have not been using it since the original usage of 6.0.0-M6. So calling stuff like WebSecurityConfigurerAdapter.authenticationManagerBean() won't work.
This code works fine, but the call to authorizeRequests() causes a deprecation warning that I want to get rid of.
Problem
The deprecation tag says that I should use authorizeHttpRequests() instead, but when I do that - requests that require authorization (via the fullyAuthenticated() specification above) will be denied with a 403 error.
Analysis
It seems this happens because my AuthenticationProvider instances aren't being called,
because the ProviderManager isn't being called. Since the AuthnProviders don't get called, the security context still contains the pre-auth token instead of a verified post-auth token, so the eventual call to AuthorizationStrategy.isGranted() ends up calling isAuthenticated() on the pre-auth token, which (correctly) returns false and the request is denied.
Question
How do I use the authorizeHttpRequests() method but still have the ProviderManager be called so that my security config works?
My workaround is just to ignore the deprecation warning.
First, your security configuration does not specify any kind of authentication, like httpBasic, formLogin, etc. The AuthenticationManager is invoked by the filters created by those authentication mechanisms in order to authenticate credentials.
Second, the application is probably unwittingly relying on FilterSecurityInterceptor (authorizeRequests) to authenticate the user, which is not supported with authorizeHttpRequests. You need to declare an auth mechanism that collects credentials from the request and authenticates the user.
Because you are using JWT, you might want to consider Spring Security's OAuth2 Resource Server support. You can also refer to our samples repository in order to help you with sample configurations.
Here's a rough outline of what I did to to implement the "just use the resource server" suggestion from the answer.
include the oauth2-resource-server libraries in the build.
create an AuthenticationManagerResolver that replaces what the SecuritycontextRepository and the FilterSecurityInterceptor used to do:
#Bean
public AuthenticationManagerResolver<HttpServletRequest>
tokenAuthenticationManagerResolver(
AuthenticationProvider authProvider
) {
return (request)-> {
return authProvider::authenticate;
};
}
change AuthenticationProvider implementations to use the BearerTokenAuthenticationToken class as the pre-auth token, it still works basically the same way it used to: verifying the pre-auth token and returning a post-auth token.
hook up the new resolver class in the securityFilterChain config by replacing the old securityContextRepository() config with the new authenticationManagerResolver() config, which passes in the resolver created in step 2:
http.oauth2ResourceServer(oauth2 ->
oauth2.authenticationManagerResolver(tokenAuthenticationManagerResolver) );
I like this new approach because it makes it more obvious how the security chain works.
It's nice to replace the custom pre-auth token implementation with the built-in class too.
Note that it's likely this config can be simplified, but I needed the custom resolver since the project uses different types of bearer token depending on the endpoint called. Pretty sure the auth providers don't need to be AuthenticationProvider any more; the lambda function returned from the resolver serves that purpose - they can probably just be random spring components and as long as the method is SAM-type compatible.
The spring-security multi-tenancy doco was helpful for this.

what is the filter responsible for keeping the authentication object in security context in spring security

to my knowledge the most of the authentication filter extends AbstractAuthenticationProcessingFilter and overrides attemptAuthentication method which is called in dofilter method but i do not see how the authentication object is placed in securitycontext because the sessionstrategy in abstractauthenticationprocessinfilter is set to NullAuthenticatedSessionStrategy which does not do any thing in onAuthentication method so how does the security exactly work
You are right. AbstractAuthenticationProcessingFilter is responsible for placing Authentication to the SecurityContext.It is done inside successfulAuthentication(). Its javadoc also states such behaviour :
Default behaviour for successful authentication.
Sets the successful Authentication object on the SecurityContextHolder
Informs the configured RememberMeServices of the successful login
Fires an InteractiveAuthenticationSuccessEvent via the configured ApplicationEventPublisher
Delegates additional behaviour to the AuthenticationSuccessHandler.
The SessionAuthenticationStrategy you mentioned (which is set to NullAuthenticatedSessionStrategy by default) is for plugging other HttpSession-related behaviour when authentication occurs such as to ensure session exists or guard against session-fixation attacks. The default behaviour (i.e. successfulAuthentication()) will always run no matter what strategy it is set to.

Custom principal and scopes using Spring OAuth 2.0

I am using SpringBoot 2.0.5 and Spring Security OAuth to implement an OAuth 2.0 server and a set of client microservices.
In the AuthServer:
I have implemented the UserDetailsService so I can provide my custom enriched principal.
For the userInfoUri controller endpoint, I return user (my principal) and authorities as a map.
In the Client:
I have implemented PrincipalExtractor to extract and create my custom principal.
For each of the methods I require the principal, I use the following notation:
public List<Message> listMessages(#AuthenticationPrincipal MyPrincipal user)
This works (and I hope it's the right way) but now I'm having an issue to secure methods using scopes.
For example, if I want to have a controller method which is only accessible by another server (using client_credentials), I mark the method with the following annotation:
#PreAuthorize("#oauth2.hasScope('trust')")
But this results in an access error as I think the scope is not being transferred. I have added the scope to the userInfoUri endpoint but am unsure what I need to do on the client side so the scope is picked up.
Any pointers or example code would be very much appreciated.

Spring SAML CurrentUserHandler not working

I have implemented the SAML configurations as mentioned in https://github.com/vdenotaris/spring-boot-security-saml-sample but its not populating the '#CurrentUser User user' in the landing controller method. loadUserBySAML() of SAMLUserDetailsServiceImpl gets SAMLCredential properly.
I have XML based MvcConfig,whereas the WebSecurityConfig(for SAML) is Java based Config. Have added 'bean class = "CurrentUserHandlerClass' in 'mvc:argumentresolvers'. So while invoking the landing Controller method below exception is thrown
please help me out and comment it if you require something
Its now solved as the controller URL was missing in the securitychainfilter

Authentication object not found thrown by DispatcherServlet before #Preauthorize spring security annotation is applied

When i am trying to use #PreAuthorize("#accessControl.hasActivity('abc')") on spring controller method i am getting Authentication object was not found in security context.
After debugging found that DispactcherServlet is throwing this exception.
i have set SecurityContextHolder.setStrategyName(SecurityContextHolder.MODE_THREADLOCAL);
when i first create Authentication object and set in security context
Also tried with SecurityContextHolder.setStrategyName(SecurityContextHolder.MODE_INHERITABLETHREADLOCAL); but no luck still it does not work.
I am not able to understand why spring is servlet is throwing this exception
First, doing authentication in a Spring MVC interceptor is odd. Consider using a filter before DispatcherServlet. There is a lot of documented examples.
Secondly, SecurityContextHolder.setStrategyName re-initializes the strategy and possibly makes all previously authentications inaccessible so you must only call it once (if any time), before any authentication is made.
Thirdly, if you want to set the current authentication to be used by #PreAuthorize and are sure what you are doing, use SecurityContextHolder.getContext().setAuthentication(anAuthentication);. In most cases, there is a suitable filter in the API that already does this for you.

Resources