Issue while dealing refactoring some code to rich-domain model - spring-boot

Question

I was reading about rich vs anemic domain models and wanted to convert an existing anemic domain model into a rich domain model. However, springboot dependecy injection is in the way. How can I fix this? What is the correct approach to refactor an anemic domain model to a rich domain model?
I though about adding a public default constructor but wouldn't that violate the rules for rich-domain models and also it would mean that I can't mark gameId/the list of scores as final?
Error
Parameter 0 of constructor in Score required a bean of type 'java.lang.String' that could not be found.
no qualifying bean of type 'java.lang.String'
Original
#Service
public class ScoreService {
private final Map<String, List<BatsmanScore>> scores;
public ScoreService(Map<String, List<BatsmanScore>> scores) {
this.scores = scores;
}
public List<BatsmanScore> getBatsmanScores(String gameId) {
return scores.get(gameId);
}
public void storeScores(String gameId, List<BatsmanScore> batsmanScores) {
if (!scores.containsKey(gameId)) {
scores.put(gameId, new ArrayList<>());
}
scores.get(gameId).addAll(batsmanScores);
}
}
public class Score {
private List<BatsmanScore> batsmanScores;
private String gameId;
public Score() { }
public Score(String gameId, List<BatsmanScore> batsmanScores) {
this.gameId = gameId;
this.batsmanScores = batsmanScores;
}
public List<BatsmanScore> getBatsmanScores() {
return batsmanScores;
}
public String getGameId() {
return gameId;
}
}
Modified
#Service
public class ScoreService {
private final Score score;
public ScoreService(Score score) {
this.score = score;
}
public List<BatsmanScore> getBatsmanScores(String gameId) {
return score.getBatsmanScoreByGameId(gameId);
}
public void storeScores(String gameId, List<BatsmanScore> batsmanScores) {
score.storeGameScore(gameId, batsmanScores);
}
}
#Repository
public class Score {
private final Map<String, List<BatsmanScore>> scoreRepository = new HashMap<>();
private final List<BatsmanScore> batsmanScores;
private final String gameId;
public Score(String gameId, List<BatsmanScore> batsmanScores) {
this.gameId = gameId;
this.batsmanScores = batsmanScores;
}
public List<BatsmanScore> getBatsmanScores() {
return batsmanScores;
}
public List<BatsmanScore> getBatsmanScoresByGameId(String gameId) {
return scoreRepository.get(gameId);
}
public String getGameId() {
return gameId;
}
public void storeScores(String gameId, List<BatsmanScore> batsmanScores) {
if (!scoreRepository.containsKey(gameId)) {
scoreRepository.put(gameId, new ArrayList<>());
}
scoreRepository.get(gameId).addAll(batsmanScores);
}
}

Answer 1

Anemic domain model is when the business logic is in the services, but here it already is in the domain model, in the form of the Score.addAll() method:
public class Score {
private List<BatsmanScore> batsmanScores;
private String gameId;
public Score() { }
public Score(String gameId, List<BatsmanScore> batsmanScores) {
this.gameId = gameId;
this.batsmanScores = batsmanScores;
}
public List<BatsmanScore> getBatsmanScores() {
return batsmanScores;
}
public String getGameId() {
return gameId;
}
public void addAll(List<BatsmanScore> batsmanScores)
{
if (this.batsmanScores == null) {
this.batsmanScores = new ArrayList<BatsmanScore>();
}
foreach(BatsmanScore score in batsmanScores) {
// you can implement some more business logic here
this.batsmanScores.Add(score);
}
}
}
However, your are messing your repository and your service. The service usually handles the use case and orchestrate operations around the repository and the domain model:
#Service
public class AddScoreUseCase {
private final IScoreRepository repository;
public AddScoreUseCase(IScoreRepository repository) {
this.repository = repository;
}
public void storeScores(String gameId, List<BatsmanScore> batsmanScores) {
Score score = repository.getByGameId(gameId);
score.addAll(batsmanScores);
repository.saveChanges(score);
}
}
The repository is responsible to translate domain operations into the persistence. Here is an example of an in-memory persistence but you could also write a database repository, that would retrieve and store data from the database:
#Repository
public class InMemoryScoreRepository implements IScoreRepository {
private final Map<String, List<BatsmanScore>> scoreRepository = new HashMap<>();
public InMemoryScoreRepository() {
}
public Score getByGameId(String gameId) {
if (!data.containsKey(gameId)) {
return new Score(gameId, new ArrayList<>());
}
return new Score(gameId, this.data[gameId]);
}
public void saveChanges(Score score) {
if (!this.data.containsKey(score.getGameId())) {
scoreRepository.put(score.getGameId(), score.getBatsmanScores());
} else {
this.data[score.getGameId()] = score.getBatsmanScores();
}
}
}