Assume tables:
CREATE TABLE users (id INT, name VARCHAR(255))
CREATE TABLE user_roles (user_id INT REFERENCES users(id), role_name VARCHAR(255))
Entity in Room:
#Entity(tableName = "users")
data class User(
#PrimaryKey
val id: Int,
val roles: Set<String> // want it from role_name column
)
Second entity (if needed):
#Entity(tableName = "user_roles")
data class UserRole(
val user_id: Int,
val role_name: String
)
DAO
#Dao
interface UserDao {
#Query("SELECT * FROM users")
fun getAllUsers(): Flow<List<User>>
}
This will not compile because SQLite doesn't support collections. Is there any way to map the role_name from user_roles to roles property of User entity? Can Room do it automatically?
I don't think Room has automatic support for that requirement. Instead you could do a custom query to achieve that.
Refer to this example of how to do one, and adapt according to your requirements.
getAllUsersWithRoles returns flow of list of UserWithRoles. Query joins users and user_roles tables and maps results to UserWithRolesResult class.
fromResult takes list of UserWithRolesResult and maps it to list of UserWithRoles
#Dao
interface UserDao {
#Transaction
#Query("SELECT * FROM users")
fun getAllUsersWithRoles(): Flow<List<UserWithRoles>>
companion object {
private fun fromResult(result: List<UserWithRolesResult>) : List<UserWithRoles> {
val map = result.groupBy { it.userId }.mapValues { it.value.map { it.roleName }.toSet() }
return map.map { UserWithRoles(it.key, it.value) }
}
}
}
data class UserWithRoles(
val userId: Int,
val roles: Set<String>
)
data class UserWithRolesResult(
val userId: Int,
val roleName: String
)
This will not compile because SQLite doesn't support collections.
Room however does.
Consider the following working Demo based upon your code
note the comments and modifications
run on the main thread for brevity
the POJO UserWithRoles is the main inclusion that uses a Set, which is populated/used
:-
#Entity(tableName = "users")
data class User(
#PrimaryKey
val id: Int,
val name: String
/* roles would be effectively trying to store what is stored elsewhere */
//val roles: Set<String> // want it from role_name column !! Wrong place see UserWithRoles
)
#Entity(
tableName = "user_roles",
foreignKeys = [
ForeignKey(
entity = User::class,
parentColumns = ["id"],
childColumns = ["user_id"]
)
]
)
data class UserRole(
#PrimaryKey
/* In Room and Entity MUST have a primary key */
/* if user_id were a primary key then many UserRoles per User would not be allowed as
a primary key is implicitly UNIQUE. Hence dummy_id
*/
val dummy_id: Long?=null,
val user_id: Int,
val role_name: String
)
data class UserWithRoles(
#Embedded
val user: User,
#Relation(entity = UserRole::class, parentColumn = "id", entityColumn = "user_id" )
val roles: Set<UserRole>
)
#Dao
interface UserDao {
#Insert(onConflict = OnConflictStrategy.IGNORE)
fun insert(user: User): Long
#Insert(onConflict = OnConflictStrategy.IGNORE)
fun insert(userRole: UserRole): Long
#Query("SELECT * FROM users")
fun getAllUsers(): /*Flow<*/List<UserWithRoles>/*>*/
}
#Database(entities = [User::class,UserRole::class], exportSchema = false, version = 1)
abstract class TheDatabase: RoomDatabase() {
abstract fun getUserDao(): UserDao
companion object {
private var instance: TheDatabase?=null
fun getInstance(context: Context): TheDatabase {
if (instance==null) {
instance=Room.databaseBuilder(context,TheDatabase::class.java,"the_database.db")
.allowMainThreadQueries() /* for brevity of demo */
.build()
}
return instance as TheDatabase
}
}
}
and some Activity Code to demonstrate:-
class MainActivity : AppCompatActivity() {
lateinit var db: TheDatabase
lateinit var dao: UserDao
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_main)
db = TheDatabase.getInstance(this)
dao = db.getUserDao()
dao.insert(User(10,"Fred"))
dao.insert(User(11,"Mary"))
dao.insert(User(12,"Jane"))
dao.insert(UserRole(user_id = 10, role_name = "Role1"))
dao.insert(UserRole(user_id = 10, role_name = "Role2"))
dao.insert(UserRole(user_id = 10, role_name = "Role3"))
dao.insert(UserRole(user_id = 11, role_name = "Role4"))
for (uwr in dao.getAllUsers()) {
val sb = StringBuilder()
for (r in uwr.roles) {
sb.append("\n\tRole is ").append(r.role_name)
}
Log.d("DBINFO","User is ${uwr.user.name} and has ${uwr.roles.size} roles. They are ${sb}")
}
}
}
When run then the log includes:-
D/DBINFO: User is Fred and has 3 roles. They are
Role is Role3
Role is Role2
Role is Role1
D/DBINFO: User is Mary and has 1 roles. They are
Role is Role4
D/DBINFO: User is Jane and has 0 roles. They are
Related
I have log in app with pre populated database (ROOM).
When i'm logging in I need to check email and password in database then after that if email and password are correct, show final fragment. But i have error which is higher.
I was searching but nothing helps me.
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
binding.continuebutton.setOnClickListener {
if(binding.EmailSpace.length() == 0){
Toast.makeText(context,"Поле пустое введите email",Toast.LENGTH_SHORT).show()
}
if(binding.PasswordSpace.length() == 0){
Toast.makeText(context,"Поле пустое введите пароль",Toast.LENGTH_SHORT).show()
}
if(binding.PasswordSpace.length() <8){
Toast.makeText(context,"Пароль слишком короткий",Toast.LENGTH_SHORT).show()
}
val espace = binding.EmailSpace.text.toString()
val pspace = binding.EmailSpace.text.toString()
if(espace.isNotEmpty() && pspace.isNotEmpty()){
check(espace == "admin#gmail.com")
check(pspace == "12345678")
scope.launch {
db.getDAO().findbyEmail(espace)
db.getDAO().findbypassword((pspace))
}
findNavController().navigate(R.id.action_loginFragment_to_lastfragment)
} else{
Toast.makeText(context,"Данные введены не верно",Toast.LENGTH_SHORT)
}
}
}
This is a fragment in which i'm checking edittexts for empty.
AdminDatabaseclass
import Room.DAO.DAO
import Room.Repository.Admindata
import android.content.Context
import androidx.room.Database
import androidx.room.Room
import androidx.room.RoomDatabase
#Database (entities = [Admindata::class], version = 1, exportSchema = true)
abstract class AdminDatabase:RoomDatabase(){
abstract fun getDAO(): DAO
companion object{
fun getadminDB(context: Context):AdminDatabase{
return Room.databaseBuilder(context.applicationContext,AdminDatabase::class.java,"admindb").createFromAsset("SQLDB/dbforpetproject.db").build()
}
}
DAO
#Dao
interface DAO {
#Query("select email from admindb where email = :email")
suspend fun findbyEmail(email:String) : Admindata
#Query("select password from admindb where password = :password")
suspend fun findbypassword(password:String) : Admindata
}
Admindata
#Entity(tableName= "admindb")
data class Admindata(
#PrimaryKey
val id:Int = 1,
#ColumnInfo(name = "email")
val email:String = "admin#gmail.com",
#ColumnInfo(name = "password")
val password :String = "12345678"
)
Error after launching how it looks like enter image description here
Another one screenshot enter image description here
You want to use
#Dao
interface DAO {
#Query("select * from admindb where email = :email")
suspend fun findbyEmail(email:String) : Admindata
#Query("select * from admindb where password = :password")
suspend fun findbypassword(password:String) : Admindata
}
Then the Admindata returned will have all the values from the database rather than just the email (findbyEmail) or the password (findbyPassword).
The * represents all columns, which is the equivalent of SELECT id, email, password FROM admindb ....
I would like to get one single entry from database. I have such entry model:
#Table("USERS")
data class User(#Id val id: String?, val login: String, val password: String)
and such controller:
#RestController
class MessageResource(val service: MessageService) {
#GetMapping
fun index(): List<User> = service.findMessages()
#PostMapping
fun post(#RequestBody user: User) {
service.post(user)
}
#GetMapping("/user")
fun getByLogin(#RequestParam("login") login: String): User? = service.getByUser(login)
}
such service:
#Service
class MessageService(val db: MessageRepository) {
fun findMessages(): List<User> = db.findMessages()
fun post(user: User) {
db.save(user)
}
fun getByUser(login: String) = db.getByUser(login)
}
and repository:
interface MessageRepository : CrudRepository<User, String> {
#Query("select * from users")
fun findMessages(): List<User>
#Query(value = "select * from users")
fun getByUser(login: String): User? {
val sql = "SELECT * FROM users WHERE login = $login"
return JdbcTemplate().queryForObject(sql, User::class.java)
}
}
I'm little bit new in SprinBoot and I'm trying to get one entry from database. I tried to run it in repository getByUser method, by received error:
org.springframework.dao.IncorrectResultSizeDataAccessException: Incorrect result size: expected 1, actual 4
maybe I did it in wrong way and I have to use another method for filtering all table by row value?
The method JdbcTemplate().queryForObject in repository expected to return only 1 row by the SELECT statement.
If your statement is returning multiple results, you should consider to use JdbcTemplate().query and the getByUser() method in repository should return List<User>.
query doc
fun getByUser(login: String): List<User>? {
val sql = "SELECT * FROM users WHERE login = $login"
return JdbcTemplate().query(sql, new BeanPropertyRowMapper(User::class.java))
}
If you expected only one record returned by database. Here is another easier solution.
If you are using mysql:
fun getByUser(login: String): User? {
val sql = "SELECT * FROM users WHERE login = $login limit 1"
return JdbcTemplate().queryForObject(sql, User::class.java)
}
If you are using Oracle:
fun getByUser(login: String): User? {
val sql = "SELECT * FROM users WHERE login = $login and rownum=1"
return JdbcTemplate().queryForObject(sql, User::class.java)
}
I am not sure whether this is a bug or I am using Persistable incorrectly.
Aim: make the UserId non-null to avoid having to assert non-null when using in the code
User.kt
#Table(value = "main.user")
data class User(
#Id
#Column("id")
var userId: UUID = UUID(0,0),
val username: Username,
val isVerified: Boolean = false,
val updated: LocalDateTime,
val updatedBy: String
) : Persistable<UUID> {
override fun isNew(): Boolean = userId.equals(UUID(0,0))
override fun getId(): UUID = userId
}
UserRepository.kt
#Repository
interface UserModelRepository : CoroutineCrudRepository<User, UUID>
Test.kt
#DataR2dbcTest
internal class Test {
#Autowired
private lateinit var userModelRepository: UserModelRepository
#Test
fun `should save the user model`() = runBlocking {
val userModel = createUserModel()
val actual = UserModelRepository.save(userModel)
actual.userId shouldNotBe UUID(0, 0)
}
}
SQL
CREATE TABLE IF NOT EXISTS main.user
(
id UUID NOT NULL PRIMARY KEY DEFAULT GEN_RANDOM_UUID(),
username CHARACTER VARYING(70) NOT NULL UNIQUE,
is_verified BOOLEAN NOT NULL,
updated TIMESTAMP WITHOUT TIME ZONE NOT NULL,
updated_by CHARACTER VARYING(255) NOT NULL
);
Expected: The test to pass as the Id should be generated by the database
Actual: Id is "00000000-0000-0000-0000-000000000000"
Spring Data uses the same object reference to apply the update of the ID at. Since you set the ID to a final value Spring Data can't apply a new generated ID to it. The ID will also only be generated if the value is null otherwise the value which is already set will be used.
There is a workaround:
#Table("my_user")
data class MyUser(
#Id
#Column("id")
private var _id: UUID? = null,
val name: String = "blubb"
) {
val id: UUID
get() = _id ?: UUID(0, 0)
}
But it is basically bad practice as answered here.
EDIT: 09/30
Thanks to #shb, I've determined that createFromFile() is not properly populating the database as intended.
If anyone can point out what I'm doing wrong/missing, that would be great! Please refer to the below picture for reference on the database structure. Thanks in advance!
MainActivity
class MainActivity: AppCompatActivity() {
lateinit var mDatabase: AppDatabase
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_main)
mDatabase = AppDatabase.getInstance(this)
}
fun getFacilityNbr() {
val planInfo = mDatabase.getPlanInfoDao().getPlanInfo()
Log.d("MainActivity", "Size = ${planInfo.size}") // 0
}
}
AppDatabase
#Database(entities = [PlanInfo::class], version = 1)
abstract class AppDatabase: RoomDatabase() {
companion object {
#Volatile private var instance: AppDatabase? = null
val file = File("${Environment.getExternalStorageDirectory()}/appdata/pla/assignment-file/test.db")
Log.d("App Database", "Is valid file? - ${file.isFile}") // true
fun getInstance(context Context) = instance ?: synchronized(this) {
instance ?: Room.databaseBuilder(context.applicationContext, AppDatabase::class.java, "MyDb")
.createFromFile(File("path/to/my/test.db"))
.allowMainThreadQueries()
.build().also { instance = it }
}
abstract fun getPlanInfoDao(): PlanInfoDao
}
PlanInfoDao
#Dao
interface PlanInfoDao {
#Query("SELECT * FROM PlanInfo")
fun getPlanInfo(): List<PlanInfo>
}
PlanInfo
#Entity
data class PlanInfo (
#PrimaryKey
#ColumnInfo(name = "Facility_Nbr")
val facilityNbr: String
)
#Query("SELECT * FROM PlanInfo")
It returns a list of PlanInfo
Change return type to List<PlanInfo>
#Query("SELECT * FROM PlanInfo")
fun getPlanInfo(): List<PlanInfo>
Or you might wanna rewrite your query like below.
#Query("SELECT * FROM PlanInfo where Lifecycle_ID= :lifeCycleId")
fun getPlanInfo(lifeCycleId: String): PlanInfo
EDIT
In doubt, you make sure that there is data in that table, try inserting a row successfully before fetching in your code. Make sure its there.
I used the framework "https://github.com/ExpediaGroup/graphql-kotlin" to learn graphql programming of kotlin under springframework.
I used DataLoader&BatchLoader to resolve the 'N+1' loading problem.
When the scope of DataLoader objects is singleton, it works, but it's not my goal because temporary cache mechanism should not be bridging over different requests.
Then I changed the scope of DataLoader objects to be prototype, in all probability, the graphql query may be blocking and associated objects will not be loaded, client waits the response forever.
What's the reason and how can I resolve it?
I did it like this:
Create a simple springboot application, add maven dependency of graph-kotlin
<dependency>
<groupId>com.expediagroup</groupId>
<artifactId>graphql-kotlin-spring-server</artifactId>
<version>2.0.0.RC3</version>
</dependency>
Create two model classes(Note: Their code will be changed in the final step)
data class Department(
val id: Long,
val name: String
)
data class Employee(
val id: Long,
val name: String,
#GraphQLIgnore val departmentId: Long
)
Create two mocked repository objects
val DEPARTMENTS = listOf(
Department(1L, "Develop"),
Department(2L, "Test")
)
val EMPLOYEES = listOf(
Employee(1L, "Jim", 1L),
Employee(2L, "Kate", 1L),
Employee(3L, "Tom", 2L),
Employee(4L, "Mary", 2L)
)
#Repository
open class DepartmentRepository {
companion object {
private val LOGGER = LoggerFactory.getLogger(DepartmentRepository::class.java)
}
open fun findByName(namePattern: String?): List<Department> = //For root query
namePattern
?.takeIf { it.isNotEmpty() }
?.let { pattern ->
DEPARTMENTS.filter { it.name.contains(pattern) }
}
?: DEPARTMENTS
open fun findByIds(ids: Collection<Long>): List<Department> { // For assciation
LOGGER.info("BatchLoad departments by ids: [${ids.joinToString(", ")}]")
return DEPARTMENTS.filter { ids.contains(it.id) }
}
}
#Repository
open class EmployeeRepository {
companion object {
private val LOGGER = LoggerFactory.getLogger(EmployeeRepository::class.java)
}
open fun findByName(namePattern: String?): List<Employee> = //For root query
namePattern
?.takeIf { it.isNotEmpty() }
?.let { pattern ->
EMPLOYEES.filter { it.name.contains(pattern) }
}
?: EMPLOYEES
open fun findByDepartmentIds(departmentIds: Collection<Long>): List<Employee> { // For association
LOGGER.info("BatchLoad employees by departmentIds: [${departmentIds.joinToString(", ")}]")
return EMPLOYEES.filter { departmentIds.contains(it.departmentId) }
}
}
Create a graphql query object to export root query operations
#Service
open class OrgService(
private val departmentRepository: DepartmentRepository,
private val employeeRepository: EmployeeRepository
) : Query {
fun departments(namePattern: String?): List<Department> =
departmentRepository.findByName(namePattern)
fun employees(namePattern: String?): List<Employee> =
employeeRepository.findByName(namePattern)
}
Create an abstract class for many-to-one associated object loading
abstract class AbstractReferenceLoader<K, R: Any> (
batchLoader: (Collection<K>) -> Collection<R>,
keyGetter: (R) ->K,
optionsInInitializer: (DataLoaderOptions.() -> Unit) ? = null
): DataLoader<K, R?>(
{ keys ->
CompletableFuture.supplyAsync {
batchLoader(keys)
.associateBy(keyGetter)
.let { map ->
keys.map { map[it] }
}
}
},
optionsInInitializer?.let {
DataLoaderOptions().apply {
this.it()
}
}
)
Create an abstract class for one-to-many associated collection loading
abstract class AbstractListLoader<K, E>(
batchLoader: (Collection<K>) -> Collection<E>,
keyGetter: (E) ->K,
optionsInInitializer: (DataLoaderOptions.() -> Unit) ? = null
): DataLoader<K, List<E>>(
{ keys ->
CompletableFuture.supplyAsync {
batchLoader(keys)
.groupBy(keyGetter)
.let { map ->
keys.map { map[it] ?: emptyList() }
}
}
},
optionsInInitializer?.let {
DataLoaderOptions().apply {
this.it()
}
}
)
Create annotation to let spring manager DataLoader beans by prototype scope
#Retention(RetentionPolicy.RUNTIME)
#Target(AnnotationTarget.CLASS)
#Component
#Scope(
ConfigurableBeanFactory.SCOPE_PROTOTYPE,
proxyMode = ScopedProxyMode.NO
)
annotation class DataLoaderComponent
Create loader bean to load the parent object reference of Employee object
#DataLoaderComponent
open class DepartmentLoader(
private val departmentRepository: DepartmentRepository
): AbstractReferenceLoader<Long, Department>(
{ departmentRepository.findByIds(it) },
{ it.id },
{ setMaxBatchSize(256) }
)
Create loader bean to load the child object collection of Department object
#DataLoaderComponent
open class EmployeeListByDepartmentIdLoader(
private val employeeRepository: EmployeeRepository
): AbstractListLoader<Long, Employee>(
{ employeeRepository.findByDepartmentIds(it) },
{ it.departmentId },
{ setMaxBatchSize(16) }
)
Create an GraphQL configuration to let 'graphql-kotlin' know all the DataLoader beans
#Configuration
internal abstract class GraphQLConfig {
#Bean
open fun dataLoaderRegistryFactory(): DataLoaderRegistryFactory =
object: DataLoaderRegistryFactory {
override fun generate(): DataLoaderRegistry = dataLoaderRegistry()
}
#Bean
#Scope(
ConfigurableBeanFactory.SCOPE_PROTOTYPE,
proxyMode = ScopedProxyMode.NO
)
protected open fun dataLoaderRegistry(
loaders: List<DataLoader<*, *>>
): DataLoaderRegistry =
DataLoaderRegistry().apply {
loaders.forEach { loader ->
register(
loader::class.qualifiedName,
loader
)
}
}
#Lookup
protected abstract fun dataLoaderRegistry(): DataLoaderRegistry
}
Add tow methods into DataFetchingEnvironment to get DataLoader objects
inline fun <reified L: AbstractReferenceLoader<K, R>, K, R> DataFetchingEnvironment.getReferenceLoader(
): DataLoader<K, R?> =
this.getDataLoader<K, R?>(L::class.qualifiedName)
inline fun <reified L: AbstractListLoader<K, E>, K, E> DataFetchingEnvironment.getListLoader(
): DataLoader<K, List<E>> =
this.getDataLoader<K, List<E>>(L::class.qualifiedName)
Change the code of Department and Employee, let them support association
data class Department(
val id: Long,
val name: String
) {
suspend fun employees(env: DataFetchingEnvironment): List<Employee> =
env
.getListLoader<EmployeeListByDepartmentIdLoader, Long, Employee>()
.load(id)
.await()
}
data class Employee(
val id: Long,
val name: String,
#GraphQLIgnore val departmentId: Long
) {
suspend fun department(env: DataFetchingEnvironment): Department? =
env
.getReferenceLoader<DepartmentLoader, Long, Department>()
.load(departmentId)
.await()
}
Build & Run
Start the SpringBoot applications, open http://locathost:8080/playground.
Execute the query, the result may be success or failed!
{
employees {
id
name
department {
id
name
employees {
id
name
}
}
}
}
If it is success, the client can get the response, and the server log is
2020-03-15 22:47:26.366 INFO 35616 --- [onPool-worker-5] org.frchen.dal.DepartmentRepository : BatchLoad departments by ids: [1, 2]
2020-03-15 22:47:26.367 INFO 35616 --- [onPool-worker-5] org.frchen.dal.EmployeeRepository : BatchLoad employees by departmentIds: [1, 2]
If it is failed, the client is blocking and waits for the response forever, and the server log is
2020-03-15 22:53:43.159 INFO 35616 --- [onPool-worker-6] org.frchen.dal.DepartmentRepository : BatchLoad departments by ids: [1, 2]